private/pedro/new doc type css var and notebookbar tab style #10581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pedropintosilva
commented
Nov 22, 2024
pedropintosilva
commented
- Introduce CSS color var doc-type and remove color dependent rules
- Notebookbar: new tabs style and tint them with the doc-type color
We now have data-doctype attribute that is being added to the <body> as an additional attribute so, use that to set a single css color var that changes depending on the attributes value and remove duplicated css bits. Additional note: for now it seems we can just use those colors also for dark mode so, no need to add additional lines to the color-palette-dark.css Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: Ife75487b3dfbe5d6ec6e4c961721c8734520786e
Also add animation on hover effect. Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: Ia68d38b7c2581699a31a9e4e17faca244c7028c9
eszkadev
approved these changes
Nov 22, 2024
|
it fails on |
no I didn;t I on purpose didn remove the border or change it : bc636e3#diff-5ebc1fc2a7ebdec867e4923cb0717249c9d25144496d92757e1c9690ff799519L24 and I see the tests have passed |
pedropintosilva
deleted the
private/pedro/new-doc-type-css-var-and-notebookbar-tab-style
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.