Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] A Switch to Turn Off Acrylic Effects #190

Closed
djdjz7 opened this issue Jul 3, 2023 · 6 comments
Closed

[Request] A Switch to Turn Off Acrylic Effects #190

djdjz7 opened this issue Jul 3, 2023 · 6 comments
Labels
Enhancement New feature or request

Comments

@djdjz7
Copy link

djdjz7 commented Jul 3, 2023

Is your feature request related to a problem? Please describe.
I've noticed that Collapse Launcher used a lot of acrylic effects. Although small amount of blur effects make the launcher look nice, the huge amount of effect applied here is making the app feel less responsive.

Describe the solution you'd like
Please, optimize the use of the acrylic effects. In my personal opinion, large areas (like settings page) should avoid applying the acrylic effect. Or, as an alternative, please add a switch to turn off the acrylic effect so that the launcher could run better on some low-end devices.

@djdjz7 djdjz7 added the Enhancement New feature or request label Jul 3, 2023
@bagusnl
Copy link
Member

bagusnl commented Jul 3, 2023

Hello, thank you for submitting an Enhancement request for our Launcher! Can you help us out fill these information so we can understand your current system better as your enhancement request is about performance of the launcher

System Information

Please attach a copy of dxdiag.txt to this issue so that we can better understand your hardware configuration: "Save all information" (Run > Type dxdiag then enter > Save all information > Then Drag & Drop the file to your issue, or attach it through the file selection dialog).

Collapse Version:

[Which Collapse version and release branch (stable/preview) you are currently running]

@djdjz7
Copy link
Author

djdjz7 commented Jul 3, 2023

System Information

DxDiag.txt

Collapse Verion

1.70.11 Stable

@bagusnl
Copy link
Member

bagusnl commented Jul 3, 2023

Thank you for providing the details! We will try and work on improving the launcher responsiveness.

While at it, we also notices both of your GPU drivers to be quite out-of-date. While this is most likely aren't related to your issue, it is advised that you follow your system guide on updating both your Intel UHD and Nvidia MX250 GPU Drivers.

@djdjz7
Copy link
Author

djdjz7 commented Jul 3, 2023

Thank you for providing the details! We will try and work on improving the launcher responsiveness.

While at it, we also notices both of your GPU drivers to be quite out-of-date. While this is most likely aren't related to your issue, it is advised that you follow your system guide on updating both your Intel UHD and Nvidia MX250 GPU Drivers.

Thanks a lot!
Actually, updating MX250's driver will make the performance worse. But I'll try updating Intel's later.

neon-nyan added a commit that referenced this issue Jul 21, 2023
- Reduced overhead while fetching launcher's sprites by using local ``FallbackCDNUtil``'s HTTP Client method.
- Using direct JSON deserialization from ``FallbackCDNUtil``'s ``DownloadAsJSONType<T>()`` for fetching launcher's API
- Improving Color Palette generation by using the latest ``ColorThief`` changes.
- Moving unrelated methods from ``BackgroundManagement`` to ``RegionManagement``
- Back to previous method while downloading game packages where merging the chunk is required before verification and extraction
- Removed overused ``GC.Collect()``
- Minor UI Changes, including:
    - Adding an ability to go back to the previous page
    - Making title icon clickable for "Back to Homepage" button (Issue: #131)
    - Adding an ability to disable acrylic effect (Issue: #190)
- Adding failsafe if the user choose invalid folders to be used as "App Folder" for the launcher on the first set-up.
- Fixed the rare state where the foreground image is shown outside of the home page.
@neon-nyan
Copy link
Member

Hi there,

We have been working on a setting to toggle this acrylic effects in the latest PR: #213. The feature is expected to be shipped in the next release.

Cryotechnic added a commit that referenced this issue Aug 4, 2023
* module update

plsdontbreakplsdontbreakplsdontbreakplsdontbreakplsdontbreak

* Fix full package detection (#202)

* Fix full package detection

Attempt to fix full package detection that returned 0 even if the file was fully downloaded

* Fix typo

English shenanigans

* Pre-load check (#200)

* Pre-load check

Attempt to identify if either full zip or slices preload are available

* Pre-load fix pt2

Why in the world was I calling the whole start download function while I could just run the get package list?

* Implement Cloudflare CDN (#204)

Using my domain for now due to the emergency of the situation

* disabled Bitbucket

* Game repairing supports Genshin CN server (#201)

* Update submodules

* Fix broken HSR game repair and cache (Issue: #206)

* Initial Commit

- Reduced overhead while fetching launcher's sprites by using local ``FallbackCDNUtil``'s HTTP Client method.
- Using direct JSON deserialization from ``FallbackCDNUtil``'s ``DownloadAsJSONType<T>()`` for fetching launcher's API
- Improving Color Palette generation by using the latest ``ColorThief`` changes.
- Moving unrelated methods from ``BackgroundManagement`` to ``RegionManagement``
- Back to previous method while downloading game packages where merging the chunk is required before verification and extraction
- Removed overused ``GC.Collect()``
- Minor UI Changes, including:
    - Adding an ability to go back to the previous page
    - Making title icon clickable for "Back to Homepage" button (Issue: #131)
    - Adding an ability to disable acrylic effect (Issue: #190)
- Adding failsafe if the user choose invalid folders to be used as "App Folder" for the launcher on the first set-up.
- Fixed the rare state where the foreground image is shown outside of the home page.

* Update submodule :pepeSadge:

* Update submodule :pepeSadge:

* Use custom KeyValuePairing for Genshin graphics settings

* Simplify the way to compare properties in Game Settings classes

* Add HI3 Community Tools

Elysian Realm Build Guide

* GameSettings - Add SFX Quality for HSR

* GameSettings - Update JSON order for GI

Also fixes some warnings in the code

* GameSettings - Fix nullable on HSR PCResolution

* Implement Borderless Screen game mode

* Organize HomePage.xaml.cs

oh ma gawd

* GameSettings - Use unsafe relaxed Json escaping for GI

why...

Co-authored-by: Kemal Setya Adhi <dev.kemalsetyaa@gmail.com>
Co-authored-by: Iskandar Montano <muscularcandy67@gmail.com>

* Update README.md

* Add Code of Conduct

using email from @neon-nyan profile

* Fix typo on Game Playtime panel minutes string

* Remove unused code + Update submodule

* Make ``ApplyAccentColor()`` run asynchronously

* Ensure IsInstancePropertyEqual check if either one of the value is null

* App Settings Improvements

- Move around some parts to make settings page a little bit more compact
- Hide some settings that depends on other
- [New] Add toggle to include Game logs inside Collapse Logs
- [New] Add contributors list button

* Improve Discord RPC Output

- Localize `Region:` string
- [New] Add Collapse version and branch string to SmallText

* Update locales

* Add debug lines for RegistryMonitor

In search of incredi- I mean bug in which RegistryMonitor randomly forces updates on HomePage

* Change operator for Metadata update

Use `<` instead of `!=` so that metadata will not get updated if local stamp is higher than remote, useful to test metadata locally and in the events of some CDN gets out of sync.

* Make Game Conversion feature work again

I didn't notice that this feature isn't working anymore since the last InstallManagement rewrite. However, this changes hopefully bring the feature back again as it should be.
This commit contains changes including:
- Fixes for Game Conversion feature.
- Fixed the IsGameInstalled() got bypassed after executable size check.

* Average the generated color palette generation

* Makes null compare in ``IsInstancePropertyEqual()`` easier to read

* Move development guides entirely to Contribution Guidelines

* Fix Discord button margin

* Avoid any Direct X files getting deleted in Hi3 Game Repair

* Try adding 20 more color palette to generate if fails

* Update BackgroundManagement.cs

* Adding back ``IsInstancePropertyEqual()`` usage in Genshin ``GeneralData``

* Margin adjustment and adding back blur effect toggle

* Adding back Bitbucket for the CDN

* Adding fallback on FallbackCDNUtil

* Enable ReadyToRun compilation

* Bring back @bagusnl's changes in HomePage.xaml.cs

* Fix not compiling on Debug (#215)

Logger issue

* Fix background toggle not working while page changes

* Fix potential undisposed stream in ``IsPreloadCompleted()``

* Add setting to toggle merging after download

* Avoid conflict while going back through pages

* Ensure if the page loaded first before navigating

* Fix for PRI263 Warnings

Somehow "BG" folder name is treated as language resource, thus the "PRI263: 0xdef01051 - No default or neutral resource given for 'Files/Assets/*'. The application may throw an exception for certain user configurations when retrieving the resources." warnings.
This commit tries to fix it by renaming the "BG" assets folder to "Images" and adjusting everything necessary for it.

Reference: https://developercommunity.visualstudio.com/t/uwp-resource-handling-fails-when-baseintermediateo/82838#T-N91468

Related to #211

* Change Background Filename

Addition to 46befc9

* Enable certain Quick Settings menu when game is running

Enhancement #197

This commits enables Quick Settings button when game is running like opening folders.. well that's basically it

* Lock packages for more consistent nuget restore

* Use action/cache@v3 for dotnet and nuget

* Update Readme

- Update release version
- Add action build status badge

* Shorten action artifact output file name

* Remove unused HPatchZ.dll lib

* Merge JSON Contexts into several one

* Remove duplicate file

* Update build.yml

- Disable debug artifact upload
- Fix artifact not uploading when selecting other SDK version
- Add branch name to artifact file name

* [workflow] Only install dotnet when cache is missed

whoops

* Revert last change

* Adding preps for Background download

* Adding method to force close game

Button located in Quick Settings panel

* Rewrite property static +add basic back. activity handle

* Add ``DispatcherQueue``  in ``IBackgroundActivity``

* Always duplicate current game property in each page

* Change notif type based on activity status

* Why did I remove this? :bruh:

* Fix GetVersion logic and package preload detection (#216)

* Fix not compiling on Debug

Logger issue

* Fix GetVersion logic

* Try to fix size detection in preload check

* Actually fixes preload check

* Remove unused transition

* Only spawn the Preload box if the calls completed

* added rider to gitignore

* Attempt to fix main after neon-changes merge (#217)

* First attempt to fix main

Removed duplicate #GameState region

* Second attempt to fix main

* Third and hopefully final commit to fix main

Too many commits merged

* Fix preload slices being detected as unused assets

* WinAppSDK NuGet update to 1.3.230724000

* Adjust GameSettings Base nullable

* make StopGame method sync

* added missing game icons

* include files during build

* added logic to show logo based on GameType during download

* forgot to gitignore a directory

* Ignore non-JSON line in packageversion (Fix: #219)

* Fix delta-patch doesn't work in new ``HonkaiInstall``

---------

Co-authored-by: Iskandar Montano <muscularcandy67@gmail.com>
Co-authored-by: Bagus Nur Listiyono <28079733+bagusnl@users.noreply.github.com>
Co-authored-by: Scighost <scighost@outlook.com>
Co-authored-by: Kemal Setya Adhi <dev.kemalsetyaa@gmail.com>
Co-authored-by: Bagus Nur Listiyono <dzakibagus@gmail.com>
@djdjz7
Copy link
Author

djdjz7 commented Aug 6, 2023

Tried the latest version, works great!

thanks for your work!

@djdjz7 djdjz7 closed this as completed Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants