Lint: Adding more checks for non internationalized strings #5625
Conversation
🎭 Playwright Test Results⏰ Completed at: 11/25/2025, 05:43:29 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
DrJKL
changed the title
|
SGTM! |
|
I'm not a frontend engineer, so I can't review this change. Claude can do better, haha. |
dosubot
bot
added
the
size:S
## Summary - Fix i18n linting errors by adding missing locale keys to `src/locales/en/main.json` - Update all affected components to use `$t()` for internationalization ## Changes Added the following locale keys: - `comfyOrgLogoAlt`: "ComfyOrg Logo" - `comfy`: "Comfy" - `pressKeysForNewBinding`: "Press keys for new binding" - `defaultBanner`: "default banner" - `enableOrDisablePack`: "Enable or disable pack" - `openManager`: "Open Manager" - `graphNavigation`: "Graph navigation" Updated components to use i18n keys: - `ComfyOrgHeader.vue` - `KeybindingPanel.vue` - `PackBanner.vue` - `PackIcon.vue` - `PackEnableToggle.vue` - `LoadWorkflowWarning.vue` - `SubgraphBreadcrumb.vue` - `SignInContent.vue` ## Test plan - [x] Run `pnpm lint` - all i18n linting errors resolved - [x] Pre-commit hooks pass Aim to make #5625 CI/CD pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6170-bugfix-Fix-i18n-linting-errors-2926d73d365081c3b7fbcbbf4a8e03d6) by [Unito](https://www.unito.io) Co-authored-by: Claude <noreply@anthropic.com>
DrJKL
force-pushed
the
drjkl/i18n-linting
branch
from
aac1538 to
f61ab10
Compare
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/25/2025, 05:35:06 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.18 MB (baseline 3.18 MB) • 🔴 +702 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 940 kB (baseline 940 kB) • 🔴 +214 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 297 kB (baseline 297 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 139 kB (baseline 139 kB) • 🔴 +85 BReusable component library chunks
Status: 6 added / 6 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.84 MB (baseline 3.84 MB) • 🔴 +182 BBundles that do not match a named category
Status: 18 added / 18 removed |
|
we could also fix the failing tests associated with the new rules |
Yeah, I wasn't planning on merging this until they were updated. It was a draft, but @snomiao kicked things off with the other PR |
|
*clicked update branch |
## Summary This PR fixes all @intlify/vue-i18n/no-raw-text linting errors identified in #5625 by replacing raw text strings with proper i18n translation function calls. ## Changes Fixed i18n linting errors in the following files: - `src/components/widget/SampleModelSelector.vue` - "Upload Model" → `$t('g.upload')` - `src/components/topbar/CurrentUserButton.vue` - "user profile" → `$t('g.currentUser')` - `src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue` - "Loading help" → `$t('g.loading')` - `src/components/sidebar/SidebarShortcutsToggleButton.vue` - "shortcuts.shortcuts" → `$t('shortcuts.shortcuts')` - `src/components/sidebar/SidebarLogoutIcon.vue` - "sideToolbar.logout" → `$t('sideToolbar.logout')` - `src/components/sidebar/SidebarHelpCenterIcon.vue` - "menu.help" → `$t('menu.help')` - `src/components/sidebar/SidebarBottomPanelToggleButton.vue` - "sideToolbar.labels.console" → `$t('sideToolbar.labels.console')` - `src/components/load3d/controls/viewer/ViewerCameraControls.vue` - "fov" → `t('load3d.fov')` - `src/components/helpcenter/HelpCenterMenuContent.vue` - "Help Center Menu" and "Recent releases" → `$t()` calls All raw text strings have been replaced with appropriate i18n translation keys that already exist in `src/locales/en/main.json`. ## Related Issue Fixes errors reported in CI job: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/18705105609/job/53341658467?pr=5625 This PR aims to help #5625 pass CI/CD checks. ## Test Plan - All i18n linting errors should be resolved - No functionality changes - only proper use of i18n system - Existing translation keys are used from the locale files ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6280-bugfix-fix-intlify-vue-i18n-no-raw-text-linting-errors-2976d73d365081369b43de01486fb409) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com>
DrJKL
force-pushed
the
drjkl/i18n-linting
branch
from
6cdb02b to
85de667
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/platform/assets/components/MediaAssetMoreMenu.vue (1)
9-15: Add missing i18n translations to all non-English locale filesThe component now uses
$t('queue.jobMenu.*')bindings for 7 menu labels. While all keys exist insrc/locales/en/main.json, thejobMenuobject is missing from all 9 other language files (ar, es, fr, ja, ko, ru, tr, zh, zh-TW).This means non-English users will see i18n key fallback text instead of translated menu labels. Add the
jobMenuobject and its 7 keys to each locale file before merging:
src/locales/ar/main.jsonsrc/locales/es/main.jsonsrc/locales/fr/main.jsonsrc/locales/ja/main.jsonsrc/locales/ko/main.jsonsrc/locales/ru/main.jsonsrc/locales/tr/main.jsonsrc/locales/zh/main.jsonsrc/locales/zh-TW/main.json
🧹 Nitpick comments (1)
src/components/maskeditor/BrushSettingsPanel.vue (1)
82-89: Inconsistent i18n function usage.Line 83 uses
$t('maskEditor.stepSize')while the otherSliderControlcomponents (lines 56, 65, 74) use the importedt()function. For consistency within this component, prefer using the same pattern.<SliderControl - :label="$t('maskEditor.stepSize')" + :label="t('maskEditor.stepSize')" :min="1" :max="100" :step="1"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
eslint.config.ts(2 hunks)src/components/maskeditor/BrushSettingsPanel.vue(1 hunks)src/components/queue/CompletionSummaryBanner.vue(1 hunks)src/components/widget/SampleModelSelector.vue(3 hunks)src/locales/en/main.json(8 hunks)src/platform/assets/components/AssetGrid.vue(1 hunks)src/platform/assets/components/MediaAssetMoreMenu.vue(6 hunks)src/platform/cloud/onboarding/CloudSurveyView.vue(4 hunks)src/platform/cloud/onboarding/components/CloudLogo.vue(1 hunks)src/renderer/extensions/vueNodes/widgets/components/audio/AudioPreviewPlayer.vue(3 hunks)src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue(1 hunks)src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenuActions.vue(1 hunks)src/workbench/extensions/manager/components/ManagerProgressFooter.vue(2 hunks)tests-ui/tests/components/dialog/footer/ManagerProgressFooter.test.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (9)
- src/platform/assets/components/AssetGrid.vue
- src/workbench/extensions/manager/components/ManagerProgressFooter.vue
- src/components/widget/SampleModelSelector.vue
- src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenuActions.vue
- src/platform/cloud/onboarding/CloudSurveyView.vue
- src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue
- src/components/queue/CompletionSummaryBanner.vue
- tests-ui/tests/components/dialog/footer/ManagerProgressFooter.test.ts
- src/renderer/extensions/vueNodes/widgets/components/audio/AudioPreviewPlayer.vue
🧰 Additional context used
📓 Path-based instructions (18)
**/*.vue
📄 CodeRabbit inference engine (.cursorrules)
**/*.vue: Use setup() function for component logic in Vue 3 Composition API
Utilize ref and reactive for reactive state in Vue 3
Implement computed properties with computed() function
Use watch and watchEffect for side effects in Vue 3
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection in Vue 3
Use Vue 3.5 style of default prop declaration with defineProps()
Organize Vue components in <script> <style> order
Use Tailwind CSS for styling Vue components
Implement responsive design with Tailwind CSS
Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectively
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components in Vue 3
Follow Vue 3 style guide and naming conventions
Never use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage)Never use
:class="[]"to merge class names - always useimport { cn } from '@/utils/tailwindUtil'for class merging in Vue templates
**/*.vue: Use TypeScript with Vue 3 Single File Components (.vuefiles)
Name Vue components in PascalCase (e.g.,MenuHamburger.vue)Files:
src/platform/assets/components/MediaAssetMoreMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/components/maskeditor/BrushSettingsPanel.vue**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (.cursorrules)
**/*.{vue,ts,tsx}: Leverage VueUse functions for performance-enhancing utilities
Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.jsonFiles:
src/platform/assets/components/MediaAssetMoreMenu.vueeslint.config.tssrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/components/maskeditor/BrushSettingsPanel.vue**/*.{ts,tsx,js,vue}
📄 CodeRabbit inference engine (.cursorrules)
Implement proper error handling in components and services
**/*.{ts,tsx,js,vue}: Use 2-space indentation, single quotes, no semicolons, and maintain 80-character line width as configured in.prettierrc
Organize imports by sorting and grouping by plugin, and runpnpm formatbefore committingFiles:
src/platform/assets/components/MediaAssetMoreMenu.vueeslint.config.tssrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/components/maskeditor/BrushSettingsPanel.vuesrc/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventionsFiles:
src/platform/assets/components/MediaAssetMoreMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/components/maskeditor/BrushSettingsPanel.vuesrc/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.jsonFiles:
src/platform/assets/components/MediaAssetMoreMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/components/maskeditor/BrushSettingsPanel.vue**/*.{ts,tsx,js,jsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
Use camelCase for variable and setting names in TypeScript/Vue files
Files:
src/platform/assets/components/MediaAssetMoreMenu.vueeslint.config.tssrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/components/maskeditor/BrushSettingsPanel.vue**/*.{vue,html}
📄 CodeRabbit inference engine (CLAUDE.md)
Never use
dark:ordark-theme:Tailwind variants - instead use semantic values fromstyle.csstheme, e.g.bg-node-component-surfaceFiles:
src/platform/assets/components/MediaAssetMoreMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/components/maskeditor/BrushSettingsPanel.vue**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,vue}: Useconst settingStore = useSettingStore()andsettingStore.get('Comfy.SomeSetting')to retrieve settings in TypeScript/Vue files
Useawait settingStore.set('Comfy.SomeSetting', newValue)to update settings in TypeScript/Vue files
Check server capabilities usingapi.serverSupportsFeature('feature_name')before using enhanced features
Useapi.getServerFeature('config_name', defaultValue)to retrieve server feature configurationEnforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templates
Files:
src/platform/assets/components/MediaAssetMoreMenu.vueeslint.config.tssrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/components/maskeditor/BrushSettingsPanel.vuesrc/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebaseFiles:
src/platform/assets/components/MediaAssetMoreMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/components/maskeditor/BrushSettingsPanel.vuesrc/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/platform/assets/components/MediaAssetMoreMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/components/maskeditor/BrushSettingsPanel.vuesrc/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/platform/assets/components/MediaAssetMoreMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/components/maskeditor/BrushSettingsPanel.vuesrc/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.jsonFiles:
src/platform/assets/components/MediaAssetMoreMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/components/maskeditor/BrushSettingsPanel.vue**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursorrules)
Use es-toolkit for utility functions
Files:
eslint.config.ts**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursorrules)
Use TypeScript for type safety
**/*.{ts,tsx}: Never useanytype - use proper TypeScript types
Never useas anytype assertions - fix the underlying type issueFiles:
eslint.config.ts**/*.ts
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.ts: Define dynamic setting defaults using runtime context with functions in settings configuration
UsedefaultsByInstallVersionproperty for gradual feature rollout based on version in settings configurationFiles:
eslint.config.tssrc/components/**/*.vue
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue componentsFiles:
src/components/maskeditor/BrushSettingsPanel.vuesrc/components/**/*.{vue,css}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system packageFiles:
src/components/maskeditor/BrushSettingsPanel.vuesrc/components/**/*.{vue,ts,js}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI stringsFiles:
src/components/maskeditor/BrushSettingsPanel.vue🧠 Learnings (9)
📓 Common learnings
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: AGENTS.md:0-0 Timestamp: 2025-11-24T19:48:23.077Z Learning: Pull requests must pass `pnpm lint`, `pnpm typecheck`, and relevant tests before merging; keep PRs focused and smallLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:34.296Z Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.608Z Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI stringsLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.254Z Learning: Applies to **/*.{vue,ts,tsx} : Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.jsonLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-11-24T19:47:02.828Z Learning: Applies to src/**/*.{vue,ts} : Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.jsonLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: AGENTS.md:0-0 Timestamp: 2025-11-24T19:48:23.077Z Learning: Applies to **/*.{ts,tsx,vue} : Enforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templatesLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.608Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue InlineMessage component with MessageLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.607Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue Chips component with AutoComplete with multiple enabledLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.254Z Learning: Applies to **/*.vue : Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectivelyLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.607Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitchLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.254Z Learning: Applies to **/*.vue : Follow Vue 3 style guide and naming conventions📚 Learning: 2025-11-24T19:47:34.296Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:34.296Z Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`Applied to files:
src/platform/assets/components/MediaAssetMoreMenu.vuesrc/locales/en/main.jsoneslint.config.tssrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/components/maskeditor/BrushSettingsPanel.vue📚 Learning: 2025-11-24T19:46:52.254Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.254Z Learning: Applies to **/*.{vue,ts,tsx} : Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.jsonApplied to files:
src/platform/assets/components/MediaAssetMoreMenu.vueeslint.config.tssrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/components/maskeditor/BrushSettingsPanel.vue📚 Learning: 2025-11-24T19:48:23.077Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: AGENTS.md:0-0 Timestamp: 2025-11-24T19:48:23.077Z Learning: Applies to **/*.{ts,tsx,vue} : Enforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templatesApplied to files:
eslint.config.ts📚 Learning: 2025-11-24T19:47:02.828Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-11-24T19:47:02.828Z Learning: Applies to src/**/*.{vue,ts} : Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.jsonApplied to files:
eslint.config.tssrc/platform/cloud/onboarding/components/CloudLogo.vue📚 Learning: 2025-11-24T19:47:45.608Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.608Z Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI stringsApplied to files:
eslint.config.tssrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/components/maskeditor/BrushSettingsPanel.vue📚 Learning: 2025-11-24T19:47:34.296Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:34.296Z Learning: Applies to src/**/*.{vue,ts,tsx} : Follow Vue 3 composition API style guideApplied to files:
eslint.config.ts📚 Learning: 2025-11-24T19:48:23.077Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: AGENTS.md:0-0 Timestamp: 2025-11-24T19:48:23.077Z Learning: Applies to **/*.{ts,tsx,js,vue} : Use 2-space indentation, single quotes, no semicolons, and maintain 80-character line width as configured in `.prettierrc`Applied to files:
eslint.config.ts📚 Learning: 2025-11-24T19:47:45.608Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.608Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue Steps component with Stepper without panelsApplied to files:
src/components/maskeditor/BrushSettingsPanel.vue⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: deploy-and-comment
- GitHub Check: setup
- GitHub Check: lint-and-format
- GitHub Check: test
- GitHub Check: collect
🔇 Additional comments (7)
eslint.config.ts (1)
194-206: Good attribute coverage for i18n enforcement.The attributes configuration correctly targets accessibility attributes (
aria-label,aria-placeholder, etc.) and user-visible attributes (label,placeholder,title). Thev-tooltipinclusion addresses the previous reviewer's concern about catching tooltip directives.src/platform/cloud/onboarding/components/CloudLogo.vue (1)
3-7: LGTM!The alt text is correctly localized using the
subscription.comfyCloudLogokey, aligning with the coding guidelines requirement to use vue-i18n for all user-facing strings.src/locales/en/main.json (5)
108-108: LGTM!The new translation keys (
submit,playPause,profile,noItems,beta) are properly added to theg(global) namespace and follow the existing naming conventions.Also applies to: 238-249
696-696: LGTM!The
previewkey is correctly placed undersideToolbar.queueProgressOverlaynamespace.
938-938: LGTM!The
stepSizekey is correctly added undermaskEditornamespace, supporting the localization inBrushSettingsPanel.vue.
1844-1844: LGTM!The
comfyCloudLogokey is correctly placed under thesubscriptionnamespace, matching the i18n binding inCloudLogo.vue.
2080-2080: LGTM!The new
assetBrowserkeys (assetCollection,selectFrameworks,selectProjects,sortingType) are properly added and follow existing conventions.Also applies to: 2131-2133
DrJKL
force-pushed
the
drjkl/i18n-linting
branch
from
85de667 to
6c902b8
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
eslint.config.ts (1)
215-237: Past review comment already identified unused entries in ignoreText.The concerns about
'App Data:','App Path:', and'1.2 MB'have been raised in previous reviews. These entries should be removed or verified as necessary.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
eslint.config.ts(2 hunks)src/components/maskeditor/BrushSettingsPanel.vue(1 hunks)src/components/queue/CompletionSummaryBanner.vue(1 hunks)src/components/widget/SampleModelSelector.vue(3 hunks)src/locales/en/main.json(8 hunks)src/platform/assets/components/AssetGrid.vue(1 hunks)src/platform/assets/components/MediaAssetMoreMenu.vue(6 hunks)src/platform/cloud/onboarding/CloudSurveyView.vue(4 hunks)src/platform/cloud/onboarding/components/CloudLogo.vue(1 hunks)src/renderer/extensions/vueNodes/widgets/components/audio/AudioPreviewPlayer.vue(3 hunks)src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue(1 hunks)src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenuActions.vue(1 hunks)src/workbench/extensions/manager/components/ManagerProgressFooter.vue(2 hunks)tests-ui/tests/components/dialog/footer/ManagerProgressFooter.test.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (8)
- tests-ui/tests/components/dialog/footer/ManagerProgressFooter.test.ts
- src/components/maskeditor/BrushSettingsPanel.vue
- src/platform/cloud/onboarding/CloudSurveyView.vue
- src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenuActions.vue
- src/components/widget/SampleModelSelector.vue
- src/renderer/extensions/vueNodes/widgets/components/audio/AudioPreviewPlayer.vue
- src/platform/assets/components/AssetGrid.vue
- src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue
🧰 Additional context used
📓 Path-based instructions (18)
**/*.vue
📄 CodeRabbit inference engine (.cursorrules)
**/*.vue: Use setup() function for component logic in Vue 3 Composition API
Utilize ref and reactive for reactive state in Vue 3
Implement computed properties with computed() function
Use watch and watchEffect for side effects in Vue 3
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection in Vue 3
Use Vue 3.5 style of default prop declaration with defineProps()
Organize Vue components in <script> <style> order
Use Tailwind CSS for styling Vue components
Implement responsive design with Tailwind CSS
Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectively
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components in Vue 3
Follow Vue 3 style guide and naming conventions
Never use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage)Never use
:class="[]"to merge class names - always useimport { cn } from '@/utils/tailwindUtil'for class merging in Vue templates
**/*.vue: Use TypeScript with Vue 3 Single File Components (.vuefiles)
Name Vue components in PascalCase (e.g.,MenuHamburger.vue)Files:
src/workbench/extensions/manager/components/ManagerProgressFooter.vuesrc/platform/assets/components/MediaAssetMoreMenu.vuesrc/components/queue/CompletionSummaryBanner.vuesrc/platform/cloud/onboarding/components/CloudLogo.vue**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (.cursorrules)
**/*.{vue,ts,tsx}: Leverage VueUse functions for performance-enhancing utilities
Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.jsonFiles:
src/workbench/extensions/manager/components/ManagerProgressFooter.vuesrc/platform/assets/components/MediaAssetMoreMenu.vuesrc/components/queue/CompletionSummaryBanner.vueeslint.config.tssrc/platform/cloud/onboarding/components/CloudLogo.vue**/*.{ts,tsx,js,vue}
📄 CodeRabbit inference engine (.cursorrules)
Implement proper error handling in components and services
**/*.{ts,tsx,js,vue}: Use 2-space indentation, single quotes, no semicolons, and maintain 80-character line width as configured in.prettierrc
Organize imports by sorting and grouping by plugin, and runpnpm formatbefore committingFiles:
src/workbench/extensions/manager/components/ManagerProgressFooter.vuesrc/platform/assets/components/MediaAssetMoreMenu.vuesrc/components/queue/CompletionSummaryBanner.vueeslint.config.tssrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventionsFiles:
src/workbench/extensions/manager/components/ManagerProgressFooter.vuesrc/platform/assets/components/MediaAssetMoreMenu.vuesrc/components/queue/CompletionSummaryBanner.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.jsonFiles:
src/workbench/extensions/manager/components/ManagerProgressFooter.vuesrc/platform/assets/components/MediaAssetMoreMenu.vuesrc/components/queue/CompletionSummaryBanner.vuesrc/platform/cloud/onboarding/components/CloudLogo.vue**/*.{ts,tsx,js,jsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
Use camelCase for variable and setting names in TypeScript/Vue files
Files:
src/workbench/extensions/manager/components/ManagerProgressFooter.vuesrc/platform/assets/components/MediaAssetMoreMenu.vuesrc/components/queue/CompletionSummaryBanner.vueeslint.config.tssrc/platform/cloud/onboarding/components/CloudLogo.vue**/*.{vue,html}
📄 CodeRabbit inference engine (CLAUDE.md)
Never use
dark:ordark-theme:Tailwind variants - instead use semantic values fromstyle.csstheme, e.g.bg-node-component-surfaceFiles:
src/workbench/extensions/manager/components/ManagerProgressFooter.vuesrc/platform/assets/components/MediaAssetMoreMenu.vuesrc/components/queue/CompletionSummaryBanner.vuesrc/platform/cloud/onboarding/components/CloudLogo.vue**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,vue}: Useconst settingStore = useSettingStore()andsettingStore.get('Comfy.SomeSetting')to retrieve settings in TypeScript/Vue files
Useawait settingStore.set('Comfy.SomeSetting', newValue)to update settings in TypeScript/Vue files
Check server capabilities usingapi.serverSupportsFeature('feature_name')before using enhanced features
Useapi.getServerFeature('config_name', defaultValue)to retrieve server feature configurationEnforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templates
Files:
src/workbench/extensions/manager/components/ManagerProgressFooter.vuesrc/platform/assets/components/MediaAssetMoreMenu.vuesrc/components/queue/CompletionSummaryBanner.vueeslint.config.tssrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebaseFiles:
src/workbench/extensions/manager/components/ManagerProgressFooter.vuesrc/platform/assets/components/MediaAssetMoreMenu.vuesrc/components/queue/CompletionSummaryBanner.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/workbench/extensions/manager/components/ManagerProgressFooter.vuesrc/platform/assets/components/MediaAssetMoreMenu.vuesrc/components/queue/CompletionSummaryBanner.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/workbench/extensions/manager/components/ManagerProgressFooter.vuesrc/platform/assets/components/MediaAssetMoreMenu.vuesrc/components/queue/CompletionSummaryBanner.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.jsonFiles:
src/workbench/extensions/manager/components/ManagerProgressFooter.vuesrc/platform/assets/components/MediaAssetMoreMenu.vuesrc/components/queue/CompletionSummaryBanner.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/components/**/*.vue
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue componentsFiles:
src/components/queue/CompletionSummaryBanner.vuesrc/components/**/*.{vue,css}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system packageFiles:
src/components/queue/CompletionSummaryBanner.vuesrc/components/**/*.{vue,ts,js}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI stringsFiles:
src/components/queue/CompletionSummaryBanner.vue**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursorrules)
Use es-toolkit for utility functions
Files:
eslint.config.ts**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursorrules)
Use TypeScript for type safety
**/*.{ts,tsx}: Never useanytype - use proper TypeScript types
Never useas anytype assertions - fix the underlying type issueFiles:
eslint.config.ts**/*.ts
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.ts: Define dynamic setting defaults using runtime context with functions in settings configuration
UsedefaultsByInstallVersionproperty for gradual feature rollout based on version in settings configurationFiles:
eslint.config.ts🧠 Learnings (8)
📓 Common learnings
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:34.296Z Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.608Z Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI stringsLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.254Z Learning: Applies to **/*.{vue,ts,tsx} : Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.jsonLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-11-24T19:47:02.828Z Learning: Applies to src/**/*.{vue,ts} : Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.jsonLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: AGENTS.md:0-0 Timestamp: 2025-11-24T19:48:23.077Z Learning: Applies to **/*.{ts,tsx,vue} : Enforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templatesLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.607Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue Chips component with AutoComplete with multiple enabledLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.608Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue InlineMessage component with MessageLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.254Z Learning: Applies to **/*.vue : Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectivelyLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:34.296Z Learning: Applies to src/**/*.{ts,tsx,vue} : Implement proper TypeScript types throughout the codebaseLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.607Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitch📚 Learning: 2025-11-24T19:47:45.608Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.608Z Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI stringsApplied to files:
src/workbench/extensions/manager/components/ManagerProgressFooter.vueeslint.config.ts📚 Learning: 2025-11-24T19:47:34.296Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:34.296Z Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`Applied to files:
src/workbench/extensions/manager/components/ManagerProgressFooter.vuesrc/platform/assets/components/MediaAssetMoreMenu.vuesrc/components/queue/CompletionSummaryBanner.vueeslint.config.tssrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/locales/en/main.json📚 Learning: 2025-11-24T19:46:52.254Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.254Z Learning: Applies to **/*.{vue,ts,tsx} : Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.jsonApplied to files:
src/workbench/extensions/manager/components/ManagerProgressFooter.vuesrc/platform/assets/components/MediaAssetMoreMenu.vuesrc/components/queue/CompletionSummaryBanner.vueeslint.config.tssrc/platform/cloud/onboarding/components/CloudLogo.vue📚 Learning: 2025-11-24T19:47:45.607Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.607Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with PopoverApplied to files:
src/workbench/extensions/manager/components/ManagerProgressFooter.vue📚 Learning: 2025-11-24T19:47:02.828Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-11-24T19:47:02.828Z Learning: Applies to src/**/*.{vue,ts} : Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.jsonApplied to files:
src/components/queue/CompletionSummaryBanner.vueeslint.config.ts📚 Learning: 2025-11-24T19:48:23.077Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: AGENTS.md:0-0 Timestamp: 2025-11-24T19:48:23.077Z Learning: Applies to **/*.{ts,tsx,vue} : Enforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templatesApplied to files:
eslint.config.ts📚 Learning: 2025-11-24T19:48:23.077Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: AGENTS.md:0-0 Timestamp: 2025-11-24T19:48:23.077Z Learning: Applies to **/*.{ts,tsx,js,vue} : Use 2-space indentation, single quotes, no semicolons, and maintain 80-character line width as configured in `.prettierrc`Applied to files:
eslint.config.ts⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: test
- GitHub Check: setup
- GitHub Check: lint-and-format
- GitHub Check: collect
🔇 Additional comments (7)
eslint.config.ts (1)
194-206: LGTM! Comprehensive attribute coverage for i18n enforcement.The attributes mapping correctly enforces i18n for accessibility (ARIA) and UI attributes across all elements, with proper scoping of
alttoimgelements only. The inclusion ofv-tooltipaddresses the concern raised in past comments.src/components/queue/CompletionSummaryBanner.vue (1)
28-32: LGTM! Alt text properly internationalized.The thumbnail alt attribute is correctly bound to the i18n key, following the established pattern for accessibility text localization.
src/platform/cloud/onboarding/components/CloudLogo.vue (1)
3-7: LGTM! Alt text properly localized.The image alt attribute is correctly bound to the i18n key under the
subscriptionnamespace. The typo noted in past reviews has been addressed.src/workbench/extensions/manager/components/ManagerProgressFooter.vue (2)
52-58: LGTM! Conditional aria-label properly internationalized.The expand/collapse button correctly uses conditional i18n binding based on the dialog state. The translation keys are appropriately namespaced under
contextMenu.
68-68: LGTM! Close button aria-label properly localized.The close button correctly uses the global i18n key for common UI strings.
src/platform/assets/components/MediaAssetMoreMenu.vue (1)
9-86: LGTM! All menu labels properly internationalized.All button labels are correctly bound to i18n keys under the
queue.jobMenunamespace. The implementation is consistent and follows established i18n patterns.src/locales/en/main.json (1)
108-108: LGTM! Translation keys properly added for new i18n bindings.All new translation keys are appropriately namespaced and support the UI components that were updated to use i18n. The keys follow established naming conventions.
Also applies to: 238-238, 248-249, 696-696, 938-938, 1844-1844, 2080-2080, 2131-2133
DrJKL
added
claude-review
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| 'error', | ||
| { | ||
| attributes: { | ||
| '/.+/': [ |
There was a problem hiding this comment.
[performance] medium Priority
Issue: Potentially inefficient regex pattern /.+/ used for all element attributes
Context: The pattern /.+/ will match every element in the Vue templates, which could slow down linting on large components with many elements
Suggestion: Consider using more specific element patterns or grouping common attributes to avoid the catch-all regex that processes every single element
There was a problem hiding this comment.
If only...
But we could split this and some other slow rules out to a dedicated config (later).
There was a problem hiding this comment.
Pull request overview
This PR enhances the internationalization (i18n) linter to catch more user-visible text that isn't internationalized. The linter now checks additional HTML attributes for raw text strings, ensuring better support for non-English locales.
- Expands ESLint i18n rules to check common accessibility and UI attributes (aria-label, placeholder, title, alt, etc.)
- Converts hardcoded English strings in Vue components to use i18n translation keys
- Adds corresponding translation entries to the English locale file and test mocks
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eslint.config.ts | Added comprehensive attributes list to i18n linter configuration to check aria-label, placeholder, title, alt, and other user-facing attributes for raw text |
| src/locales/en/main.json | Added new translation keys for submit, playPause, profile, noItems, preview, stepSize, comfyCloudLogo, assetCollection, and filter selection labels |
| tests-ui/tests/components/dialog/footer/ManagerProgressFooter.test.ts | Updated test mocks to include translation keys for close, Collapse, and Expand |
| src/workbench/extensions/manager/components/ManagerProgressFooter.vue | Replaced hardcoded aria-label strings with i18n keys for Close, Collapse, and Expand buttons |
| src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenuActions.vue | Replaced hardcoded "Search" placeholder with i18n key |
| src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue | Replaced hardcoded "No items" title with i18n key |
| src/renderer/extensions/vueNodes/widgets/components/audio/AudioPreviewPlayer.vue | Replaced hardcoded aria-labels for Play/Pause, Volume, and More Options with i18n keys |
| src/platform/cloud/onboarding/components/CloudLogo.vue | Replaced hardcoded alt text "Comfy Cloud Logo" with i18n key |
| src/platform/cloud/onboarding/CloudSurveyView.vue | Replaced hardcoded button labels (Next, Back, Submit) and placeholder text with i18n keys |
| src/platform/assets/components/MediaAssetMoreMenu.vue | Replaced hardcoded menu item labels with i18n keys from queue.jobMenu namespace |
| src/platform/assets/components/AssetGrid.vue | Replaced hardcoded aria-label for asset grid with i18n key |
| src/components/widget/SampleModelSelector.vue | Replaced hardcoded labels for Settings, Profile, and dropdown selectors with i18n keys |
| src/components/queue/CompletionSummaryBanner.vue | Replaced hardcoded alt text "preview" with i18n key |
| src/components/maskeditor/BrushSettingsPanel.vue | Replaced hardcoded "Stepsize" label with properly spelled i18n key "stepSize" |
| '^[^a-zA-Z]*$|^.{0,1}$|^[\\w._%+-]+@[\\w.-]+\\.[A-Za-z]{2,}$', | ||
| ignoreNodes: ['md-icon', 'v-icon', 'pre', 'code', 'script', 'style'], | ||
| // Brand names and technical terms that shouldn't be translated | ||
| ignoreText: [ |
There was a problem hiding this comment.
[quality] low Priority
Issue: Inconsistent ordering in ignoreText array
Context: The array mixes different categories (file formats, units, brand names) without clear organization, making it harder to maintain
Suggestion: Consider grouping related items (units: GB/KB/MB/ms/px, formats: png/JSON/YAML, brands: ComfyUI/GitHub/OpenAI) or adding comments to document the organization
There was a problem hiding this comment.
It's alphabetical, except for 1.2 MB
There was a problem hiding this comment.
Comprehensive PR Review
This review is generated by Claude. It may not always be accurate, as with human reviewers. If you believe that any of the comments are invalid or incorrect, please state why for each. For others, please implement the changes in one way or another.
Review Summary
PR: Lint: Adding more checks for non internationalized strings (#5625)
Impact: 95 additions, 45 deletions across 14 files
Issue Distribution
- Critical: 0
- High: 0
- Medium: 1
- Low: 1
Category Breakdown
- Architecture: 0 issues
- Security: 0 issues
- Performance: 1 issue
- Code Quality: 1 issue
Key Findings
Architecture & Design
This PR follows established i18n patterns well. The changes consistently replace hardcoded English strings with proper $t() translation calls, and the new ESLint rule configuration follows the existing structure. The addition of more attribute checks (aria-label, placeholder, title, etc.) is architecturally sound and fills gaps in the current i18n coverage.
Security Considerations
No security issues identified. The changes are limited to linting configuration and text internationalization, which poses no security risks.
Performance Impact
One medium-priority concern with the catch-all regex pattern /.+/ that will match every element in Vue templates. This could impact linting performance on large components, though the impact is likely minimal for typical use cases.
Integration Points
The changes properly integrate with the existing i18n system and maintain backward compatibility. All hardcoded strings were correctly mapped to appropriate translation keys in the locales file.
Positive Observations
- Excellent consistency in applying the $t() pattern across all changed files
- Proper test updates to include the new translation keys
- Good organization of the ignoreText array with relevant technical terms and brand names
- The new linting rules catch important accessibility attributes (aria-label, alt text) that improve internationalization coverage
- Changes follow established Vue 3 + i18n patterns in the codebase
References
Next Steps
- Consider addressing the regex performance suggestion for better linting efficiency
- Optional: Organize the ignoreText array for better maintainability
- The changes are ready for merge - this is a valuable improvement to i18n coverage
This is a comprehensive automated review. For architectural decisions requiring human judgment, please request additional manual review.
github-actions
bot
removed
the
claude-review
DrJKL
force-pushed
the
drjkl/i18n-linting
branch
from
5a3fa19 to
d975a19
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/platform/cloud/onboarding/CloudSurveyView.vue (1)
83-91: Consider a more semantically appropriate translation key.The
useCaseOtherplaceholder usescloudOnboarding.survey.options.industry.otherPlaceholder, which references "industry" in the key path but is used for a use-case field. While "Please specify" is generic enough to work, using a key that semantically matches the field (or a shared generic key) would be clearer.Consider one of these approaches:
:placeholder=" - $t('cloudOnboarding.survey.options.industry.otherPlaceholder') + $t('cloudOnboarding.survey.options.otherPlaceholder') "Or add a dedicated use-case key to
main.json:"useCase": { "otherPlaceholder": "Please specify" }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
eslint.config.ts(2 hunks)src/components/maskeditor/BrushSettingsPanel.vue(1 hunks)src/components/queue/CompletionSummaryBanner.vue(1 hunks)src/components/widget/SampleModelSelector.vue(3 hunks)src/locales/en/main.json(8 hunks)src/platform/assets/components/AssetGrid.vue(1 hunks)src/platform/assets/components/MediaAssetMoreMenu.vue(6 hunks)src/platform/cloud/onboarding/CloudSurveyView.vue(4 hunks)src/platform/cloud/onboarding/components/CloudLogo.vue(1 hunks)src/renderer/extensions/vueNodes/widgets/components/audio/AudioPreviewPlayer.vue(3 hunks)src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue(1 hunks)src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenuActions.vue(1 hunks)src/workbench/extensions/manager/components/ManagerProgressFooter.vue(2 hunks)tests-ui/tests/components/dialog/footer/ManagerProgressFooter.test.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (9)
- tests-ui/tests/components/dialog/footer/ManagerProgressFooter.test.ts
- src/components/maskeditor/BrushSettingsPanel.vue
- src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenuActions.vue
- src/components/queue/CompletionSummaryBanner.vue
- src/renderer/extensions/vueNodes/widgets/components/audio/AudioPreviewPlayer.vue
- src/platform/assets/components/MediaAssetMoreMenu.vue
- src/workbench/extensions/manager/components/ManagerProgressFooter.vue
- src/components/widget/SampleModelSelector.vue
- eslint.config.ts
🧰 Additional context used
📓 Path-based instructions (12)
**/*.vue
📄 CodeRabbit inference engine (.cursorrules)
**/*.vue: Use setup() function for component logic in Vue 3 Composition API
Utilize ref and reactive for reactive state in Vue 3
Implement computed properties with computed() function
Use watch and watchEffect for side effects in Vue 3
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection in Vue 3
Use Vue 3.5 style of default prop declaration with defineProps()
Organize Vue components in <script> <style> order
Use Tailwind CSS for styling Vue components
Implement responsive design with Tailwind CSS
Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectively
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components in Vue 3
Follow Vue 3 style guide and naming conventions
Never use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage)Never use
:class="[]"to merge class names - always useimport { cn } from '@/utils/tailwindUtil'for class merging in Vue templates
**/*.vue: Use TypeScript with Vue 3 Single File Components (.vuefiles)
Name Vue components in PascalCase (e.g.,MenuHamburger.vue)Files:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vue**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (.cursorrules)
**/*.{vue,ts,tsx}: Leverage VueUse functions for performance-enhancing utilities
Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.jsonFiles:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vue**/*.{ts,tsx,js,vue}
📄 CodeRabbit inference engine (.cursorrules)
Implement proper error handling in components and services
**/*.{ts,tsx,js,vue}: Use 2-space indentation, single quotes, no semicolons, and maintain 80-character line width as configured in.prettierrc
Organize imports by sorting and grouping by plugin, and runpnpm formatbefore committingFiles:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventionsFiles:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.jsonFiles:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vue**/*.{ts,tsx,js,jsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
Use camelCase for variable and setting names in TypeScript/Vue files
Files:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vue**/*.{vue,html}
📄 CodeRabbit inference engine (CLAUDE.md)
Never use
dark:ordark-theme:Tailwind variants - instead use semantic values fromstyle.csstheme, e.g.bg-node-component-surfaceFiles:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vue**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,vue}: Useconst settingStore = useSettingStore()andsettingStore.get('Comfy.SomeSetting')to retrieve settings in TypeScript/Vue files
Useawait settingStore.set('Comfy.SomeSetting', newValue)to update settings in TypeScript/Vue files
Check server capabilities usingapi.serverSupportsFeature('feature_name')before using enhanced features
Useapi.getServerFeature('config_name', defaultValue)to retrieve server feature configurationEnforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templates
Files:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebaseFiles:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/platform/assets/components/AssetGrid.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.jsonFiles:
src/platform/assets/components/AssetGrid.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vue🧠 Learnings (8)
📓 Common learnings
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: AGENTS.md:0-0 Timestamp: 2025-11-24T19:48:23.077Z Learning: Pull requests must pass `pnpm lint`, `pnpm typecheck`, and relevant tests before merging; keep PRs focused and smallLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:34.296Z Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.254Z Learning: Applies to **/*.{vue,ts,tsx} : Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.jsonLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.608Z Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI stringsLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-11-24T19:47:02.828Z Learning: Applies to src/**/*.{vue,ts} : Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.jsonLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: AGENTS.md:0-0 Timestamp: 2025-11-24T19:48:23.077Z Learning: Applies to **/*.{ts,tsx,vue} : Enforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templatesLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.607Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue Chips component with AutoComplete with multiple enabledLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.608Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue InlineMessage component with MessageLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.254Z Learning: Applies to **/*.vue : Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectivelyLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.607Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitchLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:34.296Z Learning: Applies to src/**/*.{ts,tsx,vue} : Implement proper TypeScript types throughout the codebase📚 Learning: 2025-11-24T19:46:52.254Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.254Z Learning: Applies to **/*.{vue,ts,tsx} : Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.jsonApplied to files:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vue📚 Learning: 2025-11-24T19:47:45.608Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.608Z Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI stringsApplied to files:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue📚 Learning: 2025-11-24T19:47:34.296Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:34.296Z Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`Applied to files:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/locales/en/main.json📚 Learning: 2025-11-24T19:47:02.828Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-11-24T19:47:02.828Z Learning: Applies to src/**/*.{vue,ts} : Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.jsonApplied to files:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue📚 Learning: 2025-11-24T19:47:45.607Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.607Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with SelectApplied to files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue📚 Learning: 2025-11-24T19:46:52.254Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.254Z Learning: Applies to **/*.vue : Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectivelyApplied to files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue📚 Learning: 2025-11-24T19:46:52.254Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.254Z Learning: Applies to **/*.vue : Never use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage)Applied to files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: setup
- GitHub Check: collect
- GitHub Check: test
- GitHub Check: lint-and-format
🔇 Additional comments (15)
src/platform/cloud/onboarding/components/CloudLogo.vue (1)
3-7: LGTM! Alt text properly internationalized.The alt text binding correctly references the translation key, and the past typo issue has been addressed.
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue (1)
70-78: LGTM! Empty state indicator properly internationalized.The title attribute correctly uses i18n binding for the "No items" tooltip, improving accessibility for non-English users.
src/platform/assets/components/AssetGrid.vue (1)
2-10: LGTM! ARIA label properly internationalized.The aria-label binding correctly uses i18n, ensuring screen reader users in different locales receive properly translated grid labels.
src/platform/cloud/onboarding/CloudSurveyView.vue (5)
44-52: LGTM! Button labels properly internationalized.The "Next" button label correctly uses the i18n binding
$t('g.next').
94-107: LGTM! Navigation buttons properly internationalized.The "Back" and "Next" button labels correctly use i18n bindings.
138-146: LGTM! Placeholder uses i18n binding.The
industryOtherplaceholder correctly uses the i18n key, though see earlier comment about potential key path improvement for theuseCaseOtherfield.
149-162: LGTM! Navigation buttons properly internationalized.The "Back" and "Next" button labels correctly use i18n bindings.
194-208: LGTM! Final step buttons properly internationalized.The "Back" and "Submit" button labels correctly use i18n bindings from the global namespace.
src/locales/en/main.json (7)
108-108: LGTM! Translation key added for submit button.The
submitkey properly supports the internationalization of submit buttons across the application.
238-249: LGTM! Multiple general-purpose translation keys added.The new keys (
playPause,beta,profile,noItems) provide appropriate translations for UI elements across the application.
696-696: LGTM! Preview label translation added.The
previewkey supports the queue progress overlay preview feature internationalization.
938-938: LGTM! Mask editor translation key added.The
stepSizekey properly supports the brush settings internationalization.
1844-1844: LGTM! Logo alt text translation added.The
comfyCloudLogokey supports accessible alt text for the Comfy Cloud logo.
2080-2080: LGTM! Asset browser translation key added.The
assetCollectionkey supports ARIA label internationalization for the asset grid.
2131-2133: LGTM! Asset browser filter translation keys added.The new keys (
selectFrameworks,selectProjects,sortingType) support internationalization of asset browser filtering options.
Summary
Catch more user visible (or audible) text that isn't internationalizable.
Changes
Review Focus
What other properties have leaked English text to non-English locales that aren't in here?