Skip to content

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Nov 22, 2025

makes setting groups/categories be sorted by highest internal setting field sortOrder and adds high sortOrder values to the Vue Nodes (Nodes 2.0) settings.

Selection_2371

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 22, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 22, 2025

📝 Walkthrough

Walkthrough

Updates locale strings and setting definitions from "Vue nodes" to "Nodes 2.0" terminology. Adds sortOrder metadata to two settings and implements a two-level sorting mechanism in the settings dialog that prioritizes groups by sortOrder before using labels as a tiebreaker.

Changes

Cohort / File(s) Summary
Terminology updates
src/locales/en/settings.json
Updated two locale string values: "Auto-scale layout (Vue nodes)" → "Auto-scale layout (Nodes 2.0)" and "Modern Node Design (Vue Nodes)" → "Modern Node Design (Nodes 2.0)".
Settings configuration
src/platform/settings/constants/coreSettings.ts
Added metadata to two settings entries: Comfy.VueNodes.Enabled (category, sortOrder: 100, renamed display) and Comfy.VueNodes.AutoScaleLayout (category, sortOrder: 50, renamed display). Updated header comment from "Vue Node System Settings" to "Nodes 2.0 Settings".
Settings dialog sorting
src/platform/settings/components/SettingDialogContent.vue
Introduced helper function getGroupSortOrder(group) and replaced single-level group sorting with two-level sort: primary by descending group sortOrder, secondary by label as tiebreaker.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vue-node/higher-prio-setting

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d6c5b33 and 20cac4c.

📒 Files selected for processing (3)
  • src/locales/en/settings.json (1 hunks)
  • src/platform/settings/components/SettingDialogContent.vue (1 hunks)
  • src/platform/settings/constants/coreSettings.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: setup
  • GitHub Check: test
  • GitHub Check: lint-and-format
  • GitHub Check: collect
🔇 Additional comments (5)
src/locales/en/settings.json (1)

337-344: LGTM! Consistent rebranding from "Vue nodes" to "Nodes 2.0".

The locale string updates are consistent with the corresponding changes in src/platform/settings/constants/coreSettings.ts and align with the PR's objective to improve the presentation of these settings.

src/platform/settings/components/SettingDialogContent.vue (2)

110-112: LGTM! Clean implementation of group sort order calculation.

The getGroupSortOrder function correctly computes the maximum sortOrder value from all settings within a group, with a sensible floor of 0 for groups without explicit sort orders. This enables the two-level sorting strategy that prioritizes groups with higher-priority settings.


117-120: LGTM! Two-level sorting correctly prioritizes groups by sortOrder.

The sorting logic now prioritizes groups by their maximum sortOrder (descending), with label alphabetically as a tiebreaker. This ensures that the "Nodes 2.0" group (with sortOrder: 100 and 50) appears at the top of the settings dialog, fulfilling the PR's objective.

src/platform/settings/constants/coreSettings.ts (2)

1088-1098: LGTM! Metadata additions enable proper prioritization in settings dialog.

The additions of category and sortOrder: 100 to the "Modern Node Design" setting correctly implement the group hierarchy and high-priority positioning. The rebranding to "Nodes 2.0" is consistent across locale strings.


1100-1110: LGTM! Consistent metadata additions with appropriate secondary priority.

The category and sortOrder: 50 additions follow the same pattern as the first setting, creating a cohesive "Nodes 2.0" group. The lower sort order (50 vs 100) establishes a sensible hierarchy within the group, while the maximum value determines the overall group position.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Nov 22, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 11/22/2025, 02:33:13 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Nov 22, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 11/22/2025, 02:44:25 AM UTC

📈 Summary

  • Total Tests: 495
  • Passed: 482 ✅
  • Failed: 0
  • Flaky: 4 ⚠️
  • Skipped: 9 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 473 / ❌ 0 / ⚠️ 4 / ⏭️ 9
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

Bundle Size Report

Summary

  • Raw size: 13.7 MB baseline 13.7 MB — 🔴 +425 B
  • Gzip: 2.76 MB baseline 2.76 MB — 🔴 +17 B
  • Brotli: 2.16 MB baseline 2.16 MB — 🟢 -125 B
  • Bundles: 92 current • 92 baseline • 38 added / 38 removed

Category Glance
App Entry Points 🔴 +278 B (3.13 MB) · Graph Workspace 🔴 +147 B (940 kB) · Vendor & Third-Party ⚪ 0 B (5.32 MB) · Other ⚪ 0 B (3.87 MB) · Panels & Settings ⚪ 0 B (306 kB) · UI Components ⚪ 0 B (141 kB) · + 3 more

Per-category breakdown
App Entry Points — 3.13 MB (baseline 3.13 MB) • 🔴 +278 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-C_b1rMkk.js (new) 2.77 MB 🔴 +2.77 MB 🔴 +579 kB 🔴 +440 kB
assets/index-D9YJ1Zq8.js (removed) 2.77 MB 🟢 -2.77 MB 🟢 -579 kB 🟢 -440 kB
assets/index-Caxxb1FZ.js (new) 364 kB 🔴 +364 kB 🔴 +75.2 kB 🔴 +61.4 kB
assets/index-OtdnA4Bp.js (removed) 364 kB 🟢 -364 kB 🟢 -75.2 kB 🟢 -61.4 kB
assets/index-C2bkJHSV.js (new) 345 B 🔴 +345 B 🔴 +244 B 🔴 +229 B
assets/index-CwftIcvK.js (removed) 345 B 🟢 -345 B 🟢 -246 B 🟢 -237 B

Status: 3 added / 3 removed

Graph Workspace — 940 kB (baseline 940 kB) • 🔴 +147 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-Fb2oh0Rq.js (new) 940 kB 🔴 +940 kB 🔴 +182 kB 🔴 +140 kB
assets/GraphView-B0ZMk4wO.js (removed) 940 kB 🟢 -940 kB 🟢 -182 kB 🟢 -140 kB

Status: 1 added / 1 removed

Views & Navigation — 7.97 kB (baseline 7.97 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/UserSelectView-COi2qJWF.js (removed) 7.97 kB 🟢 -7.97 kB 🟢 -2.44 kB 🟢 -2.13 kB
assets/UserSelectView-D-HD2iMx.js (new) 7.97 kB 🔴 +7.97 kB 🔴 +2.43 kB 🔴 +2.14 kB

Status: 1 added / 1 removed

Panels & Settings — 306 kB (baseline 306 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CreditsPanel-Cnj7TiWx.js (removed) 22.9 kB 🟢 -22.9 kB 🟢 -5.46 kB 🟢 -4.79 kB
assets/CreditsPanel-tCc4dAhe.js (new) 22.9 kB 🔴 +22.9 kB 🔴 +5.46 kB 🔴 +4.78 kB
assets/KeybindingPanel-Be-i-Dvc.js (new) 15.1 kB 🔴 +15.1 kB 🔴 +3.73 kB 🔴 +3.28 kB
assets/KeybindingPanel-Cc4N73fb.js (removed) 15.1 kB 🟢 -15.1 kB 🟢 -3.73 kB 🟢 -3.29 kB
assets/ExtensionPanel-BytHCAg_.js (removed) 11.9 kB 🟢 -11.9 kB 🟢 -2.8 kB 🟢 -2.45 kB
assets/ExtensionPanel-CdIyj2Wl.js (new) 11.9 kB 🔴 +11.9 kB 🔴 +2.79 kB 🔴 +2.45 kB
assets/AboutPanel-Bg2GD9qX.js (removed) 10.1 kB 🟢 -10.1 kB 🟢 -2.62 kB 🟢 -2.31 kB
assets/AboutPanel-DJ5yk5-U.js (new) 10.1 kB 🔴 +10.1 kB 🔴 +2.62 kB 🔴 +2.31 kB
assets/ServerConfigPanel-B10c4Nkr.js (new) 8.02 kB 🔴 +8.02 kB 🔴 +2.12 kB 🔴 +1.87 kB
assets/ServerConfigPanel-BZccVvu_.js (removed) 8.02 kB 🟢 -8.02 kB 🟢 -2.12 kB 🟢 -1.87 kB
assets/UserPanel-b_SU5Fro.js (removed) 7.74 kB 🟢 -7.74 kB 🟢 -2.03 kB 🟢 -1.77 kB
assets/UserPanel-Ca3TDrow.js (new) 7.74 kB 🔴 +7.74 kB 🔴 +2.03 kB 🔴 +1.77 kB
assets/settings-BXTtSH4O.js 33.3 kB 33.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-C9Pzn-NG.js 25.2 kB 25.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CCy2fA_h.js 27.3 kB 27.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CQpqEFfl.js 26.6 kB 26.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DHcnxypw.js 21.7 kB 21.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DhFTK9fY.js 25.1 kB 25.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DlT4t_ui.js 25.9 kB 25.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DRgSrIdD.js 24.2 kB 24.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-tjkeqiZq.js 21.1 kB 21.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 6 added / 6 removed

UI Components — 141 kB (baseline 141 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/Load3D.vue_vue_type_script_setup_true_lang-B2np-g3o.js (removed) 53.9 kB 🟢 -53.9 kB 🟢 -8.43 kB 🟢 -7.24 kB
assets/Load3D.vue_vue_type_script_setup_true_lang-D8UNKbl9.js (new) 53.9 kB 🔴 +53.9 kB 🔴 +8.43 kB 🔴 +7.24 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-Dboe7-LB.js (new) 48.1 kB 🔴 +48.1 kB 🔴 +10.3 kB 🔴 +8.91 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-DBTM9X0w.js (removed) 48.1 kB 🟢 -48.1 kB 🟢 -10.3 kB 🟢 -8.97 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-C8epnBdQ.js (removed) 12.7 kB 🟢 -12.7 kB 🟢 -3.31 kB 🟢 -2.92 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-DP23FHIF.js (new) 12.7 kB 🔴 +12.7 kB 🔴 +3.31 kB 🔴 +2.93 kB
assets/ComfyQueueButton-CVk4rFrT.js (new) 9.22 kB 🔴 +9.22 kB 🔴 +2.5 kB 🔴 +2.2 kB
assets/ComfyQueueButton-v1oMMYNn.js (removed) 9.22 kB 🟢 -9.22 kB 🟢 -2.5 kB 🟢 -2.2 kB
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-BRPcB1fd.js (removed) 2.14 kB 🟢 -2.14 kB 🟢 -796 B 🟢 -690 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-CMSZxL97.js (new) 2.14 kB 🔴 +2.14 kB 🔴 +795 B 🔴 +695 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-7pt8yAnT.js (removed) 848 B 🟢 -848 B 🟢 -477 B 🟢 -418 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-D2TemcOy.js (new) 848 B 🔴 +848 B 🔴 +473 B 🔴 +413 B
assets/LazyImage.vue_vue_type_script_setup_true_lang-Wi-CcgaU.js 10.7 kB 10.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-D2s8tnS2.js 1.26 kB 1.26 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetButton-ByrPd5jr.js 1.62 kB 1.62 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 6 added / 6 removed

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/keybindingService-BOyED5Zo.js (removed) 7.51 kB 🟢 -7.51 kB 🟢 -1.84 kB 🟢 -1.58 kB
assets/keybindingService-HEwR0K-h.js (new) 7.51 kB 🔴 +7.51 kB 🔴 +1.83 kB 🔴 +1.58 kB
assets/audioService-BQBX08zj.js (removed) 2.2 kB 🟢 -2.2 kB 🟢 -964 B 🟢 -823 B
assets/audioService-C_iXWvuV.js (new) 2.2 kB 🔴 +2.2 kB 🔴 +959 B 🔴 +818 B
assets/serverConfigStore-BoHtzifw.js 2.79 kB 2.79 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 2 added / 2 removed

Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/audioUtils-DabD5H9c.js (removed) 1.41 kB 🟢 -1.41 kB 🟢 -653 B 🟢 -542 B
assets/audioUtils-Dqcp2GeV.js (new) 1.41 kB 🔴 +1.41 kB 🔴 +651 B 🔴 +547 B
assets/mathUtil-CTARWQ-l.js 1.07 kB 1.07 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeFilterUtil-CXKCRJ-m.js 460 B 460 B ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 1 added / 1 removed

Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/vendor-other-z0ajCJVX.js 3.22 MB 3.22 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-primevue-PESgPnbc.js 517 B 517 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-three-aR6ntw5X.js 1.37 MB 1.37 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-tiptap-D2zb6Fg1.js 232 kB 232 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-vue-aBQ_uOio.js 92.6 kB 92.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-xterm-BZLod3g9.js 407 kB 407 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
Other — 3.87 MB (baseline 3.87 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/WidgetRecordAudio-DjevkgV0.js (new) 21.9 kB 🔴 +21.9 kB 🔴 +5.52 kB 🔴 +4.87 kB
assets/WidgetRecordAudio-DT5qPhvO.js (removed) 21.9 kB 🟢 -21.9 kB 🟢 -5.52 kB 🟢 -4.88 kB
assets/AudioPreviewPlayer-88qMT1ey.js (new) 14.9 kB 🔴 +14.9 kB 🔴 +3.69 kB 🔴 +3.3 kB
assets/AudioPreviewPlayer-CwlskeKB.js (removed) 14.9 kB 🟢 -14.9 kB 🟢 -3.69 kB 🟢 -3.3 kB
assets/WidgetGalleria-CAOD9aCe.js (new) 5.56 kB 🔴 +5.56 kB 🔴 +1.74 kB 🔴 +1.54 kB
assets/WidgetGalleria-DnRr1Cjg.js (removed) 5.56 kB 🟢 -5.56 kB 🟢 -1.75 kB 🟢 -1.54 kB
assets/WidgetColorPicker-D4O_hhfJ.js (removed) 4.87 kB 🟢 -4.87 kB 🟢 -1.69 kB 🟢 -1.48 kB
assets/WidgetColorPicker-DwRHgPo6.js (new) 4.87 kB 🔴 +4.87 kB 🔴 +1.69 kB 🔴 +1.48 kB
assets/WidgetMarkdown-4oyd0KjJ.js (removed) 4.64 kB 🟢 -4.64 kB 🟢 -1.62 kB 🟢 -1.41 kB
assets/WidgetMarkdown-BSoCCDNv.js (new) 4.64 kB 🔴 +4.64 kB 🔴 +1.62 kB 🔴 +1.42 kB
assets/WidgetAudioUI-BgKd8Lwe.js (new) 4.33 kB 🔴 +4.33 kB 🔴 +1.44 kB 🔴 +1.28 kB
assets/WidgetAudioUI-DuYNJjCu.js (removed) 4.33 kB 🟢 -4.33 kB 🟢 -1.44 kB 🟢 -1.29 kB
assets/WidgetTextarea-BiYfpUxd.js (new) 3.72 kB 🔴 +3.72 kB 🔴 +1.3 kB 🔴 +1.15 kB
assets/WidgetTextarea-Dn77qaN1.js (removed) 3.72 kB 🟢 -3.72 kB 🟢 -1.31 kB 🟢 -1.14 kB
assets/WidgetInputText-DPkJTRHo.js (new) 3.45 kB 🔴 +3.45 kB 🔴 +1.24 kB 🔴 +1.08 kB
assets/WidgetInputText-DyieLOU3.js (removed) 3.45 kB 🟢 -3.45 kB 🟢 -1.24 kB 🟢 -1.09 kB
assets/WidgetToggleSwitch-6jFlxhBt.js (new) 3.23 kB 🔴 +3.23 kB 🔴 +1.14 kB 🔴 +1 kB
assets/WidgetToggleSwitch-Dv_cCss2.js (removed) 3.23 kB 🟢 -3.23 kB 🟢 -1.14 kB 🟢 -1.01 kB
assets/MediaImageBottom-BiczVdZY.js (removed) 3.05 kB 🟢 -3.05 kB 🟢 -1.05 kB 🟢 -913 B
assets/MediaImageBottom-OYNUT-Wd.js (new) 3.05 kB 🔴 +3.05 kB 🔴 +1.05 kB 🔴 +912 B
assets/MediaAudioBottom-BCjG7KzM.js (new) 3 kB 🔴 +3 kB 🔴 +1.05 kB 🔴 +922 B
assets/MediaAudioBottom-Bu8sMppc.js (removed) 3 kB 🟢 -3 kB 🟢 -1.05 kB 🟢 -922 B
assets/Media3DTop-C7Q1CZV5.js (new) 3 kB 🔴 +3 kB 🔴 +1.08 kB 🔴 +928 B
assets/Media3DTop-Ds65RV0o.js (removed) 3 kB 🟢 -3 kB 🟢 -1.08 kB 🟢 -911 B
assets/MediaVideoBottom-BlWu9wxX.js (removed) 3 kB 🟢 -3 kB 🟢 -1.05 kB 🟢 -920 B
assets/MediaVideoBottom-CyNXvmSk.js (new) 3 kB 🔴 +3 kB 🔴 +1.04 kB 🔴 +919 B
assets/Media3DBottom-BW8UcYET.js (new) 2.98 kB 🔴 +2.98 kB 🔴 +1.04 kB 🔴 +907 B
assets/Media3DBottom-D2KSEAE6.js (removed) 2.98 kB 🟢 -2.98 kB 🟢 -1.04 kB 🟢 -911 B
assets/WidgetSelect-B8vZb948.js (removed) 2.17 kB 🟢 -2.17 kB 🟢 -675 B 🟢 -576 B
assets/WidgetSelect-DYQlBqyr.js (new) 2.17 kB 🔴 +2.17 kB 🔴 +674 B 🔴 +566 B
assets/WidgetInputNumber-CgkLLWO0.js (new) 2.12 kB 🔴 +2.12 kB 🔴 +664 B 🔴 +558 B
assets/WidgetInputNumber-E1KxzqsI.js (removed) 2.12 kB 🟢 -2.12 kB 🟢 -664 B 🟢 -556 B
assets/Load3D-COSn7Gg2.js (removed) 1.94 kB 🟢 -1.94 kB 🟢 -598 B 🟢 -500 B
assets/Load3D-DsfRPocz.js (new) 1.94 kB 🔴 +1.94 kB 🔴 +596 B 🔴 +500 B
assets/WidgetLegacy-BACgqQ6C.js (removed) 1.88 kB 🟢 -1.88 kB 🟢 -562 B 🟢 -505 B
assets/WidgetLegacy-D3J4PxgZ.js (new) 1.88 kB 🔴 +1.88 kB 🔴 +562 B 🔴 +507 B
assets/commands-_s-RvhJR.js 13.6 kB 13.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BuUILW6P.js 13 kB 13 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BV4R6fLx.js 14.9 kB 14.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CLwPdnT6.js 14.2 kB 14.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CWMchBmd.js 15.9 kB 15.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DazTQhtc.js 12.9 kB 12.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DmWrOe93.js 13.7 kB 13.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DwiH7Kr6.js 13.8 kB 13.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-mS3LCNPn.js 14.5 kB 14.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-5lOBdqcC.js 84.5 kB 84.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-BOCuaVpE.js 73.4 kB 73.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-ClrEFGUz.js 72.4 kB 72.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CyNU0iQX.js 99.3 kB 99.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-D7gwLxft.js 114 kB 114 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DC8o4BCt.js 86.8 kB 86.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DKiesCV4.js 94.3 kB 94.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Hq2q-OtB.js 83.6 kB 83.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-USAlAlnj.js 82 kB 82 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaAudioTop-RTI8pWy9.js 1.42 kB 1.42 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaImageTop-Cxl4dc80.js 1.68 kB 1.68 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaVideoTop-BB0lT7C5.js 2.7 kB 2.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-_Px5dSNW.js 306 kB 306 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-7z21KPoS.js 285 kB 285 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BWKZzBPK.js 346 kB 346 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CGbgH4Yl.js 320 kB 320 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CjjjdWkV.js 313 kB 313 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CVrNtxvj.js 288 kB 288 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-DLRSA0IK.js 309 kB 309 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-DQV2gnwA.js 372 kB 372 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-ofqLG5vz.js 310 kB 310 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetChart-rDmYEWg5.js 2.39 kB 2.39 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetImageCompare-Ds3K3ULR.js 2.15 kB 2.15 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js 1.28 kB 1.28 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 18 added / 18 removed

Copy link
Collaborator

@AustinMroz AustinMroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-byrne christian-byrne added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch 1.32 labels Nov 22, 2025
@christian-byrne christian-byrne merged commit 1dbb3fc into main Nov 22, 2025
51 of 52 checks passed
@christian-byrne christian-byrne deleted the vue-node/higher-prio-setting branch November 22, 2025 04:32
github-actions bot pushed a commit that referenced this pull request Nov 22, 2025
makes setting groups/categories be sorted by highest internal setting
field `sortOrder` and adds high `sortOrder` values to the Vue Nodes
(Nodes 2.0) settings.


<img width="2282" height="1872" alt="Selection_2371"
src="https://github.com/user-attachments/assets/71e7e76b-4637-42b5-9f0c-2617622cda23"
/>
@comfy-pr-bot
Copy link
Member

@christian-byrne Successfully backported to #6821

@github-actions github-actions bot removed the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Nov 22, 2025
christian-byrne added a commit that referenced this pull request Nov 22, 2025
…ings dialog (#6821)

Backport of #6820 to `core/1.32`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6821-backport-core-1-32-make-vue-node-settings-appear-higher-in-the-settings-dialog-2b36d73d365081f98ab0f9540ffc362c)
by [Unito](https://www.unito.io)

Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.32 area:settings area:vue-migration size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants