Skip to content

Conversation

@DrJKL
Copy link
Contributor

@DrJKL DrJKL commented Dec 3, 2025

Summary

Textarea/Markdown/3D pieces grow, other widget rows size to their contents.

Screenshots (if applicable)

image

┆Issue is synchronized with this Notion page by Unito

@DrJKL DrJKL requested review from a team and jtydhr88 as code owners December 3, 2025 02:32
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 3, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 3, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • browser_tests/tests/vueNodes/widgets/load/uploadWidgets.spec.ts-snapshots/vue-nodes-upload-widgets-chromium-linux.png is excluded by !**/*.png

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

CSS class consolidation and layout refactoring across Vue components. The widget-expands class is removed from multiple components and replaced with size-full. NodeWidgets.vue now computes grid-template-rows dynamically based on widget types, introducing an EXPANDING_TYPES constant for expansion behavior classification. DOM wrappers are simplified in WidgetTextarea.vue.

Changes

Cohort / File(s) Summary
Load3D container sizing
src/components/load3d/Load3D.vue
Replaced outer container class from "widget-expands relative h-full w-full" to "relative size-full" and inner overlay class from "pointer-events-none absolute top-0 left-0 h-full w-full" to "pointer-events-none absolute top-0 left-0 size-full"
NodeWidgets layout and expansion logic
src/renderer/extensions/vueNodes/components/NodeWidgets.vue
Removed has-[.widget-expands]:flex-1 from root container and replaced with plain flex-1; added toValue import from Vue; introduced EXPANDING_TYPES constant listing expandable widget types; added gridTemplateRows computed property that dynamically sets row heights (auto for expanding types, min-content otherwise) based on visible widgets; removed data-is-hidden attribute and has-[.widget-expands]:flex-1 from widget containers
Widget-specific class removal
src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue, src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue
WidgetMarkdown: Removed widget-expands class; WidgetTextarea: Removed wrapper div and moved layout classes from inner element to Textarea component, changing class string to "relative size-full text-xs resize-none"

Possibly related PRs

  • #6891: Modifies NodeWidgets.vue layout and sizing behavior with grid layout implementation alongside this PR's expansion class adjustments.
  • #7102: Modifies NodeWidgets.vue's per-widget and root container classes with shared focus on removing widget-expands and layout restructuring.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch drjkl/I-love-grid-but-sometimes

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 12/03/2025, 02:53:44 AM UTC

📈 Summary

  • Total Tests: 493
  • Passed: 478 ✅
  • Failed: 1 ❌
  • Flaky: 5 ⚠️
  • Skipped: 9 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 469 / ❌ 1 / ⚠️ 5 / ⏭️ 9
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 12/03/2025, 02:44:34 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@DrJKL DrJKL added the New Browser Test Expectations New browser test screenshot should be set by github action label Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Bundle Size Report

Summary

  • Raw size: 17 MB baseline 17 MB — 🔴 +173 B
  • Gzip: 3.37 MB baseline 3.37 MB — 🔴 +114 B
  • Brotli: 2.59 MB baseline 2.59 MB — 🔴 +212 B
  • Bundles: 97 current • 97 baseline • 37 added / 37 removed

Category Glance
App Entry Points 🔴 +379 B (3.21 MB) · Other 🟢 -183 B (3.81 MB) · UI Components 🟢 -23 B (169 kB) · Vendor & Third-Party ⚪ 0 B (8.56 MB) · Graph Workspace ⚪ 0 B (929 kB) · Panels & Settings ⚪ 0 B (298 kB) · + 3 more

Per-category breakdown
App Entry Points — 3.21 MB (baseline 3.21 MB) • 🔴 +379 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-DaVW6FK0.js (new) 2.98 MB 🔴 +2.98 MB 🔴 +621 kB 🔴 +472 kB
assets/index-CUcoqUor.js (removed) 2.98 MB 🟢 -2.98 MB 🟢 -621 kB 🟢 -472 kB
assets/index-0t28g4di.js (new) 223 kB 🔴 +223 kB 🔴 +47.5 kB 🔴 +39.2 kB
assets/index-CctA62Vk.js (removed) 223 kB 🟢 -223 kB 🟢 -47.5 kB 🟢 -39.2 kB
assets/index-CcVhndmU.js (new) 345 B 🔴 +345 B 🔴 +245 B 🔴 +231 B
assets/index-Q8wnGUMM.js (removed) 345 B 🟢 -345 B 🟢 -243 B 🟢 -225 B

Status: 3 added / 3 removed

Graph Workspace — 929 kB (baseline 929 kB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-BAHehuze.js (new) 929 kB 🔴 +929 kB 🔴 +180 kB 🔴 +138 kB
assets/GraphView-D5hXkdZq.js (removed) 929 kB 🟢 -929 kB 🟢 -180 kB 🟢 -138 kB

Status: 1 added / 1 removed

Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/UserSelectView-CEZkF9ic.js (removed) 6.54 kB 🟢 -6.54 kB 🟢 -2.14 kB 🟢 -1.89 kB
assets/UserSelectView-Cp_oaeRz.js (new) 6.54 kB 🔴 +6.54 kB 🔴 +2.14 kB 🔴 +1.9 kB

Status: 1 added / 1 removed

Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CreditsPanel-BxZyyTFz.js (removed) 21.4 kB 🟢 -21.4 kB 🟢 -5.15 kB 🟢 -4.5 kB
assets/CreditsPanel-DJHrnv1n.js (new) 21.4 kB 🔴 +21.4 kB 🔴 +5.15 kB 🔴 +4.5 kB
assets/KeybindingPanel-BxgK9QbV.js (new) 13.6 kB 🔴 +13.6 kB 🔴 +3.42 kB 🔴 +3.02 kB
assets/KeybindingPanel-D85IlzCU.js (removed) 13.6 kB 🟢 -13.6 kB 🟢 -3.42 kB 🟢 -3.04 kB
assets/ExtensionPanel-B8g9iqwS.js (new) 10.8 kB 🔴 +10.8 kB 🔴 +2.58 kB 🔴 +2.26 kB
assets/ExtensionPanel-naEtEeSl.js (removed) 10.8 kB 🟢 -10.8 kB 🟢 -2.57 kB 🟢 -2.26 kB
assets/AboutPanel-CWsf_gij.js (new) 9.16 kB 🔴 +9.16 kB 🔴 +2.46 kB 🔴 +2.21 kB
assets/AboutPanel-NaQegkra.js (removed) 9.16 kB 🟢 -9.16 kB 🟢 -2.46 kB 🟢 -2.21 kB
assets/ServerConfigPanel-BkbipG0_.js (removed) 6.56 kB 🟢 -6.56 kB 🟢 -1.83 kB 🟢 -1.63 kB
assets/ServerConfigPanel-NyS4NydI.js (new) 6.56 kB 🔴 +6.56 kB 🔴 +1.83 kB 🔴 +1.63 kB
assets/UserPanel-CakDseW4.js (new) 6.23 kB 🔴 +6.23 kB 🔴 +1.72 kB 🔴 +1.51 kB
assets/UserPanel-CRaBHvID.js (removed) 6.23 kB 🟢 -6.23 kB 🟢 -1.72 kB 🟢 -1.51 kB
assets/settings-BhbWhsRg.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-BXTtSH4O.js 33.3 kB 33.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-C9Pzn-NG.js 25.2 kB 25.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CCy2fA_h.js 27.3 kB 27.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CQpqEFfl.js 26.6 kB 26.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DHcnxypw.js 21.7 kB 21.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DhFTK9fY.js 25.1 kB 25.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DlT4t_ui.js 25.9 kB 25.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DRgSrIdD.js 24.2 kB 24.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-tjkeqiZq.js 21.1 kB 21.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 6 added / 6 removed

UI Components — 169 kB (baseline 169 kB) • 🟢 -23 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/Load3D.vue_vue_type_script_setup_true_lang-CBy2_LF0.js (removed) 53.9 kB 🟢 -53.9 kB 🟢 -8.52 kB 🟢 -7.32 kB
assets/Load3D.vue_vue_type_script_setup_true_lang-XoGR62QE.js (new) 53.9 kB 🔴 +53.9 kB 🔴 +8.52 kB 🔴 +7.31 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-B6_dtkOy.js (removed) 47.6 kB 🟢 -47.6 kB 🟢 -10.3 kB 🟢 -8.9 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-C1DBg5iX.js (new) 47.6 kB 🔴 +47.6 kB 🔴 +10.3 kB 🔴 +8.89 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-BLiV_BzM.js (new) 39.4 kB 🔴 +39.4 kB 🔴 +9.08 kB 🔴 +7.96 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-DLCyfcpF.js (removed) 39.4 kB 🟢 -39.4 kB 🟢 -9.08 kB 🟢 -7.96 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-CqlJWGRS.js (removed) 12.9 kB 🟢 -12.9 kB 🟢 -3.37 kB 🟢 -2.96 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-NLiRj32C.js (new) 12.9 kB 🔴 +12.9 kB 🔴 +3.37 kB 🔴 +2.97 kB
assets/ComfyQueueButton-6XR93kPs.js (removed) 8.44 kB 🟢 -8.44 kB 🟢 -2.48 kB 🟢 -2.21 kB
assets/ComfyQueueButton-IiVjqQ-T.js (new) 8.44 kB 🔴 +8.44 kB 🔴 +2.48 kB 🔴 +2.21 kB
assets/MediaTitle.vue_vue_type_script_setup_true_lang-BZ7GP1-K.js (new) 897 B 🔴 +897 B 🔴 +505 B 🔴 +437 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-CQjMX4tI.js (removed) 897 B 🟢 -897 B 🟢 -501 B 🟢 -428 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-B4R5m1qI.js 1.34 kB 1.34 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetButton-C9RSl9Jc.js 2.04 kB 2.04 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-C-GzTNBl.js 2 kB 2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 6 added / 6 removed

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/keybindingService-ysehq7PK.js (removed) 7.51 kB 🟢 -7.51 kB 🟢 -1.83 kB 🟢 -1.58 kB
assets/keybindingService-ywJaujq7.js (new) 7.51 kB 🔴 +7.51 kB 🔴 +1.84 kB 🔴 +1.58 kB
assets/audioService-BIcAzwVA.js (new) 2.2 kB 🔴 +2.2 kB 🔴 +960 B 🔴 +826 B
assets/audioService-CO_WMZ6p.js (removed) 2.2 kB 🟢 -2.2 kB 🟢 -957 B 🟢 -818 B
assets/serverConfigStore-W1zhjkBH.js 2.83 kB 2.83 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 2 added / 2 removed

Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/audioUtils-Ca2XWIeu.js (removed) 1.41 kB 🟢 -1.41 kB 🟢 -650 B 🟢 -550 B
assets/audioUtils-CUQjR4BR.js (new) 1.41 kB 🔴 +1.41 kB 🔴 +653 B 🔴 +546 B
assets/mathUtil-CTARWQ-l.js 1.07 kB 1.07 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeFilterUtil-CXKCRJ-m.js 460 B 460 B ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 1 added / 1 removed

Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/vendor-chart-BCOr5Gfm.js 452 kB 452 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-other-DsoOPVgr.js 3.98 MB 3.98 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-primevue-CjsaCDb8.js 1.96 MB 1.96 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-three-aR6ntw5X.js 1.37 MB 1.37 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-tiptap-CzjUILzD.js 232 kB 232 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-vue-BEWVLQIi.js 160 kB 160 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-xterm-BZLod3g9.js 407 kB 407 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
Other — 3.81 MB (baseline 3.81 MB) • 🟢 -183 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/WidgetRecordAudio-C96JTBbC.js (removed) 20.4 kB 🟢 -20.4 kB 🟢 -5.24 kB 🟢 -4.63 kB
assets/WidgetRecordAudio-DGCiYzSx.js (new) 20.4 kB 🔴 +20.4 kB 🔴 +5.24 kB 🔴 +4.63 kB
assets/AudioPreviewPlayer-5DoV1WA-.js (removed) 13.5 kB 🟢 -13.5 kB 🟢 -3.4 kB 🟢 -3.04 kB
assets/AudioPreviewPlayer-8sdnr3s3.js (new) 13.5 kB 🔴 +13.5 kB 🔴 +3.4 kB 🔴 +3.04 kB
assets/WidgetGalleria-BHCzsGPT.js (new) 4.1 kB 🔴 +4.1 kB 🔴 +1.45 kB 🔴 +1.3 kB
assets/WidgetGalleria-Dqeius3O.js (removed) 4.1 kB 🟢 -4.1 kB 🟢 -1.44 kB 🟢 -1.3 kB
assets/WidgetColorPicker-DkARak9J.js (removed) 3.41 kB 🟢 -3.41 kB 🟢 -1.38 kB 🟢 -1.23 kB
assets/WidgetColorPicker-FMKWOjDj.js (new) 3.41 kB 🔴 +3.41 kB 🔴 +1.38 kB 🔴 +1.23 kB
assets/WidgetMarkdown-CnLU09AU.js (removed) 3.1 kB 🟢 -3.1 kB 🟢 -1.29 kB 🟢 -1.13 kB
assets/WidgetMarkdown-BTl_MNXp.js (new) 3.08 kB 🔴 +3.08 kB 🔴 +1.28 kB 🔴 +1.13 kB
assets/WidgetAudioUI-C5l7-aNA.js (new) 2.82 kB 🔴 +2.82 kB 🔴 +1.12 kB 🔴 +1.02 kB
assets/WidgetAudioUI-Wju7Fi__.js (removed) 2.82 kB 🟢 -2.82 kB 🟢 -1.12 kB 🟢 -1.02 kB
assets/WidgetTextarea-DG7tYHdw.js (removed) 2.48 kB 🟢 -2.48 kB 🟢 -1.01 kB 🟢 -901 B
assets/WidgetTextarea-D70i_uYT.js (new) 2.31 kB 🔴 +2.31 kB 🔴 +958 B 🔴 +840 B
assets/WidgetInputText-B-XOyuTt.js (removed) 1.99 kB 🟢 -1.99 kB 🟢 -916 B 🟢 -852 B
assets/WidgetInputText-FFqUiySE.js (new) 1.99 kB 🔴 +1.99 kB 🔴 +917 B 🔴 +849 B
assets/MediaImageBottom-BHMsN2dR.js (new) 1.57 kB 🔴 +1.57 kB 🔴 +746 B 🔴 +645 B
assets/MediaImageBottom-nPmQbQ52.js (removed) 1.57 kB 🟢 -1.57 kB 🟢 -743 B 🟢 -644 B
assets/MediaAudioBottom-BKNfs6jE.js (removed) 1.52 kB 🟢 -1.52 kB 🟢 -742 B 🟢 -656 B
assets/MediaAudioBottom-DQLnQaIS.js (new) 1.52 kB 🔴 +1.52 kB 🔴 +745 B 🔴 +655 B
assets/MediaVideoBottom-B3GXjaEZ.js (removed) 1.52 kB 🟢 -1.52 kB 🟢 -740 B 🟢 -652 B
assets/MediaVideoBottom-CU4p8fcK.js (new) 1.52 kB 🔴 +1.52 kB 🔴 +741 B 🔴 +656 B
assets/Media3DBottom-D5AZH6ky.js (new) 1.5 kB 🔴 +1.5 kB 🔴 +736 B 🔴 +649 B
assets/Media3DBottom-DNy7WWM5.js (removed) 1.5 kB 🟢 -1.5 kB 🟢 -733 B 🟢 -646 B
assets/Media3DTop-CxQTZlsq.js (new) 1.49 kB 🔴 +1.49 kB 🔴 +763 B 🔴 +653 B
assets/Media3DTop-Dd5h-4cw.js (removed) 1.49 kB 🟢 -1.49 kB 🟢 -763 B 🟢 -654 B
assets/WidgetSelect-C-kxaLal.js (removed) 655 B 🟢 -655 B 🟢 -340 B 🟢 -288 B
assets/WidgetSelect-DWWLA9Jz.js (new) 655 B 🔴 +655 B 🔴 +346 B 🔴 +310 B
assets/WidgetInputNumber-B1kAuoue.js (removed) 595 B 🟢 -595 B 🟢 -331 B 🟢 -275 B
assets/WidgetInputNumber-DVBPT5Wz.js (new) 595 B 🔴 +595 B 🔴 +330 B 🔴 +276 B
assets/Load3D-Db5FXDYY.js (new) 424 B 🔴 +424 B 🔴 +269 B 🔴 +224 B
assets/Load3D-DK7mwHiU.js (removed) 424 B 🟢 -424 B 🟢 -266 B 🟢 -222 B
assets/WidgetLegacy-DgWu6S-6.js (removed) 364 B 🟢 -364 B 🟢 -235 B 🟢 -193 B
assets/WidgetLegacy-xKxru1v9.js (new) 364 B 🔴 +364 B 🔴 +236 B 🔴 +196 B
assets/commands-_s-RvhJR.js 13.6 kB 13.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BuUILW6P.js 13 kB 13 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BV4R6fLx.js 14.9 kB 14.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BWp4HdfU.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CLwPdnT6.js 14.2 kB 14.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CWMchBmd.js 15.9 kB 15.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DazTQhtc.js 12.9 kB 12.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DmWrOe93.js 13.7 kB 13.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DwiH7Kr6.js 13.8 kB 13.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-mS3LCNPn.js 14.5 kB 14.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-B1JflQcI.js 72.2 kB 72.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-B2lyXe48.js 114 kB 114 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-B9XEQ-pc.js 94 kB 94 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-BErKFzc-.js 73.1 kB 73.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Bf7Tze-u.js 83.4 kB 83.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-BhGMcO4Q.js 84.3 kB 84.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CPZUloNQ.js 99 kB 99 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Cw9RZWRY.js 89 B 89 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Dva0z-T2.js 86.5 kB 86.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-un0K9wDS.js 81.8 kB 81.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaAudioTop-B_r9Y3e-.js 1.46 kB 1.46 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaImageTop-Df0PRhSp.js 1.75 kB 1.75 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaVideoTop-_g8aBAAL.js 2.76 kB 2.76 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-8e6QYQW0.js 283 kB 283 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-A_9dx4yn.js 304 kB 304 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BbD3HDi7.js 307 kB 307 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BOJhIPft.js 369 kB 369 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Bw_Jitw_.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-C-Pw33mW.js 317 kB 317 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-ChLyG0UJ.js 285 kB 285 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CUVPxA4l.js 342 kB 342 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Dx5Y4xrW.js 310 kB 310 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-JqO5mNmW.js 306 kB 306 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetChart-f0b59iz3.js 2.48 kB 2.48 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetImageCompare-65U3rWW6.js 2.21 kB 2.21 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js 1.28 kB 1.28 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetToggleSwitch-C53mIaDW.js 1.58 kB 1.58 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 17 added / 17 removed

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Updating Playwright Expectations

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue (1)

60-61: Refactor away from @ts-expect-error when focusing the textarea

The @ts-expect-error on $el conflicts with the guideline to avoid @ts-expect-error in src/**/*.{ts,tsx,vue}. Consider introducing a small typed interface for the ref (e.g., a FocusableTextareaComponent with a $el: HTMLTextAreaElement field) and typing textareaRef to that, so you can call .focus() without suppressing type checking. This keeps the current runtime behavior but removes the blanket type escape hatch.

As per coding guidelines, prefer proper TypeScript typing over @ts-expect-error, especially when interacting with external components like PrimeVue.

src/renderer/extensions/vueNodes/components/NodeWidgets.vue (1)

195-206: EXPANDING_TYPES list is clear; registry-driven source can be a later follow-up

The explicit EXPANDING_TYPES list matches the intended expanding widgets (textarea, markdown, 3D, etc.) and makes the behavior easy to reason about. The TODO to derive this from widgetRegistry or a shared type/enum is a good next step to avoid drift as new widgets are added, but isn’t a blocker for this PR.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c5f8a6 and a721ebf.

📒 Files selected for processing (4)
  • src/components/load3d/Load3D.vue (2 hunks)
  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue (4 hunks)
  • src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue (1 hunks)
  • src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue (1 hunks)
🧰 Additional context used
📓 Path-based instructions (15)
**/*.vue

📄 CodeRabbit inference engine (.cursorrules)

**/*.vue: Use setup() function for component logic in Vue 3 Composition API
Utilize ref and reactive for reactive state in Vue 3
Implement computed properties with computed() function
Use watch and watchEffect for side effects in Vue 3
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection in Vue 3
Use Vue 3.5 style of default prop declaration with defineProps()
Organize Vue components in <script> <style> order
Use Tailwind CSS for styling Vue components
Implement responsive design with Tailwind CSS
Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectively
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components in Vue 3
Follow Vue 3 style guide and naming conventions
Never use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage)

Never use :class="[]" to merge class names - always use import { cn } from '@/utils/tailwindUtil' for class merging in Vue templates

**/*.vue: Use TypeScript with Vue 3 Single File Components (.vue files)
Name Vue components in PascalCase (e.g., MenuHamburger.vue)

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue
  • src/components/load3d/Load3D.vue
  • src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue
  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (.cursorrules)

**/*.{vue,ts,tsx}: Leverage VueUse functions for performance-enhancing utilities
Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.json

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue
  • src/components/load3d/Load3D.vue
  • src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue
  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
**/*.{ts,tsx,js,vue}

📄 CodeRabbit inference engine (.cursorrules)

Implement proper error handling in components and services

**/*.{ts,tsx,js,vue}: Use 2-space indentation, single quotes, no semicolons, and maintain 80-character line width as configured in .prettierrc
Organize imports by sorting and grouping by plugin, and run pnpm format before committing

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue
  • src/components/load3d/Load3D.vue
  • src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue
  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
src/**/*.vue

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue
  • src/components/load3d/Load3D.vue
  • src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue
  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue
  • src/components/load3d/Load3D.vue
  • src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue
  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
**/*.{ts,tsx,js,jsx,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

Use camelCase for variable and setting names in TypeScript/Vue files

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue
  • src/components/load3d/Load3D.vue
  • src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue
  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
**/*.{vue,html}

📄 CodeRabbit inference engine (CLAUDE.md)

Never use dark: or dark-theme: Tailwind variants - instead use semantic values from style.css theme, e.g. bg-node-component-surface

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue
  • src/components/load3d/Load3D.vue
  • src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue
  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx,vue}: Use const settingStore = useSettingStore() and settingStore.get('Comfy.SomeSetting') to retrieve settings in TypeScript/Vue files
Use await settingStore.set('Comfy.SomeSetting', newValue) to update settings in TypeScript/Vue files
Check server capabilities using api.serverSupportsFeature('feature_name') before using enhanced features
Use api.getServerFeature('config_name', defaultValue) to retrieve server feature configuration

Enforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templates

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue
  • src/components/load3d/Load3D.vue
  • src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue
  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue
  • src/components/load3d/Load3D.vue
  • src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue
  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
src/**/{composables,components}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Clean up subscriptions in state management to prevent memory leaks

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue
  • src/components/load3d/Load3D.vue
  • src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue
  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue
  • src/components/load3d/Load3D.vue
  • src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue
  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Use vue-i18n for ALL user-facing strings by adding them to src/locales/en/main.json

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue
  • src/components/load3d/Load3D.vue
  • src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue
  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
src/components/**/*.vue

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue components

Files:

  • src/components/load3d/Load3D.vue
src/components/**/*.{vue,css}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package

Files:

  • src/components/load3d/Load3D.vue
src/components/**/*.{vue,ts,js}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings

Files:

  • src/components/load3d/Load3D.vue
🧠 Learnings (12)
📓 Common learnings
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursorrules:0-0
Timestamp: 2025-11-24T19:46:52.279Z
Learning: Applies to **/*.vue : Implement responsive design with Tailwind CSS
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursorrules:0-0
Timestamp: 2025-11-24T19:46:52.279Z
Learning: Applies to **/*.vue : Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectively
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursorrules:0-0
Timestamp: 2025-11-24T19:46:52.279Z
Learning: Applies to **/*.vue : Never use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage)
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:14.779Z
Learning: Applies to **/*.vue : Never use `:class="[]"` to merge class names - always use `import { cn } from '@/utils/tailwindUtil'` for class merging in Vue templates
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InlineMessage component with Message

Applied to files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue
  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover

Applied to files:

  • src/components/load3d/Load3D.vue
  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
📚 Learning: 2025-11-24T19:46:52.279Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursorrules:0-0
Timestamp: 2025-11-24T19:46:52.279Z
Learning: Applies to **/*.vue : Implement responsive design with Tailwind CSS

Applied to files:

  • src/components/load3d/Load3D.vue
📚 Learning: 2025-11-24T19:46:52.279Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursorrules:0-0
Timestamp: 2025-11-24T19:46:52.279Z
Learning: Applies to **/*.vue : Never use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage)

Applied to files:

  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with Select

Applied to files:

  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
📚 Learning: 2025-11-24T19:46:52.279Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursorrules:0-0
Timestamp: 2025-11-24T19:46:52.279Z
Learning: Applies to **/*.vue : Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectively

Applied to files:

  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
📚 Learning: 2025-11-24T19:46:52.279Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursorrules:0-0
Timestamp: 2025-11-24T19:46:52.279Z
Learning: Applies to **/*.vue : Utilize ref and reactive for reactive state in Vue 3

Applied to files:

  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitch

Applied to files:

  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)

Applied to files:

  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Steps component with Stepper without panels

Applied to files:

  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Chips component with AutoComplete with multiple enabled

Applied to files:

  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
🪛 ESLint
src/renderer/extensions/vueNodes/components/NodeWidgets.vue

[error] 70-70: Unable to resolve path to module 'vue'.

(import-x/no-unresolved)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: deploy-and-comment
  • GitHub Check: setup
  • GitHub Check: test
  • GitHub Check: collect
  • GitHub Check: lint-and-format
🔇 Additional comments (7)
src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue (1)

2-16: Textarea wrapper removal and class move look good

The DOM simplification and moving the sizing classes directly onto the Textarea keep behavior consistent while aligning with the new grid-based sizing; cn(WidgetInputBaseClass, 'relative size-full text-xs resize-none') also matches the class-merging guideline with no new user-facing strings introduced.

src/components/load3d/Load3D.vue (2)

3-3: LGTM! Cleaner Tailwind syntax.

The replacement of h-full w-full with size-full is more concise and idiomatic. The removal of widget-expands aligns with the PR's refactoring strategy to centralize expansion behavior in the parent component.


20-20: LGTM! Consistent class consolidation.

Same improvement as line 3—using size-full for cleaner, more maintainable styling.

src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue (2)

2-2: Root container layout change looks good for the new sizing model

Switching the root to class="widget-markdown relative w-full" keeps the widget full-width while leaving height to be driven by the grid/layout above it; moving @dblclick inline has no behavioral impact. This aligns with the PR’s goal of centralizing expansion behavior outside the component.


48-50: Confirm markdown HTML is sanitized with DOMPurify in renderMarkdownToHtml

Since renderedHtml is injected with v-html, please confirm that renderMarkdownToHtml already sanitizes via DOMPurify (or equivalent) and that this path can’t render untrusted content unsanitized. If it doesn’t, it should be updated to comply with the repo rule to sanitize HTML in src/**/*.{ts,tsx,vue}.

As per coding guidelines, HTML rendered into the DOM must be sanitized with DOMPurify to prevent XSS.

src/renderer/extensions/vueNodes/components/NodeWidgets.vue (2)

9-17: Dynamic grid row sizing correctly matches visible widgets

gridTemplateRows is derived from processedWidgets, filters out hidden widgets in the same way as the v-if, and assigns 'auto' only to the explicitly expanding types, so the number and order of grid rows stays in sync with what’s actually rendered. The root grid’s flex-1 class plus the grid-template-rows style binding should behave well with multiple expanding widgets and non-expanding rows sizing to content. I don’t see any logic or reactivity issues here; this cleanly implements the behavior described in the PR.

As per coding guidelines, this keeps layout concerns in Tailwind and Composition API-only logic, which is ideal.

Also applies to: 70-70, 208-218


28-28: Row container stretching aligns with new expanding behavior

Updating the per-widget wrapper to grid grid-cols-subgrid items-stretch for the full-span row ensures that both the input slot and widget component can fill the height of rows marked 'auto' while remaining compact for 'min-content' rows. This looks consistent with the new grid-based sizing and should improve visual alignment when textareas/markdown/3D widgets grow vertically.

@github-actions github-actions bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Dec 3, 2025
Copy link
Contributor

@simula-r simula-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DrJKL DrJKL merged commit 497bafc into main Dec 3, 2025
3 checks passed
@DrJKL DrJKL deleted the drjkl/I-love-grid-but-sometimes branch December 3, 2025 02:49
@coderabbitai coderabbitai bot mentioned this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants