-
Notifications
You must be signed in to change notification settings - Fork 433
Fix: Widget sizing with multiple expanding items #7118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the 📝 WalkthroughWalkthroughCSS class consolidation and layout refactoring across Vue components. The widget-expands class is removed from multiple components and replaced with size-full. NodeWidgets.vue now computes grid-template-rows dynamically based on widget types, introducing an EXPANDING_TYPES constant for expansion behavior classification. DOM wrappers are simplified in WidgetTextarea.vue. Changes
Possibly related PRs✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 12/03/2025, 02:53:44 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/03/2025, 02:44:34 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.21 MB (baseline 3.21 MB) • 🔴 +379 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 929 kB (baseline 929 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 169 kB (baseline 169 kB) • 🟢 -23 BReusable component library chunks
Status: 6 added / 6 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.81 MB (baseline 3.81 MB) • 🟢 -183 BBundles that do not match a named category
Status: 17 added / 17 removed |
|
Updating Playwright Expectations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue (1)
60-61: Refactor away from@ts-expect-errorwhen focusing the textareaThe
@ts-expect-erroron$elconflicts with the guideline to avoid@ts-expect-errorinsrc/**/*.{ts,tsx,vue}. Consider introducing a small typed interface for the ref (e.g., aFocusableTextareaComponentwith a$el: HTMLTextAreaElementfield) and typingtextareaRefto that, so you can call.focus()without suppressing type checking. This keeps the current runtime behavior but removes the blanket type escape hatch.As per coding guidelines, prefer proper TypeScript typing over
@ts-expect-error, especially when interacting with external components like PrimeVue.src/renderer/extensions/vueNodes/components/NodeWidgets.vue (1)
195-206: EXPANDING_TYPES list is clear; registry-driven source can be a later follow-upThe explicit
EXPANDING_TYPESlist matches the intended expanding widgets (textarea, markdown, 3D, etc.) and makes the behavior easy to reason about. The TODO to derive this fromwidgetRegistryor a shared type/enum is a good next step to avoid drift as new widgets are added, but isn’t a blocker for this PR.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/components/load3d/Load3D.vue(2 hunks)src/renderer/extensions/vueNodes/components/NodeWidgets.vue(4 hunks)src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue(1 hunks)src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue(1 hunks)
🧰 Additional context used
📓 Path-based instructions (15)
**/*.vue
📄 CodeRabbit inference engine (.cursorrules)
**/*.vue: Use setup() function for component logic in Vue 3 Composition API
Utilize ref and reactive for reactive state in Vue 3
Implement computed properties with computed() function
Use watch and watchEffect for side effects in Vue 3
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection in Vue 3
Use Vue 3.5 style of default prop declaration with defineProps()
Organize Vue components in <script> <style> order
Use Tailwind CSS for styling Vue components
Implement responsive design with Tailwind CSS
Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectively
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components in Vue 3
Follow Vue 3 style guide and naming conventions
Never use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage)Never use
:class="[]"to merge class names - always useimport { cn } from '@/utils/tailwindUtil'for class merging in Vue templates
**/*.vue: Use TypeScript with Vue 3 Single File Components (.vuefiles)
Name Vue components in PascalCase (e.g.,MenuHamburger.vue)Files:
src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vuesrc/components/load3d/Load3D.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vuesrc/renderer/extensions/vueNodes/components/NodeWidgets.vue**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (.cursorrules)
**/*.{vue,ts,tsx}: Leverage VueUse functions for performance-enhancing utilities
Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.jsonFiles:
src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vuesrc/components/load3d/Load3D.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vuesrc/renderer/extensions/vueNodes/components/NodeWidgets.vue**/*.{ts,tsx,js,vue}
📄 CodeRabbit inference engine (.cursorrules)
Implement proper error handling in components and services
**/*.{ts,tsx,js,vue}: Use 2-space indentation, single quotes, no semicolons, and maintain 80-character line width as configured in.prettierrc
Organize imports by sorting and grouping by plugin, and runpnpm formatbefore committingFiles:
src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vuesrc/components/load3d/Load3D.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vuesrc/renderer/extensions/vueNodes/components/NodeWidgets.vuesrc/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventionsFiles:
src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vuesrc/components/load3d/Load3D.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vuesrc/renderer/extensions/vueNodes/components/NodeWidgets.vuesrc/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.jsonFiles:
src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vuesrc/components/load3d/Load3D.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vuesrc/renderer/extensions/vueNodes/components/NodeWidgets.vue**/*.{ts,tsx,js,jsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
Use camelCase for variable and setting names in TypeScript/Vue files
Files:
src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vuesrc/components/load3d/Load3D.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vuesrc/renderer/extensions/vueNodes/components/NodeWidgets.vue**/*.{vue,html}
📄 CodeRabbit inference engine (CLAUDE.md)
Never use
dark:ordark-theme:Tailwind variants - instead use semantic values fromstyle.csstheme, e.g.bg-node-component-surfaceFiles:
src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vuesrc/components/load3d/Load3D.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vuesrc/renderer/extensions/vueNodes/components/NodeWidgets.vue**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,vue}: Useconst settingStore = useSettingStore()andsettingStore.get('Comfy.SomeSetting')to retrieve settings in TypeScript/Vue files
Useawait settingStore.set('Comfy.SomeSetting', newValue)to update settings in TypeScript/Vue files
Check server capabilities usingapi.serverSupportsFeature('feature_name')before using enhanced features
Useapi.getServerFeature('config_name', defaultValue)to retrieve server feature configurationEnforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templates
Files:
src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vuesrc/components/load3d/Load3D.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vuesrc/renderer/extensions/vueNodes/components/NodeWidgets.vuesrc/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebaseFiles:
src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vuesrc/components/load3d/Load3D.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vuesrc/renderer/extensions/vueNodes/components/NodeWidgets.vuesrc/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vuesrc/components/load3d/Load3D.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vuesrc/renderer/extensions/vueNodes/components/NodeWidgets.vuesrc/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vuesrc/components/load3d/Load3D.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vuesrc/renderer/extensions/vueNodes/components/NodeWidgets.vuesrc/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.jsonFiles:
src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vuesrc/components/load3d/Load3D.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vuesrc/renderer/extensions/vueNodes/components/NodeWidgets.vuesrc/components/**/*.vue
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue componentsFiles:
src/components/load3d/Load3D.vuesrc/components/**/*.{vue,css}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system packageFiles:
src/components/load3d/Load3D.vuesrc/components/**/*.{vue,ts,js}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI stringsFiles:
src/components/load3d/Load3D.vue🧠 Learnings (12)
📓 Common learnings
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.279Z Learning: Applies to **/*.vue : Implement responsive design with Tailwind CSSLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.279Z Learning: Applies to **/*.vue : Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectivelyLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.279Z Learning: Applies to **/*.vue : Never use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage)Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:14.779Z Learning: Applies to **/*.vue : Never use `:class="[]"` to merge class names - always use `import { cn } from '@/utils/tailwindUtil'` for class merging in Vue templates📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.616Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue InlineMessage component with MessageApplied to files:
src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vuesrc/renderer/extensions/vueNodes/components/NodeWidgets.vue📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.616Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with PopoverApplied to files:
src/components/load3d/Load3D.vuesrc/renderer/extensions/vueNodes/components/NodeWidgets.vue📚 Learning: 2025-11-24T19:46:52.279Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.279Z Learning: Applies to **/*.vue : Implement responsive design with Tailwind CSSApplied to files:
src/components/load3d/Load3D.vue📚 Learning: 2025-11-24T19:46:52.279Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.279Z Learning: Applies to **/*.vue : Never use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage)Applied to files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vue📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.616Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with SelectApplied to files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vue📚 Learning: 2025-11-24T19:46:52.279Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.279Z Learning: Applies to **/*.vue : Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectivelyApplied to files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vue📚 Learning: 2025-11-24T19:46:52.279Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.279Z Learning: Applies to **/*.vue : Utilize ref and reactive for reactive state in Vue 3Applied to files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vue📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.616Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitchApplied to files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vue📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-11-24T19:47:02.860Z Learning: Applies to src/**/*.vue : Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)Applied to files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vue📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.616Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue Steps component with Stepper without panelsApplied to files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vue📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.616Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue Chips component with AutoComplete with multiple enabledApplied to files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vue🪛 ESLint
src/renderer/extensions/vueNodes/components/NodeWidgets.vue
[error] 70-70: Unable to resolve path to module 'vue'.
(import-x/no-unresolved)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: deploy-and-comment
- GitHub Check: setup
- GitHub Check: test
- GitHub Check: collect
- GitHub Check: lint-and-format
🔇 Additional comments (7)
src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue (1)
2-16: Textarea wrapper removal and class move look goodThe DOM simplification and moving the sizing classes directly onto the
Textareakeep behavior consistent while aligning with the new grid-based sizing;cn(WidgetInputBaseClass, 'relative size-full text-xs resize-none')also matches the class-merging guideline with no new user-facing strings introduced.src/components/load3d/Load3D.vue (2)
3-3: LGTM! Cleaner Tailwind syntax.The replacement of
h-full w-fullwithsize-fullis more concise and idiomatic. The removal ofwidget-expandsaligns with the PR's refactoring strategy to centralize expansion behavior in the parent component.
20-20: LGTM! Consistent class consolidation.Same improvement as line 3—using
size-fullfor cleaner, more maintainable styling.src/renderer/extensions/vueNodes/widgets/components/WidgetMarkdown.vue (2)
2-2: Root container layout change looks good for the new sizing modelSwitching the root to
class="widget-markdown relative w-full"keeps the widget full-width while leaving height to be driven by the grid/layout above it; moving@dblclickinline has no behavioral impact. This aligns with the PR’s goal of centralizing expansion behavior outside the component.
48-50: Confirm markdown HTML is sanitized with DOMPurify inrenderMarkdownToHtmlSince
renderedHtmlis injected withv-html, please confirm thatrenderMarkdownToHtmlalready sanitizes via DOMPurify (or equivalent) and that this path can’t render untrusted content unsanitized. If it doesn’t, it should be updated to comply with the repo rule to sanitize HTML insrc/**/*.{ts,tsx,vue}.As per coding guidelines, HTML rendered into the DOM must be sanitized with DOMPurify to prevent XSS.
src/renderer/extensions/vueNodes/components/NodeWidgets.vue (2)
9-17: Dynamic grid row sizing correctly matches visible widgets
gridTemplateRowsis derived fromprocessedWidgets, filters out hidden widgets in the same way as thev-if, and assigns'auto'only to the explicitly expanding types, so the number and order of grid rows stays in sync with what’s actually rendered. The root grid’sflex-1class plus thegrid-template-rowsstyle binding should behave well with multiple expanding widgets and non-expanding rows sizing to content. I don’t see any logic or reactivity issues here; this cleanly implements the behavior described in the PR.As per coding guidelines, this keeps layout concerns in Tailwind and Composition API-only logic, which is ideal.
Also applies to: 70-70, 208-218
28-28: Row container stretching aligns with new expanding behaviorUpdating the per-widget wrapper to
grid grid-cols-subgrid items-stretchfor the full-span row ensures that both the input slot and widget component can fill the height of rows marked'auto'while remaining compact for'min-content'rows. This looks consistent with the new grid-based sizing and should improve visual alignment when textareas/markdown/3D widgets grow vertically.
simula-r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Textarea/Markdown/3D pieces grow, other widget rows size to their contents.
Screenshots (if applicable)
┆Issue is synchronized with this Notion page by Unito