Replace IDistributedApplicationLifecycleHook with event-based patterns

Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>

Author: Copilot

src/CommunityToolkit.Aspire.Hosting.Bun/BunAppExtensions.cs

@@ -1,6 +1,4 @@
 using Aspire.Hosting.ApplicationModel;
-using Aspire.Hosting.Lifecycle;
-using CommunityToolkit.Aspire.Hosting.Bun;
 using CommunityToolkit.Aspire.Utils;
 using Microsoft.Extensions.Hosting;
 
@@ -46,10 +44,27 @@ public static IResourceBuilder<BunAppResource> AddBunApp(
     /// Ensures the Bun packages are installed before the application starts using Bun as the package manager.
     /// </summary>
     /// <param name="resource">The Bun app resource.</param>
+    /// <param name="configureInstaller">Configure the Bun installer resource.</param>
     /// <returns>A reference to the <see cref="IResourceBuilder{T}"/>.</returns>
-    public static IResourceBuilder<BunAppResource> WithBunPackageInstallation(this IResourceBuilder<BunAppResource> resource)
+    public static IResourceBuilder<BunAppResource> WithBunPackageInstallation(this IResourceBuilder<BunAppResource> resource, Action<IResourceBuilder<BunInstallerResource>>? configureInstaller = null)
     {
-        resource.ApplicationBuilder.Services.TryAddLifecycleHook<BunPackageInstallerLifecycleHook>();
+        // Only install packages during development, not in publish mode
+        if (!resource.ApplicationBuilder.ExecutionContext.IsPublishMode)
+        {
+            var installerName = $"{resource.Resource.Name}-bun-install";
+            var installer = new BunInstallerResource(installerName, resource.Resource.WorkingDirectory);
+
+            var installerBuilder = resource.ApplicationBuilder.AddResource(installer)
+                .WithArgs("install")
+                .WithParentRelationship(resource.Resource)
+                .ExcludeFromManifest();
+
+            // Make the parent resource wait for the installer to complete
+            resource.WaitForCompletion(installerBuilder);
+
+            configureInstaller?.Invoke(installerBuilder);
+        }
+
         return resource;
     }
 

src/CommunityToolkit.Aspire.Hosting.Bun/BunInstallerResource.cs

@@ -0,0 +1,9 @@
+namespace Aspire.Hosting.ApplicationModel;
+
+/// <summary>
+/// A resource that represents a Bun package installer.
+/// </summary>
+/// <param name="name">The name of the resource.</param>
+/// <param name="workingDirectory">The working directory to use for the command.</param>
+public class BunInstallerResource(string name, string workingDirectory)
+    : ExecutableResource(name, "bun", workingDirectory);

src/CommunityToolkit.Aspire.Hosting.Bun/BunPackageInstallerLifecycleHook.cs

@@ -4,7 +4,6 @@
 using Aspire.Hosting;
 using Aspire.Hosting.ApplicationModel;
 using Aspire.Hosting.Eventing;
-using Aspire.Hosting.Lifecycle;
 using Aspire.Hosting.Utils;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
@@ -23,7 +22,7 @@ internal sealed class DaprDistributedApplicationLifecycleHook(
     IConfiguration configuration,
     IHostEnvironment environment,
     ILogger<DaprDistributedApplicationLifecycleHook> logger,
-    IOptions<DaprOptions> options) : IDistributedApplicationLifecycleHook, IDisposable
+    IOptions<DaprOptions> options) : IDisposable
 {
     private readonly DaprOptions _options = options.Value;
 

src/CommunityToolkit.Aspire.Hosting.Dapr/DaprDistributedApplicationLifecycleHook.cs

@@ -2,12 +2,15 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using Aspire.Hosting.ApplicationModel;
-using Aspire.Hosting.Lifecycle;
+using Aspire.Hosting.Eventing;
 using Aspire.Hosting.Publishing;
 using Aspire.Hosting.Utils;
 using CommunityToolkit.Aspire.Hosting.Dapr;
+using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Hosting;
 using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Options;
 
 namespace Aspire.Hosting;
 
@@ -30,7 +33,16 @@ public static IDistributedApplicationBuilder AddDapr(this IDistributedApplicatio
             builder.Services.Configure(configure);
         }
 
-        builder.Services.TryAddLifecycleHook<DaprDistributedApplicationLifecycleHook>();
+        builder.Eventing.Subscribe<BeforeStartEvent>(async (evt, ct) =>
+        {
+            var hook = new DaprDistributedApplicationLifecycleHook(
+                evt.Services.GetRequiredService<IConfiguration>(),
+                evt.Services.GetRequiredService<IHostEnvironment>(),
+                evt.Services.GetRequiredService<ILogger<DaprDistributedApplicationLifecycleHook>>(),
+                evt.Services.GetRequiredService<IOptions<DaprOptions>>());
+
+            await hook.BeforeStartAsync(evt.Model, ct).ConfigureAwait(false);
+        });
 
         return builder;
     }

src/CommunityToolkit.Aspire.Hosting.Dapr/IDistributedApplicationBuilderExtensions.cs

@@ -1,8 +1,6 @@
 using Aspire.Hosting.ApplicationModel;
-using Aspire.Hosting.Lifecycle;
 using Microsoft.Extensions.Hosting;
 using CommunityToolkit.Aspire.Utils;
-using CommunityToolkit.Aspire.Hosting.Deno;
 
 namespace Aspire.Hosting;
 /// <summary>
@@ -73,10 +71,27 @@ public static IResourceBuilder<DenoAppResource> AddDenoTask(this IDistributedApp
     /// Ensures the Deno packages are installed before the application starts using Deno as the package manager.
     /// </summary>
     /// <param name="resource">The Deno app resource.</param>
+    /// <param name="configureInstaller">Configure the Deno installer resource.</param>
     /// <returns>A reference to the <see cref="IResourceBuilder{T}"/>.</returns>
-    public static IResourceBuilder<DenoAppResource> WithDenoPackageInstallation(this IResourceBuilder<DenoAppResource> resource)
+    public static IResourceBuilder<DenoAppResource> WithDenoPackageInstallation(this IResourceBuilder<DenoAppResource> resource, Action<IResourceBuilder<DenoInstallerResource>>? configureInstaller = null)
     {
-        resource.ApplicationBuilder.Services.TryAddLifecycleHook<DenoPackageInstallerLifecycleHook>();
+        // Only install packages during development, not in publish mode
+        if (!resource.ApplicationBuilder.ExecutionContext.IsPublishMode)
+        {
+            var installerName = $"{resource.Resource.Name}-deno-install";
+            var installer = new DenoInstallerResource(installerName, resource.Resource.WorkingDirectory);
+
+            var installerBuilder = resource.ApplicationBuilder.AddResource(installer)
+                .WithArgs("install")
+                .WithParentRelationship(resource.Resource)
+                .ExcludeFromManifest();
+
+            // Make the parent resource wait for the installer to complete
+            resource.WaitForCompletion(installerBuilder);
+
+            configureInstaller?.Invoke(installerBuilder);
+        }
+
         return resource;
     }
 

src/CommunityToolkit.Aspire.Hosting.Deno/DenoAppHostingExtensions.cs

@@ -0,0 +1,9 @@
+namespace Aspire.Hosting.ApplicationModel;
+
+/// <summary>
+/// A resource that represents a Deno package installer.
+/// </summary>
+/// <param name="name">The name of the resource.</param>
+/// <param name="workingDirectory">The working directory to use for the command.</param>
+public class DenoInstallerResource(string name, string workingDirectory)
+    : ExecutableResource(name, "deno", workingDirectory);