From 9ba5d4d18698b26bbd323dcb900d5d8faffd456b Mon Sep 17 00:00:00 2001 From: Arlo Godfrey Date: Mon, 21 Mar 2022 18:01:26 -0500 Subject: [PATCH 1/3] Fixed MacOS and iOS projects not building properly --- Common/Labs.Head.props | 17 ++++++--- .../CommunityToolkit.Labs.iOS.csproj | 5 +++ .../CommunityToolkit.Labs.macOS.csproj | 35 +++++++------------ 3 files changed, 29 insertions(+), 28 deletions(-) diff --git a/Common/Labs.Head.props b/Common/Labs.Head.props index 1ddca7b43..478951dbc 100644 --- a/Common/Labs.Head.props +++ b/Common/Labs.Head.props @@ -1,6 +1,12 @@ - - + + + + + + + + @@ -16,9 +22,10 @@ - + + TargetFramework=netstandard2.0 + Platform=$(PlatformTarget) + \ No newline at end of file diff --git a/Platforms/CommunityToolkit.Labs.iOS/CommunityToolkit.Labs.iOS.csproj b/Platforms/CommunityToolkit.Labs.iOS/CommunityToolkit.Labs.iOS.csproj index e70bcaaf1..fdfa6a43c 100644 --- a/Platforms/CommunityToolkit.Labs.iOS/CommunityToolkit.Labs.iOS.csproj +++ b/Platforms/CommunityToolkit.Labs.iOS/CommunityToolkit.Labs.iOS.csproj @@ -27,6 +27,7 @@ 4 false x86_64 + x64 None true --setenv=MONO_LOG_LEVEL=debug --setenv=MONO_LOG_MASK=gc --setenv=MONO_GC_PARAMS=soft-heap-limit=512m,nursery-size=64m,evacuation-threshold=66,major=marksweep,concurrent-sweep @@ -39,6 +40,7 @@ 4 None x86_64 + x64 false --setenv=MONO_GC_PARAMS=soft-heap-limit=512m,nursery-size=64m,evacuation-threshold=66,major=marksweep,concurrent-sweep @@ -52,6 +54,7 @@ 4 false ARM64 + ARM64 Entitlements.plist iPhone Developer true @@ -65,6 +68,7 @@ 4 Entitlements.plist ARM64 + ARM64 false iPhone Distribution true @@ -80,6 +84,7 @@ 4 False ARM64 + ARM64 Entitlements.plist True Automatic:AdHoc diff --git a/Platforms/CommunityToolkit.Labs.macOS/CommunityToolkit.Labs.macOS.csproj b/Platforms/CommunityToolkit.Labs.macOS/CommunityToolkit.Labs.macOS.csproj index 0cab23d25..94503e738 100644 --- a/Platforms/CommunityToolkit.Labs.macOS/CommunityToolkit.Labs.macOS.csproj +++ b/Platforms/CommunityToolkit.Labs.macOS/CommunityToolkit.Labs.macOS.csproj @@ -1,14 +1,12 @@ - + - - Debug iPhoneSimulator - 34617141-25C4-4FEC-8A15-5B46934F1A99 + {34617141-25C4-4FEC-8A15-5B46934F1A99} {A3F8F2AB-B479-4A4A-A458-A89E7DC349F1};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC} Exe CommunityToolkit.Labs.macOS @@ -33,14 +31,11 @@ true true true - - - - - - - - + + + + + x64 false @@ -58,12 +53,10 @@ true true SdkOnly - - - - - - + + + + x64 @@ -96,11 +89,7 @@ - - - - - + From d64c1a217271c3171410f2b970e76a69d4490d19 Mon Sep 17 00:00:00 2001 From: Arlo Godfrey Date: Thu, 24 Mar 2022 17:34:30 -0500 Subject: [PATCH 2/3] Revert "Fixed MacOS and iOS projects not building properly" This reverts commit 9ba5d4d18698b26bbd323dcb900d5d8faffd456b. --- Common/Labs.Head.props | 17 +++------ .../CommunityToolkit.Labs.iOS.csproj | 5 --- .../CommunityToolkit.Labs.macOS.csproj | 35 ++++++++++++------- 3 files changed, 28 insertions(+), 29 deletions(-) diff --git a/Common/Labs.Head.props b/Common/Labs.Head.props index 478951dbc..1ddca7b43 100644 --- a/Common/Labs.Head.props +++ b/Common/Labs.Head.props @@ -1,12 +1,6 @@ - - - - - - - - + + @@ -22,10 +16,9 @@ - - TargetFramework=netstandard2.0 - Platform=$(PlatformTarget) - + \ No newline at end of file diff --git a/Platforms/CommunityToolkit.Labs.iOS/CommunityToolkit.Labs.iOS.csproj b/Platforms/CommunityToolkit.Labs.iOS/CommunityToolkit.Labs.iOS.csproj index fdfa6a43c..e70bcaaf1 100644 --- a/Platforms/CommunityToolkit.Labs.iOS/CommunityToolkit.Labs.iOS.csproj +++ b/Platforms/CommunityToolkit.Labs.iOS/CommunityToolkit.Labs.iOS.csproj @@ -27,7 +27,6 @@ 4 false x86_64 - x64 None true --setenv=MONO_LOG_LEVEL=debug --setenv=MONO_LOG_MASK=gc --setenv=MONO_GC_PARAMS=soft-heap-limit=512m,nursery-size=64m,evacuation-threshold=66,major=marksweep,concurrent-sweep @@ -40,7 +39,6 @@ 4 None x86_64 - x64 false --setenv=MONO_GC_PARAMS=soft-heap-limit=512m,nursery-size=64m,evacuation-threshold=66,major=marksweep,concurrent-sweep @@ -54,7 +52,6 @@ 4 false ARM64 - ARM64 Entitlements.plist iPhone Developer true @@ -68,7 +65,6 @@ 4 Entitlements.plist ARM64 - ARM64 false iPhone Distribution true @@ -84,7 +80,6 @@ 4 False ARM64 - ARM64 Entitlements.plist True Automatic:AdHoc diff --git a/Platforms/CommunityToolkit.Labs.macOS/CommunityToolkit.Labs.macOS.csproj b/Platforms/CommunityToolkit.Labs.macOS/CommunityToolkit.Labs.macOS.csproj index 94503e738..0cab23d25 100644 --- a/Platforms/CommunityToolkit.Labs.macOS/CommunityToolkit.Labs.macOS.csproj +++ b/Platforms/CommunityToolkit.Labs.macOS/CommunityToolkit.Labs.macOS.csproj @@ -1,12 +1,14 @@ - + + + Debug iPhoneSimulator - {34617141-25C4-4FEC-8A15-5B46934F1A99} + 34617141-25C4-4FEC-8A15-5B46934F1A99 {A3F8F2AB-B479-4A4A-A458-A89E7DC349F1};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC} Exe CommunityToolkit.Labs.macOS @@ -31,11 +33,14 @@ true true true - - - - - x64 + + + + + + + + false @@ -53,10 +58,12 @@ true true SdkOnly - - - - x64 + + + + + + @@ -89,7 +96,11 @@ - + + + + + From 07cfca0540492ea4159ef08b9e4a79829ab1ac2d Mon Sep 17 00:00:00 2001 From: Arlo Godfrey Date: Thu, 24 Mar 2022 19:59:05 -0500 Subject: [PATCH 3/3] Implement source generator workaround for ios/wasm --- Common/Labs.Head.props | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Common/Labs.Head.props b/Common/Labs.Head.props index 1ddca7b43..50ab9f316 100644 --- a/Common/Labs.Head.props +++ b/Common/Labs.Head.props @@ -17,8 +17,9 @@ + OutputItemType="None" ReferenceOutputAssembly="true" /> + + \ No newline at end of file