-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed an issue where all documents were include regardless of MultiTarget support #237
Conversation
I may have to try another machine, I haven't been able to get past unoplatform/Uno.Wasm.Bootstrap#776 building this at the moment. |
@Arlodotexe tested this against the latest changes in the CommunityToolkit/Tooling-Windows-Submodule#141 PR that this is on top of, this PR needs to be updated though, but otherwise, good to go. |
…ithub.com/CommunityToolkit/Windows into fix/samples/multitarget-aware-sample-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this earlier with the submodule changes, so should be all good, thanks!
PR Type
Fixes an issue where all documents were include regardless of MultiTarget support.
What is the current behavior?
Before, the tooling would blindly pull in all markdown files and let the SampleGen source generator sort it out for creating the Document Registry.
This is in contrast to the Sample Registry, which inherits its MultiTarget-aware characteristics from MSBuild by discovering only in projects that are referenced at build time.
What is the new behavior?
With these changes, markdown files are preprocessed with the new Target. Files found in components that don't
<MultiTarget>
the platform being built are filtered out before being added asAdditionalFiles
. Then, it's picked up by the SampleGen tooling to create the Document Registry.PR Checklist
Please check if your PR fulfills the following requirements:
Other information