From 92260230d888242e5f10f3e906a7d6237d8afc0c Mon Sep 17 00:00:00 2001
From: "lukas.f" <lukas.fellechner@gmx.net>
Date: Tue, 2 May 2017 21:27:45 +0200
Subject: [PATCH 1/3] Remove GridSplitterGripper to allow control of tab
 behavior and simplify visual tree.

---
 .../GridSplitter/GridSplitter.Events.cs       | 47 +++++-----
 .../GridSplitter/GridSplitter.Options.cs      |  5 +-
 .../GridSplitter/GridSplitter.cs              |  3 +
 .../GridSplitter/GridSplitter.xaml            |  6 +-
 .../GridSplitter/GridSplitterGripper.cs       | 85 -------------------
 .../Microsoft.Toolkit.Uwp.UI.Controls.csproj  |  1 -
 6 files changed, 35 insertions(+), 112 deletions(-)
 delete mode 100644 Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitterGripper.cs

diff --git a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Events.cs b/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Events.cs
index 0f936ea30ff..5a7d7ca77cf 100644
--- a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Events.cs
+++ b/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Events.cs
@@ -13,7 +13,9 @@
 using Windows.System;
 using Windows.UI.Core;
 using Windows.UI.Xaml;
+using Windows.UI.Xaml.Controls;
 using Windows.UI.Xaml.Input;
+using Windows.UI.Xaml.Media;
 
 namespace Microsoft.Toolkit.Uwp.UI.Controls
 {
@@ -22,30 +24,22 @@ namespace Microsoft.Toolkit.Uwp.UI.Controls
     /// </summary>
     public partial class GridSplitter
     {
+        // Symbols for GripperBar in Segoe MDL2 Assets
+        private const string GripperBarVertical = "\xE784";
+        private const string GripperBarHorizontal = "\xE76F";
+        private const string GripperDisplayFont = "Segoe MDL2 Assets";
+
         private void GridSplitter_Loaded(object sender, RoutedEventArgs e)
         {
             _resizeDirection = GetResizeDirection();
             _resizeBehavior = GetResizeBehavior();
 
-            GridSplitterGripper gripper;
-
             // Adding Grip to Grid Splitter
             if (Element == default(UIElement))
             {
-                gripper = new GridSplitterGripper(
-                    _resizeDirection,
-                    GripperForeground);
+                CreateGripperDisplay();
+                Element = _gripperDisplay;
             }
-            else
-            {
-                var content = Element;
-                Element = null;
-                gripper = new GridSplitterGripper(content, _resizeDirection);
-            }
-
-            Element = gripper;
-
-            gripper.KeyDown += Gripper_KeyDown;
 
             var hoverWrapper = new GripperHoverWrapper(
                 CursorBehavior == SplitterCursorBehavior.ChangeOnSplitterHover
@@ -60,15 +54,24 @@ private void GridSplitter_Loaded(object sender, RoutedEventArgs e)
             _hoverWrapper = hoverWrapper;
         }
 
-        private void Gripper_KeyDown(object sender, KeyRoutedEventArgs e)
+        private void CreateGripperDisplay()
         {
-            var gripper = sender as GridSplitterGripper;
-
-            if (gripper == null)
+            if (_gripperDisplay == null)
             {
-                return;
+                var gripperText = _resizeDirection == GridResizeDirection.Columns ? GripperBarVertical : GripperBarHorizontal;
+                _gripperDisplay = new TextBlock
+                {
+                    FontFamily = new FontFamily(GripperDisplayFont),
+                    HorizontalAlignment = HorizontalAlignment.Center,
+                    VerticalAlignment = VerticalAlignment.Center,
+                    Foreground = GripperForeground,
+                    Text = gripperText
+                };
             }
+        }
 
+        private void GridSplitter_KeyDown(object sender, KeyRoutedEventArgs e)
+        {
             var step = 1;
             var ctrl = Window.Current.CoreWindow.GetKeyState(VirtualKey.Control);
             if (ctrl.HasFlag(CoreVirtualKeyStates.Down))
@@ -76,7 +79,7 @@ private void Gripper_KeyDown(object sender, KeyRoutedEventArgs e)
                 step = 5;
             }
 
-            if (gripper.ResizeDirection == GridResizeDirection.Columns)
+            if (_resizeDirection == GridResizeDirection.Columns)
             {
                 if (e.Key == VirtualKey.Left)
                 {
@@ -95,7 +98,7 @@ private void Gripper_KeyDown(object sender, KeyRoutedEventArgs e)
                 return;
             }
 
-            if (gripper.ResizeDirection == GridResizeDirection.Rows)
+            if (_resizeDirection == GridResizeDirection.Rows)
             {
                 if (e.Key == VirtualKey.Up)
                 {
diff --git a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Options.cs b/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Options.cs
index de2ccffcfa7..6b2d687b0f0 100644
--- a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Options.cs
+++ b/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Options.cs
@@ -12,6 +12,7 @@
 
 using Windows.UI.Core;
 using Windows.UI.Xaml;
+using Windows.UI.Xaml.Controls;
 using Windows.UI.Xaml.Media;
 
 namespace Microsoft.Toolkit.Uwp.UI.Controls
@@ -180,10 +181,10 @@ public SplitterCursorBehavior CursorBehavior
         private static void OnGripperForegroundPropertyChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
         {
             var gridSplitter = (GridSplitter)d;
-            var grip = gridSplitter.Element as GridSplitterGripper;
+            var grip = gridSplitter._gripperDisplay;
             if (grip != null)
             {
-                grip.GripperForeground = gridSplitter.GripperForeground;
+                grip.Foreground = gridSplitter.GripperForeground;
             }
         }
 
diff --git a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.cs b/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.cs
index 93c8553ab6a..434c44d693d 100644
--- a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.cs
+++ b/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.cs
@@ -31,6 +31,7 @@ public partial class GridSplitter : Control
         private GridResizeDirection _resizeDirection;
         private GridResizeBehavior _resizeBehavior;
         private GripperHoverWrapper _hoverWrapper;
+        private TextBlock _gripperDisplay;
 
         /// <summary>
         /// Gets the target parent grid from level
@@ -174,9 +175,11 @@ protected override void OnApplyTemplate()
 
             // Unhook registered events
             Loaded -= GridSplitter_Loaded;
+            KeyDown -= GridSplitter_KeyDown;
 
             // Register Events
             Loaded += GridSplitter_Loaded;
+            KeyDown += GridSplitter_KeyDown;
 
             _hoverWrapper?.UnhookEvents();
 
diff --git a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.xaml b/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.xaml
index 83941258f32..009a8cbb193 100644
--- a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.xaml
+++ b/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.xaml
@@ -3,12 +3,14 @@
                     xmlns:local="using:Microsoft.Toolkit.Uwp.UI.Controls">
 
     <Style TargetType="local:GridSplitter">
-        <Setter Property="IsTabStop" Value="False"></Setter>
+        <Setter Property="IsTabStop" Value="True"></Setter>
+        <Setter Property="UseSystemFocusVisuals" Value="True"></Setter>
+        <Setter Property="IsFocusEngagementEnabled" Value="True"></Setter>
         <Setter Property="Template">
             <Setter.Value>
                 <ControlTemplate TargetType="local:GridSplitter">
                     <Grid Background="{TemplateBinding Background}">
-                        <ContentPresenter Content="{TemplateBinding Element}" />
+                        <ContentPresenter Content="{TemplateBinding Element}" HorizontalContentAlignment="Stretch" VerticalContentAlignment="Stretch" />
                     </Grid>
                 </ControlTemplate>
             </Setter.Value>
diff --git a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitterGripper.cs b/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitterGripper.cs
deleted file mode 100644
index b34601c664d..00000000000
--- a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitterGripper.cs
+++ /dev/null
@@ -1,85 +0,0 @@
-// ******************************************************************
-// Copyright (c) Microsoft. All rights reserved.
-// This code is licensed under the MIT License (MIT).
-// THE CODE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED,
-// INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
-// IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
-// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
-// TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH
-// THE CODE OR THE USE OR OTHER DEALINGS IN THE CODE.
-// ******************************************************************
-
-using Windows.UI.Xaml;
-using Windows.UI.Xaml.Controls;
-using Windows.UI.Xaml.Media;
-
-namespace Microsoft.Toolkit.Uwp.UI.Controls
-{
-    internal class GridSplitterGripper : ContentControl
-    {
-        // Symbol GripperBarVertical in Segoe MDL2 Assets
-        private const string GripperBarVertical = "\xE784";
-
-        // Symbol GripperBarHorizontal in Segoe MDL2 Assets
-        private const string GripperBarHorizontal = "\xE76F";
-        private const string GripperDisplayFont = "Segoe MDL2 Assets";
-        private readonly TextBlock _gripperDisplay;
-
-        public GridSplitter.GridResizeDirection ResizeDirection { get; private set; }
-
-        internal Brush GripperForeground
-        {
-            set
-            {
-                if (_gripperDisplay == null)
-                {
-                    return;
-                }
-
-                _gripperDisplay.Foreground = value;
-            }
-        }
-
-        internal GridSplitterGripper(GridSplitter.GridResizeDirection gridSplitterDirection)
-        {
-            ResizeDirection = gridSplitterDirection;
-            HorizontalContentAlignment = HorizontalAlignment.Stretch;
-            VerticalContentAlignment = VerticalAlignment.Stretch;
-            IsTabStop = true;
-            UseSystemFocusVisuals = true;
-            IsFocusEngagementEnabled = true;
-        }
-
-        internal GridSplitterGripper(
-            GridSplitter.GridResizeDirection gridSplitterDirection,
-            Brush gripForeground)
-            : this(gridSplitterDirection)
-        {
-            _gripperDisplay = new TextBlock
-            {
-                FontFamily = new FontFamily(GripperDisplayFont),
-                HorizontalAlignment = HorizontalAlignment.Center,
-                VerticalAlignment = VerticalAlignment.Center,
-                Foreground = gripForeground
-            };
-
-            if (gridSplitterDirection == GridSplitter.GridResizeDirection.Columns)
-            {
-                _gripperDisplay.Text = GripperBarVertical;
-            }
-            else if (gridSplitterDirection == GridSplitter.GridResizeDirection.Rows)
-            {
-                _gripperDisplay.Text = GripperBarHorizontal;
-            }
-
-            Content = _gripperDisplay;
-        }
-
-        internal GridSplitterGripper(UIElement content, GridSplitter.GridResizeDirection gridSplitterDirection)
-            : this(gridSplitterDirection)
-        {
-            Content = content;
-        }
-    }
-}
diff --git a/Microsoft.Toolkit.Uwp.UI.Controls/Microsoft.Toolkit.Uwp.UI.Controls.csproj b/Microsoft.Toolkit.Uwp.UI.Controls/Microsoft.Toolkit.Uwp.UI.Controls.csproj
index d91bc84bd5f..a209e76883a 100644
--- a/Microsoft.Toolkit.Uwp.UI.Controls/Microsoft.Toolkit.Uwp.UI.Controls.csproj
+++ b/Microsoft.Toolkit.Uwp.UI.Controls/Microsoft.Toolkit.Uwp.UI.Controls.csproj
@@ -66,7 +66,6 @@
     <Compile Include="GridSplitter\GridSplitter.Events.cs" />
     <Compile Include="GridSplitter\GridSplitter.Helper.cs" />
     <Compile Include="GridSplitter\GridSplitter.Options.cs" />
-    <Compile Include="GridSplitter\GridSplitterGripper.cs" />
     <Compile Include="GridSplitter\GripperHoverWrapper.cs" />
     <Compile Include="HamburgerMenu\MenuItems\HamburgerMenuItem.cs" />
     <Compile Include="HamburgerMenu\MenuItems\HamburgerMenuGlyphItem.cs" />

From 3e6070df3b060299e148e6162622a66f283486f1 Mon Sep 17 00:00:00 2001
From: "lukas.f" <lukas.fellechner@gmx.net>
Date: Sun, 7 May 2017 22:00:04 +0200
Subject: [PATCH 2/3] GridSplitter: Rework according to review commments.

---
 .../GridSplitter/GridSplitter.Events.cs                   | 7 ++++---
 .../GridSplitter/GridSplitter.Options.cs                  | 8 +++++---
 .../GridSplitter/GridSplitter.cs                          | 2 --
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Events.cs b/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Events.cs
index 5a7d7ca77cf..219f4beb808 100644
--- a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Events.cs
+++ b/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Events.cs
@@ -58,19 +58,18 @@ private void CreateGripperDisplay()
         {
             if (_gripperDisplay == null)
             {
-                var gripperText = _resizeDirection == GridResizeDirection.Columns ? GripperBarVertical : GripperBarHorizontal;
                 _gripperDisplay = new TextBlock
                 {
                     FontFamily = new FontFamily(GripperDisplayFont),
                     HorizontalAlignment = HorizontalAlignment.Center,
                     VerticalAlignment = VerticalAlignment.Center,
                     Foreground = GripperForeground,
-                    Text = gripperText
+                    Text = _resizeDirection == GridResizeDirection.Columns ? GripperBarVertical : GripperBarHorizontal
                 };
             }
         }
 
-        private void GridSplitter_KeyDown(object sender, KeyRoutedEventArgs e)
+        protected override void OnKeyDown(KeyRoutedEventArgs e)
         {
             var step = 1;
             var ctrl = Window.Current.CoreWindow.GetKeyState(VirtualKey.Control);
@@ -115,6 +114,8 @@ private void GridSplitter_KeyDown(object sender, KeyRoutedEventArgs e)
 
                 e.Handled = true;
             }
+
+            base.OnKeyDown(e);
         }
 
         /// <inheritdoc />
diff --git a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Options.cs b/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Options.cs
index 6b2d687b0f0..9ba47d4ff62 100644
--- a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Options.cs
+++ b/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Options.cs
@@ -181,11 +181,13 @@ public SplitterCursorBehavior CursorBehavior
         private static void OnGripperForegroundPropertyChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
         {
             var gridSplitter = (GridSplitter)d;
-            var grip = gridSplitter._gripperDisplay;
-            if (grip != null)
+
+            if (gridSplitter._gripperDisplay == null)
             {
-                grip.Foreground = gridSplitter.GripperForeground;
+                return;
             }
+
+            gridSplitter._gripperDisplay.Foreground = gridSplitter.GripperForeground;
         }
 
         private static void OnGripperCursorPropertyChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
diff --git a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.cs b/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.cs
index 434c44d693d..bd847824b14 100644
--- a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.cs
+++ b/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.cs
@@ -175,11 +175,9 @@ protected override void OnApplyTemplate()
 
             // Unhook registered events
             Loaded -= GridSplitter_Loaded;
-            KeyDown -= GridSplitter_KeyDown;
 
             // Register Events
             Loaded += GridSplitter_Loaded;
-            KeyDown += GridSplitter_KeyDown;
 
             _hoverWrapper?.UnhookEvents();
 

From e63ba1e932f042280ba93efad2e78d4db7daece2 Mon Sep 17 00:00:00 2001
From: "lukas.f" <lukas.fellechner@gmx.net>
Date: Tue, 16 May 2017 21:23:54 +0200
Subject: [PATCH 3/3] GridSplitter: Add missing comment

---
 .../GridSplitter/GridSplitter.Events.cs                          | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Events.cs b/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Events.cs
index 219f4beb808..e79effd3768 100644
--- a/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Events.cs
+++ b/Microsoft.Toolkit.Uwp.UI.Controls/GridSplitter/GridSplitter.Events.cs
@@ -69,6 +69,7 @@ private void CreateGripperDisplay()
             }
         }
 
+        /// <inheritdoc />
         protected override void OnKeyDown(KeyRoutedEventArgs e)
         {
             var step = 1;