Skip to content

Avoid auto-generating ObservableValidator.HasError #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Avoid auto-generating ObservableValidator.HasError #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CommunityToolkit.Mvvm/ComponentModel/ObservableValidator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ protected ObservableValidator(ValidationContext validationContext)
}

/// <inheritdoc/>
[Display(AutoGenerateField = false)]
public bool HasErrors => this.totalErrors > 0;

/// <summary>
Expand Down
15 changes: 14 additions & 1 deletion tests/CommunityToolkit.Mvvm.UnitTests/Test_ObservableValidator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,20 @@ public void Test_ObservableValidator_ValidateAllProperties_IncludeInheritedPrope
Assert.IsFalse(model.HasErrors);
Assert.IsTrue(events.Count == 1);

Assert.IsTrue(events.Any(e => e.PropertyName == nameof(DerivedModelWithValidatableProperties.Name))); }
Assert.IsTrue(events.Any(e => e.PropertyName == nameof(DerivedModelWithValidatableProperties.Name)));
}

// See https://github.com/CommunityToolkit/dotnet/issues/881
[TestMethod]
public void Test_ObservableValidator_HasErrors_IncludeNonAutogenerateAttribute()
{
DerivedModelWithValidatableProperties model = new();

DisplayAttribute? displayAttribute = model.GetType().GetProperty(nameof(ObservableValidator.HasErrors))?.GetCustomAttribute<DisplayAttribute>();

Assert.IsNotNull(displayAttribute);
Assert.IsFalse(displayAttribute.AutoGenerateField);
}

public class Person : ObservableValidator
{
Expand Down