Add makefile targets to run serials and parallel e2e tests #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The e2e test framework keeps track of tests that are safe to run concurrently and which must be run serially. For example, tests that focus on scanning and don't interfere with each other are safe to run in parallel. Tests that apply remediations to the cluster impact other tests that assert specific checks or outcomes from a scan. We typically lump all these tests into a single run using `make e2e` and ensure the concurrent tests are run first, followed by the serial tests. By adding separate makefile targets, we're making it easier for contributors to run a group of tests, instead of the whole suite, shortening the feedback loop. We can also use this in CI and create separate jobs, running parallel tests and serial tests on different clusters, speeding up CI reporting time. It's also easier to see, at a glance, if a particular set of tests is failing consistently. This change also adds a layer of abstraction between contributors and the internal details of the tests, giving us more flexibility to evolve the tests and reorganize them as we see fit without as much disruption to contributors.
|
Proposing this in CI here - openshift/release#36941 |
Vincent056
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
/lgtm
let's merge this one so we can test e2e on the openshift/release#36941
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
added the labels that prow wants |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The e2e test framework keeps track of tests that are safe to run
concurrently and which must be run serially.
For example, tests that focus on scanning and don't interfere with each
other are safe to run in parallel. Tests that apply remediations to the
cluster impact other tests that assert specific checks or outcomes from
a scan.
We typically lump all these tests into a single run using
make e2eandensure the concurrent tests are run first, followed by the serial tests.
By adding separate makefile targets, we're making it easier for
contributors to run a group of tests, instead of the whole suite,
shortening the feedback loop. We can also use this in CI and create
separate jobs, running parallel tests and serial tests on different
clusters, speeding up CI reporting time. It's also easier to see, at a
glance, if a particular set of tests is failing consistently.
This change also adds a layer of abstraction between contributors and
the internal details of the tests, giving us more flexibility to evolve
the tests and reorganize them as we see fit without as much disruption
to contributors.