Add cleanup logging after tests run #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've noticed that some of the tests aren't cleaning up the way we expect. Specifically, some of the compliance scans are still laying around even when we exit the context Cleanup() function, which is designed to execute a bunch of callbacks to cleanup test resources. This probably isn't much of a problem in CI since the cluster gets torn down after the tests run, but it impacts contributor's ability to re-use the same environment for multiple e2e runs. Ideally, we want to run a single test in isolation and have it cleanup after itself so we can continue using the same environment. This commit adds basic logging in Cleanup() that logs how many scans are left over before we tear down the environment.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Looks like the issue is in CI, too: |
|
adding the labels that prow wants |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed that some of the tests aren't cleaning up the way we
expect. Specifically, some of the compliance scans are still laying
around even when we exit the context Cleanup() function, which is
designed to execute a bunch of callbacks to cleanup test resources.
This probably isn't much of a problem in CI since the cluster gets torn
down after the tests run, but it impacts contributor's ability to re-use
the same environment for multiple e2e runs. Ideally, we want to run a
single test in isolation and have it cleanup after itself so we can
continue using the same environment.
This commit adds basic logging in Cleanup() that logs how many scans are
left over before we tear down the environment.