Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HyperShift usage doc #252

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Add HyperShift usage doc #252

merged 1 commit into from
Mar 24, 2023

Conversation

Vincent056
Copy link

Added documentation on how to run a scan on HyperShift Management Cluster

@openshift-ci openshift-ci bot requested review from mrogers950 and rhmdnd March 7, 2023 10:07
@openshift-ci openshift-ci bot added the approved label Mar 7, 2023
@Vincent056
Copy link
Author

This usage doc works with #235 and ComplianceAsCode/content#10333

jhrozek
jhrozek approved these changes Mar 16, 2023
View reviewed changes
Copy link

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
the technical content is good, let's have @sheriff-rh review the language aspect

@openshift-ci openshift-ci bot added the lgtm label Mar 16, 2023
@sheriff-rh
Copy link
Collaborator

Docs LGTM! Is this expected to land in 1.0.0?

@rhmdnd
Copy link

rhmdnd commented Mar 17, 2023

Docs LGTM! Is this expected to land in 1.0.0?

This will likely be after 1.0.0 since 1.0.0 will be pretty much the same code as 0.1.61.

@openshift-ci openshift-ci bot removed the lgtm label Mar 20, 2023
@jhrozek
Copy link

jhrozek commented Mar 21, 2023

@Vincent056 can you rebase again? I'll lgtm once the PR applies cleanly atop master..

jhrozek
jhrozek approved these changes Mar 22, 2023
View reviewed changes
Copy link

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 22, 2023
@Vincent056
Add HyperShift usage
4f6aa65 
Added documentation on how to run scan on HyperShift Management Cluster
@openshift-ci openshift-ci bot removed the lgtm label Mar 24, 2023
jhrozek
jhrozek approved these changes Mar 24, 2023
View reviewed changes
Copy link

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhrozek, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c17861c into ComplianceAsCode:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhrozek jhrozek jhrozek approved these changes

@mrogers950 mrogers950 Awaiting requested review from mrogers950

@rhmdnd rhmdnd Awaiting requested review from rhmdnd

Assignees

@jhrozek jhrozek

Labels
approved docs-approved lgtm px-approved qe-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vincent056 @sheriff-rh @rhmdnd @jhrozek @openshift-merge-robot