Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated test context method #261

Conversation

rhmdnd
Copy link

@rhmdnd rhmdnd commented Mar 16, 2023

The GetNamespace method was deprecated and we have a suitable
replacement called GetOperatorNamespace. All test code is already
updated to use the new method.

This commit removes the deprecated function so we don't have cruft
laying around.

The GetNamespace method was deprecated and we have a suitable
replacement called GetOperatorNamespace. All test code is already
updated to use the new method.

This commit removes the deprecated function so we don't have cruft
laying around.
@rhmdnd
Copy link
Author

rhmdnd commented Mar 16, 2023

/retest

Looks like an issue with the node pool.

@rhmdnd
Copy link
Author

rhmdnd commented Mar 17, 2023

/retest

Looks like an issue with the node pool.

Must be some flakiness in how we're dealing with node pools, which we should investigate, but unrelated to this patch.

Copy link

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhrozek, rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants