Add ability to deploy CO on Hosted Cluster through OLM #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs #331 to merge to work |
jhrozek
approved these changes
May 23, 2023
There was a problem hiding this comment.
LGTM, only two small nits. Will discuss with @sheriff-rh regarding downstream doc options.
doc/usage.md
Outdated
| without any tailoredProfile. Any unsupport rules will be hidden from the `ComplianceCheckResult`. | ||
|
|
||
| However, you need to use a sepcial subscription file to install Compliance Operator on the |
There was a problem hiding this comment.
Suggested change
| However, you need to use a sepcial subscription file to install Compliance Operator on the | |
| However, you need to use a special subscription file to install Compliance Operator on the |
doc/usage.md
Outdated
| ## How to Use Compliance Operator with HyperShift Hosted Cluster | ||
|
|
||
| Compliance Operator is able to run platform scan on the HyperShift Hosted cluster |
There was a problem hiding this comment.
Suggested change
| Compliance Operator is able to run platform scan on the HyperShift Hosted cluster | |
| Compliance Operator is able to run a platform scan on the HyperShift Hosted cluster |
Vincent056
force-pushed
the
olm_hypershift
branch
from
30836ff
to
21ac1e2
Compare
|
/retest |
Vincent056
force-pushed
the
olm_hypershift
branch
from
21ac1e2
to
b750aa6
Compare
Added Subscription file needed for deploying CO on HyperShift Hosted Cluster through OLM, it can be used from both upstream or downstream sources.
Vincent056
force-pushed
the
olm_hypershift
branch
from
b750aa6
to
22837f3
Compare
|
/hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhrozek, rhmdnd, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Subscription file needed for deploying CO on HyperShift Hosted Cluster through OLM, it can be used from both upstream or downstream sources.