Add test file needed for testing CaC content #493
Conversation
|
the e2e will fail because of ComplianceAsCode/content#11614 |
|
/hold for test |
this will be internal for testing only changes @BhargaviGudi |
|
/unhold |
There was a problem hiding this comment.
Thanks for adding some coverage for this case, Vincent.
Some potential optimizations based on some related comments in ComplianceAsCode/content#11615.
|
the e2e failure will be fix with #495 |
|
Looks like this is ready for a rebase to pickup the fix in #495 . |
Add required test file so we can test if datastream can be parsed correctly by parser.
| defer ds.Close() | ||
|
|
||
| dsDom, err := ParseContent(ds) | ||
| Expect(err).NotTo(HaveOccurred()) |
There was a problem hiding this comment.
Nitpick: This Expect() is redundant given the following It() and Expect() clause, right?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BhargaviGudi, Vincent056, yuumasato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 4596084
into
ComplianceAsCode:master
Add required test file so we can test if datastream can be parsed correctly by parser.