Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e for TestManualRulesTailoredProfile #495

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix e2e for TestManualRulesTailoredProfile #495

merged 1 commit into from
Mar 4, 2024

Conversation

Vincent056
Copy link

@Vincent056 Vincent056 commented Mar 4, 2024 •
edited
Loading

We were using DisableOutdatedReferenceValidation as a label instead of an annotation, this commit fixes it.

Errors:

=== NAME  TestManualRulesTailoredProfile
    main_test.go:2765: compliancesuites.compliance.openshift.io "manual-rules-test-node" not found
--- FAIL: TestManualRulesTailoredProfile (1835.67s)
FAIL

@Vincent056
Fix e2e for TestManualRulesTailoredProfile
1702404 
We were using DisableOutdatedReferenceValidation as a label instead of an annotation, this commit fixes it
@openshift-ci openshift-ci bot added the approved label Mar 4, 2024
@Vincent056 Vincent056 mentioned this pull request Mar 4, 2024
Merged
@rhmdnd
Copy link

rhmdnd commented Mar 4, 2024

We were using DisableOutdatedReferenceValidation as a label instead of an annotation, this commit fixes it.

Errors:

=== NAME  TestManualRulesTailoredProfile
    main_test.go:2765: compliancesuites.compliance.openshift.io "manual-rules-test-node" not found
--- FAIL: TestManualRulesTailoredProfile (1835.67s)
FAIL

Interesting - when did this start failing?

rhmdnd
rhmdnd approved these changes Mar 4, 2024
View reviewed changes
Copy link

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, but curious why this started failing.

@openshift-ci openshift-ci bot added the lgtm label Mar 4, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Vincent056
Copy link
Author

Looks reasonable, but curious why this started failing.

not sure why it is started to fail just recently.

@Vincent056 Vincent056 merged commit 5b4e351 into ComplianceAsCode:master Mar 4, 2024
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhmdnd rhmdnd rhmdnd approved these changes

@mrogers950 mrogers950 Awaiting requested review from mrogers950

@xiaojiey xiaojiey Awaiting requested review from xiaojiey

Assignees

@rhmdnd rhmdnd

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vincent056 @rhmdnd