Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubelet event creation limit to 50 #10950

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Update kubelet event creation limit to 50 #10950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afa8e6e
Update default event creation limit to 50
yuumasato Aug 3, 2023
794fabc
Keep the rule's e2e result aligned with CI version
yuumasato Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion applications/openshift/kubelet/kubelet_configure_event_creation/tests/ocp4/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
---
default_result: PASS
# This rule fails by default on 4.13, and passes by default on 4.14
default_result: FAIL
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - good to know. We'll need to flip this bit when we start using 4.14 in CaC CI

https://github.com/openshift/release/blob/master/ci-operator/config/ComplianceAsCode/content/ComplianceAsCode-content-master.yaml#L12

result_after_remediation: PASS
4 changes: 3 additions & 1 deletion applications/openshift/kubelet/var_event_record_qps.var
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,6 @@ operator: equals
interactive: false

options:
default: 5
default: 50
5: 5
50: 50
1 change: 1 addition & 0 deletions products/ocp4/profiles/cis.profile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ selections:
- cis_ocp_1_4_0:all
### Variables
- var_openshift_audit_profile=WriteRequestBodies
- var_event_record_qps=50
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit superfluous, since the default value is being changed to 50.
But this is more explicit though.

### Helper Rules
### This is a helper rule to fetch the required api resource for detecting OCP version
- version_detect_in_ocp
Expand Down
Loading