Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove override-true-all-profile-* tests #11077

Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Sep 8, 2023

Description:

Removes the override-true-all-profile-* tests from the project.

Rationale:

Fixes #11051

During the review #11075 it was discussed that we cover this in the Profile unit tests.
I believe that this is now covered by test_profile_to_xml_element in tests/unit/ssg-module/test_build_yaml.py.

This is now covered by test_profile_to_xml_element
@Mab879 Mab879 added Infrastructure Our content build system Test Suite Update in Test Suite. labels Sep 8, 2023
@Mab879 Mab879 added this to the 0.1.70 milestone Sep 8, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Sep 8, 2023

Code Climate has analyzed commit d00185b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.8% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Sep 8, 2023
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice discovery! I confirm that the test data in the test tests/unit/ssg-module/test_build_yaml.py in tests/unit/ssg-module/data/ospp.xml contain <title> and <description> element with override attributes both set to true, which ensures that the method Profile.to_xml_element() will contain these attributes.

@jan-cerny jan-cerny merged commit e0c0e0c into ComplianceAsCode:master Sep 8, 2023
34 checks passed
@Mab879 Mab879 deleted the remove_override_true_tests branch September 8, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests override-true-all-profile fail with new libxml2
2 participants