Ability to add deposit receipts in the stub #8139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanBratanov
force-pushed
the
add_deposit_receipts_stub
branch
from
71c0148 to
5446cc4
Compare
StefanBratanov
force-pushed
the
add_deposit_receipts_stub
branch
from
5446cc4 to
d16bc33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Configured by a static constant
GENERATE_DEPOSIT_RECEIPTS. Defaulting tofalsesince we don't want random deposit receipts in the stub and end up in an inactivity leak.Also changed
engineGetPayloadto pass a state instead of slot. This could be useful in the future as well if we need more information.Fixed Issue(s)
related to #7898
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog