-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fullscreen options #33
Comments
I think enabling it by default would be the way to go and then having an option to override. My issue was with how android doesn't open the video into full screen unless allowFullScreen is there, which I feel is expected behavior for users. |
This is fixed in
|
Enables fullscreen for Vimeo by default to align with YouTube Fixes cookpete/react-player#33
It looks like this is no longer an option: https://github.com/vimeo/player.js#embed-options |
Enables fullscreen for Vimeo by default to align with YouTube Fixes cookpete/react-player#33
Enables fullscreen for Vimeo by default to align with YouTube Fixes cookpete/react-player#33
Enables fullscreen for Vimeo by default to align with YouTube Fixes cookpete/react-player#33
Enables fullscreen for Vimeo by default to align with YouTube Fixes cookpete/react-player#33
How to disable fullScreen for YouTube Videos ?? |
Enables fullscreen for Vimeo by default to align with YouTube Fixes cookpete/react-player#33
After seeing @scpaye506's fork that enables fullscreen on Vimeo, I wonder if we should enable fullscreen for Vimeo by default? It could still be overridden back to
false
via thevimeoConfig
prop. If not, I would be inclined to disable fullscreen on YouTube, to align behaviour across players.Even fullscreen for
FilePlayer
is possible, but would requirecontrols
to be enabled.Perhaps there is a need for a top level
allowFullScreen
prop?The text was updated successfully, but these errors were encountered: