Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

progressInterval default to 0? #339

Closed
RoelVB opened this issue Feb 25, 2018 · 1 comment
Closed

progressInterval default to 0? #339

RoelVB opened this issue Feb 25, 2018 · 1 comment

Comments

@RoelVB
Copy link

RoelVB commented Feb 25, 2018

First, thanks you for this great library!

Second, I have a problem with the progressInterval property. Looks like the interval defaults to 0.
Only setting (the deprecated) progressFrequency creates an interval.
@cookpete
Copy link
Owner

Good spot! The progressInterval logic was lost in 42a030e.

Fixed in version 1.2.1

david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue Dec 23, 2018
Add progressInterval logic back in to onProgress
8086b8c 
progressInterval change was not moved to Player component in 42a030e6cfa721eb15c6af2b27c828160ebcae25
Fixes cookpete/react-player#339
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue May 23, 2020
Add progressInterval logic back in to onProgress
83ce720 
progressInterval change was not moved to Player component in 42a030e6cfa721eb15c6af2b27c828160ebcae25
Fixes cookpete/react-player#339
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
@albanqoku
Add progressInterval logic back in to onProgress
b17501e 
progressInterval change was not moved to Player component in 42a030e6cfa721eb15c6af2b27c828160ebcae25
Fixes cookpete/react-player#339
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
@Webmaster1116
Add progressInterval logic back in to onProgress
212a225 
progressInterval change was not moved to Player component in 42a030e6cfa721eb15c6af2b27c828160ebcae25
Fixes cookpete/react-player#339
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
@webmiraclepro
Add progressInterval logic back in to onProgress
59a05e2 
progressInterval change was not moved to Player component in 42a030e6cfa721eb15c6af2b27c828160ebcae25
Fixes cookpete/react-player#339
philip-luther added a commit to philip-luther/react-player that referenced this issue Nov 22, 2024
@philip-luther
Add progressInterval logic back in to onProgress
b04f54f 
progressInterval change was not moved to Player component in 42a030e6cfa721eb15c6af2b27c828160ebcae25
Fixes cookpete/react-player#339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cookpete @RoelVB