New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onDuration returns null for HTML5 player #52

Closed

whitegrey opened this issue Apr 12, 2016 · 2 comments

whitegrey commented Apr 12, 2016

onDuration will return null if you programmatically set playing={true} immediately after the component mounts. The video will still play. This problem doesn't exist for youtube sources.

I assume this is because onDuration is being called before the video has fully loaded because putting playVideo() in a timeOut will fix the problem.

Owner

cookpete commented Apr 13, 2016

I've just taken a look and it looks like the oncanplay HTML5 player event is being called after the onplay event when you set playing={true} like you describe. I guess we need a better way of knowing when duration is ready (the call has already moved from onReady to onPlay in 8ef84fb to fix an issue with Youtube)

cookpete added a commit that referenced this issue


          Add failing onDuration test

964f4b9

To duplicate the issue outlined in #52

cookpete added a commit that referenced this issue


          Add failing onDuration test

564243e

To duplicate the issue outlined in #52

cookpete closed this as completed in

fea78c0

Owner

cookpete commented Jun 3, 2016

Fixed in 0.7.2

david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue


          Add failing onDuration test

0861cb4

To duplicate the issue outlined in cookpete/react-player#52

david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue


          Fix onDuration being called with null

eb65248

Some players need onDuration to be called onReady (FilePlayer) and some need it onPlay (YouTube)
Instead of spreading onDuration amongst individual player files, here we just delay onDuration until onPlay if it returns null when onReady fires
Fixes cookpete/react-player#52

david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue


          Add failing onDuration test

da66a85

To duplicate the issue outlined in cookpete/react-player#52

david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue


          Fix onDuration being called with null

c450452

Some players need onDuration to be called onReady (FilePlayer) and some need it onPlay (YouTube)
Instead of spreading onDuration amongst individual player files, here we just delay onDuration until onPlay if it returns null when onReady fires
Fixes cookpete/react-player#52

albanqoku added a commit to albanqoku/react-player that referenced this issue


          Add failing onDuration test

7c26a29

To duplicate the issue outlined in cookpete/react-player#52

albanqoku added a commit to albanqoku/react-player that referenced this issue


          Fix onDuration being called with null

031fdd3

Some players need onDuration to be called onReady (FilePlayer) and some need it onPlay (YouTube)
Instead of spreading onDuration amongst individual player files, here we just delay onDuration until onPlay if it returns null when onReady fires
Fixes cookpete/react-player#52

Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue


          Add failing onDuration test

ad534b5

To duplicate the issue outlined in cookpete/react-player#52

Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue


          Fix onDuration being called with null

3edf898

Some players need onDuration to be called onReady (FilePlayer) and some need it onPlay (YouTube)
Instead of spreading onDuration amongst individual player files, here we just delay onDuration until onPlay if it returns null when onReady fires
Fixes cookpete/react-player#52

webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue


          Add failing onDuration test

ac9350a

To duplicate the issue outlined in cookpete/react-player#52

webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue


          Fix onDuration being called with null

8c486d9

Some players need onDuration to be called onReady (FilePlayer) and some need it onPlay (YouTube)
Instead of spreading onDuration amongst individual player files, here we just delay onDuration until onPlay if it returns null when onReady fires
Fixes cookpete/react-player#52

philip-luther added a commit to philip-luther/react-player that referenced this issue


          Add failing onDuration test

e5c08ab

To duplicate the issue outlined in cookpete/react-player#52

philip-luther added a commit to philip-luther/react-player that referenced this issue


          Fix onDuration being called with null

bc3315b

Some players need onDuration to be called onReady (FilePlayer) and some need it onPlay (YouTube)
Instead of spreading onDuration amongst individual player files, here we just delay onDuration until onPlay if it returns null when onReady fires
Fixes cookpete/react-player#52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment