Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak Vimeo duration logic #251

Merged
merged 2 commits into from Oct 17, 2017
Merged

tweak Vimeo duration logic #251

merged 2 commits into from Oct 17, 2017

Conversation

ghost
Copy link

@ghost ghost commented Oct 17, 2017

Hey!
It's about that issue: #250
If we want to add setDuration logic in this.player.ready().then(...) instead of this.player.on("loaded"), we also should to add the tweak from that PR.

@cookpete
Copy link
Owner

Good spot. Maybe we should move it to loaded event listener instead so we don't have to repeat?

this.player.on('loaded', () => {
  this.onReady()
  this.player.getDuration().then(duration => {
    this.duration = duration
  })
})

@ghost
Copy link
Author

ghost commented Oct 17, 2017

@cookpete #250 (comment) :)
Can I do it?

@cookpete cookpete merged commit 65bc8cc into cookpete:master Oct 17, 2017
@ghost ghost deleted the vimeo-duration-tweak branch October 17, 2017 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant