Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update HLS and DASH SDK to use latest versions #513

Closed
wants to merge 3 commits into from

Conversation

mmaloon
Copy link

@mmaloon mmaloon commented Nov 5, 2018

Use HLS/DASH library url's taken from respective projects' readme's
Prevent loading of HLS/Dash media source if player has already unmounted

@cookpete
Copy link
Owner

There is already some logic in the getSDK util to prevent loading a resource twice.

I'm wary of always loading the absolute latest version of any SDK. Any future change that may cause an error will break every implementation of ReactPlayer everywhere.

Maybe a better solution would be to hardcode the current latest (after testing it works), then add hlsVersion and dashVersion to the config prop to allow anyone to pass in whatever version they want to use in future?

@cookpete cookpete closed this Nov 15, 2018
cookpete added a commit that referenced this pull request Nov 17, 2018
Also bump to latest versions
Closes #513
@mmaloon
Copy link
Author

mmaloon commented Nov 18, 2018

de8d961 is actually addressing a different issue from the SDK loading multiple times. It actually handles the scenario where if you load an HLS file player for the first time, then unmount it before the SDK has async loaded, the SDK load promise resolves and it creates the hlsPlayer and starts loading the HLS src even the react-player is no longer mounted (and hence impossible to access and destroy this newly created hlsPlayer)

david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this pull request Dec 23, 2018
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this pull request May 23, 2020
albanqoku added a commit to albanqoku/react-player that referenced this pull request Feb 24, 2021
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this pull request May 20, 2021
webmiraclepro added a commit to webmiraclepro/video-player that referenced this pull request Sep 9, 2022
philip-luther added a commit to philip-luther/react-player that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants