fix: avoid div with zero in assert_approx_eq #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
approved these changes
Apr 15, 2024
|
@mergify backport release/2.0 release/1.5 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
* fix: avoid div with zero in assert_approx_eq * test: Add tests for assert_approx_eq with zero * refactor: Make equal check in assert_approx_eq more explicit (cherry picked from commit 23b1130)
mergify bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
* fix: avoid div with zero in assert_approx_eq * test: Add tests for assert_approx_eq with zero * refactor: Make equal check in assert_approx_eq more explicit (cherry picked from commit 23b1130)
This was referenced Apr 15, 2024
webmaster128
pushed a commit
that referenced
this pull request
Apr 15, 2024
* fix: avoid div with zero in assert_approx_eq * test: Add tests for assert_approx_eq with zero * refactor: Make equal check in assert_approx_eq more explicit (cherry picked from commit 23b1130) Co-authored-by: Michael Young <2496187+Miyou@users.noreply.github.com>
webmaster128
pushed a commit
that referenced
this pull request
Apr 15, 2024
* fix: avoid div with zero in assert_approx_eq * test: Add tests for assert_approx_eq with zero * refactor: Make equal check in assert_approx_eq more explicit (cherry picked from commit 23b1130) Co-authored-by: Michael Young <2496187+Miyou@users.noreply.github.com>
|
Thank you. Nice improvement here. The patch is now backported to 2.0.x and 1.5.x and will be included in the next patch releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when both values are zero
assert_approx_eqfails due to division by zero rather than succeeding because the values are the same. This fixes that.