Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional ecdsa tests prototype #2121

Merged
merged 10 commits into from
Apr 26, 2024
Merged

Additional ecdsa tests prototype #2121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b880f7e
Add rootberg secp256k1 tests
chipshort Apr 17, 2024
a859707
Fix rootberg tests
chipshort Apr 19, 2024
4b63877
Fix path in comment
chipshort Apr 24, 2024
e74a100
Use position iterator method
chipshort Apr 24, 2024
6232951
Simplify rootberg test number check
chipshort Apr 24, 2024
50ae2a6
Use non-normalized rootberg test vectors
chipshort Apr 24, 2024
e5c0003
Refactor crypto tests
chipshort Apr 24, 2024
18e2008
Add rootberg secp256r1 tests
chipshort Apr 24, 2024
3b9eaaa
Fix formatting
chipshort Apr 24, 2024
8540874
Uncomment eprintln in test cases
chipshort Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/crypto/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ serde = { version = "1.0.103", default-features = false, features = ["derive", "
serde_json = "1.0.40"
sha2 = "0.10"
sha3 = "0.10"
hex = "0.4"
hex = { version = "0.4", features = ["serde"] }
hex-literal = "0.4.1"
english-numbers = "0.3"

Expand Down
21 changes: 21 additions & 0 deletions packages/crypto/testdata/rootberg/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Rootberg test data

This folder contains test vectors from
[Project Rootberg](https://github.com/bleichenbacher-daniel/Rooterberg) to
increase the test coverage of public key recovery implementations.

This test data is used by integration tests in `test/rootberg_*.rs`.

## Update

To ensure integrity of the files and update them to the latest version, run this
from the repo root:

```sh
(cd packages/crypto/testdata/rootberg \
&& curl -sSL https://github.com/bleichenbacher-daniel/Rooterberg/raw/main/ecdsa/ecdsa_secp256k1_keccak256_raw.json > ecdsa_secp256k1_keccak256_raw.json \
&& curl -sSL https://github.com/bleichenbacher-daniel/Rooterberg/raw/main/ecdsa/ecdsa_secp256k1_sha_256_raw.json > ecdsa_secp256k1_sha_256_raw.json \
&& curl -sSL https://github.com/bleichenbacher-daniel/Rooterberg/raw/main/ecdsa/ecdsa_secp256r1_keccak256_raw.json > ecdsa_secp256r1_keccak256_raw.json \
&& curl -sSL https://github.com/bleichenbacher-daniel/Rooterberg/raw/main/ecdsa/ecdsa_secp256r1_sha_256_raw.json > ecdsa_secp256r1_sha_256_raw.json \
)
```
Loading