Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass empty attribute value through stack #1719

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Pass empty attribute value through stack #1719

merged 1 commit into from
Nov 15, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 15, 2023

Abusing ping-pong test as hack to fail fast when Event attributes are handled differently by the IBC + SDK stack.
Relates to #1617

@alpe alpe requested a review from pinosu November 15, 2023 09:25
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pinosu pinosu added the backport/v0.4x backport patches to sdk47 release branch label Nov 15, 2023
@alpe alpe merged commit 09ae328 into main Nov 15, 2023
16 checks passed
@alpe alpe deleted the 1617_regression branch November 15, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.4x backport patches to sdk47 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants