[PROD-14034] Reduce loki query range to avoid rounding errors #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We think that passing the exact max query range to loki can lead to some rounding error if the values do not align with the current moon phase. Reducing drastically (from the default 30d1h default value) the query range should limit this issue. Anyway, loki should not be used like that from the api, it's better suited for grafana and we should think going back to archiving logs in argo workflows directly.
sjoubert
force-pushed
the
reduce_loki_query_range_PROD-14034
branch
from
204cbc0 to
f608c36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We think that passing the exact max query range to loki can lead to some rounding error if the values do not align with the current moon phase. Reducing drastically (from the default 30d1h default value) the query range should limit this issue.
Anyway, loki should not be used like that from the api, it's better suited for grafana and we should think going back to archiving logs in argo workflows directly.