From 6ba9ef00f6bf1173b4ed74de9b37d3d71cd88d28 Mon Sep 17 00:00:00 2001 From: Yangki Zhang Date: Mon, 19 Nov 2018 18:51:51 +0800 Subject: [PATCH] [REFACTOR]:[fix typo] (#2804) fix typos --- .../src/main/java/org/apache/dubbo/common/Version.java | 8 ++++---- .../java/org/apache/dubbo/common/version/VersionTest.java | 8 ++++---- .../org/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/Version.java b/dubbo-common/src/main/java/org/apache/dubbo/common/Version.java index 983cbb98e1dc..5c0ab763a70c 100644 --- a/dubbo-common/src/main/java/org/apache/dubbo/common/Version.java +++ b/dubbo-common/src/main/java/org/apache/dubbo/common/Version.java @@ -41,9 +41,9 @@ public final class Version { /** * For protocol compatibility purpose. - * Because {@link #isSupportResponseAttatchment} is checked for every call, int compare expect to has higher performance than string. + * Because {@link #isSupportResponseAttachment} is checked for every call, int compare expect to has higher performance than string. */ - private static final int LOWEST_VERSION_FOR_RESPONSE_ATTATCHMENT = 20002; // 2.0.2 + private static final int LOWEST_VERSION_FOR_RESPONSE_ATTACHMENT = 20002; // 2.0.2 private static final Map VERSION2INT = new HashMap(); static { @@ -62,7 +62,7 @@ public static String getVersion() { return VERSION; } - public static boolean isSupportResponseAttatchment(String version) { + public static boolean isSupportResponseAttachment(String version) { if (version == null || version.length() == 0) { return false; } @@ -72,7 +72,7 @@ public static boolean isSupportResponseAttatchment(String version) { return false; } - return iVersion >= LOWEST_VERSION_FOR_RESPONSE_ATTATCHMENT; + return iVersion >= LOWEST_VERSION_FOR_RESPONSE_ATTACHMENT; } public static int getIntVersion(String version) { diff --git a/dubbo-common/src/test/java/org/apache/dubbo/common/version/VersionTest.java b/dubbo-common/src/test/java/org/apache/dubbo/common/version/VersionTest.java index d03e69855ea3..a129f53e58c9 100644 --- a/dubbo-common/src/test/java/org/apache/dubbo/common/version/VersionTest.java +++ b/dubbo-common/src/test/java/org/apache/dubbo/common/version/VersionTest.java @@ -30,9 +30,9 @@ public void testGetProtocolVersion() { } @Test - public void testSupportResponseAttatchment() { - Assert.assertTrue(Version.isSupportResponseAttatchment("2.0.2")); - Assert.assertTrue(Version.isSupportResponseAttatchment("2.0.3")); - Assert.assertFalse(Version.isSupportResponseAttatchment("2.0.0")); + public void testSupportResponseAttachment() { + Assert.assertTrue(Version.isSupportResponseAttachment("2.0.2")); + Assert.assertTrue(Version.isSupportResponseAttachment("2.0.3")); + Assert.assertFalse(Version.isSupportResponseAttachment("2.0.0")); } } diff --git a/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java b/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java index 60b36ee681f9..d6a8e14ed390 100644 --- a/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java +++ b/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java @@ -191,7 +191,7 @@ protected void encodeRequestData(Channel channel, ObjectOutput out, Object data, protected void encodeResponseData(Channel channel, ObjectOutput out, Object data, String version) throws IOException { Result result = (Result) data; // currently, the version value in Response records the version of Request - boolean attach = Version.isSupportResponseAttatchment(version); + boolean attach = Version.isSupportResponseAttachment(version); Throwable th = result.getException(); if (th == null) { Object ret = result.getValue();