Remove CROW_CAN_USE_CPP14 and CROW_CAN_USE_CPP17 macros
#969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugdea1er
force-pushed
the
configuration
branch
from
132c221 to
eb644ed
Compare
|
I haven't touch #if defined(_MSC_VER)
#if _MSC_VER < 1900
#define CROW_MSVC_WORKAROUND
#define constexpr const
#define noexcept throw()
#endif
#endif |
|
I agree, I pushed C++ standard to 17 some month ago. |
|
@gittiver CodeQL actions fails, it can't find asio Looks like it doesn't work on main too |
gittiver
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove legacy configuration macros
They are no longer needed since Crow requires C++17
Removed:
CROW_CAN_USE_CPP14andCROW_CAN_USE_CPP17– C++17 requiredCROW_FILESYSTEM_IS_EXPERIMENTAL– C++17 includesstd::filesystemCROW_GCC83_WORKAROUND– that was only for C++11