From 4dd468a5bb51136836560d6f539a703d2d3e67ea Mon Sep 17 00:00:00 2001 From: Joshua Hiller Date: Mon, 23 Aug 2021 13:58:28 -0400 Subject: [PATCH 1/4] Fix Uber passing empty ids array. Closes #314. --- src/falconpy/_util.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/falconpy/_util.py b/src/falconpy/_util.py index 39acb1503..c6dd4e19e 100644 --- a/src/falconpy/_util.py +++ b/src/falconpy/_util.py @@ -323,6 +323,9 @@ def calc_url_from_args(target_url: str, passed_args: dict) -> str: delim = "&" if "?" in target_url else "?" target_url = f"{target_url}{delim}file_name={str(passed_args['file_name'])}" + # Bug fix: Issue #313 - Passing an empty ids array is causing a 400 in the IOC API + target_url = target_url.replace("?ids={}", "") + return target_url From b530463ba89ab8fdfcd1c360e69f68978b63da29 Mon Sep 17 00:00:00 2001 From: Joshua Hiller Date: Mon, 23 Aug 2021 15:46:34 -0400 Subject: [PATCH 2/4] Bump version -> 0.6.2 --- src/falconpy/_version.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/falconpy/_version.py b/src/falconpy/_version.py index 58004c640..9b4738ed0 100644 --- a/src/falconpy/_version.py +++ b/src/falconpy/_version.py @@ -36,7 +36,7 @@ For more information, please refer to """ -_VERSION = '0.6.1' +_VERSION = '0.6.2' _MAINTAINER = 'Joshua Hiller' _AUTHOR = 'CrowdStrike' _AUTHOR_EMAIL = 'falconpy@crowdstrike.com' From 7b6e44c7d77106900862e2dc116448d49cc85bae Mon Sep 17 00:00:00 2001 From: Joshua Hiller Date: Mon, 23 Aug 2021 15:46:44 -0400 Subject: [PATCH 3/4] Update CHANGELOG.md --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 51088a40e..674658e97 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +# Version 0.6.2 +## Issues resolved ++ Bug fix: Fixed Uber class passing empty **ids** parameter array when no _ids_ had been provided to the command method. Closes #314. `_util.py` + # Version 0.6.1 ## Issues resolved + Bug fix: Fixed bad comparison for endpoint lookups when using Service Classes. Closes #305. `_util.py` From ac04c46e5c3253d78e9db023afedcaf1d18130bc Mon Sep 17 00:00:00 2001 From: Joshua Hiller Date: Mon, 23 Aug 2021 15:50:06 -0400 Subject: [PATCH 4/4] Fix typo --- src/falconpy/_util.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/falconpy/_util.py b/src/falconpy/_util.py index c6dd4e19e..c954ef969 100644 --- a/src/falconpy/_util.py +++ b/src/falconpy/_util.py @@ -323,7 +323,7 @@ def calc_url_from_args(target_url: str, passed_args: dict) -> str: delim = "&" if "?" in target_url else "?" target_url = f"{target_url}{delim}file_name={str(passed_args['file_name'])}" - # Bug fix: Issue #313 - Passing an empty ids array is causing a 400 in the IOC API + # Bug fix: Issue #314 - Passing an empty ids array is causing a 400 in the IOC API target_url = target_url.replace("?ids={}", "") return target_url