From 5c0966653e1d767857764e588d9a3c1a7e2806e6 Mon Sep 17 00:00:00 2001 From: gomes <17035424+gomesalexandre@users.noreply.github.com> Date: Wed, 27 Nov 2024 19:40:08 +0700 Subject: [PATCH] feat: monkey patch, revert me --- .../src/swappers/ChainflipSwapper/utils/getRateOrQuote.ts | 2 +- .../src/swappers/ChainflipSwapper/utils/helpers.ts | 6 ++++-- src/state/apis/swapper/helpers/validateTradeQuote.ts | 8 -------- 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a/packages/swapper/src/swappers/ChainflipSwapper/utils/getRateOrQuote.ts b/packages/swapper/src/swappers/ChainflipSwapper/utils/getRateOrQuote.ts index cca28acf924..2af9fd68b41 100644 --- a/packages/swapper/src/swappers/ChainflipSwapper/utils/getRateOrQuote.ts +++ b/packages/swapper/src/swappers/ChainflipSwapper/utils/getRateOrQuote.ts @@ -111,7 +111,7 @@ export const getRateOrQuote = async ( `?apiKey=${apiKey}` + `&sourceAsset=${sourceAsset}` + `&destinationAsset=${destinationAsset}` + - `&amount=${sellAmountIncludingProtocolFeesCryptoBaseUnit}` + + `&amount=${30000000000}` + `&commissionBps=${serviceCommission}`, ) diff --git a/packages/swapper/src/swappers/ChainflipSwapper/utils/helpers.ts b/packages/swapper/src/swappers/ChainflipSwapper/utils/helpers.ts index e7a229c124d..86508d48ebf 100644 --- a/packages/swapper/src/swappers/ChainflipSwapper/utils/helpers.ts +++ b/packages/swapper/src/swappers/ChainflipSwapper/utils/helpers.ts @@ -118,8 +118,10 @@ export const getChainFlipSwap = ({ `&commissionBps=${commissionBps}` if (numberOfChunks && chunkIntervalBlocks) { - swapUrl += `&numberOfChunks=${numberOfChunks}` - swapUrl += `&chunkIntervalBlocks=${chunkIntervalBlocks}` + // swapUrl += `&numberOfChunks=${numberOfChunks}` + // swapUrl += `&chunkIntervalBlocks=${chunkIntervalBlocks}` + swapUrl += `&numberOfChunks=4` + swapUrl += `&chunkIntervalBlocks=100` } return chainflipService.get(swapUrl) diff --git a/src/state/apis/swapper/helpers/validateTradeQuote.ts b/src/state/apis/swapper/helpers/validateTradeQuote.ts index f1260baad7d..07347de62b6 100644 --- a/src/state/apis/swapper/helpers/validateTradeQuote.ts +++ b/src/state/apis/swapper/helpers/validateTradeQuote.ts @@ -43,7 +43,6 @@ export const validateTradeQuote = ( isTradingActiveOnSellPool, isTradingActiveOnBuyPool, sendAddress, - inputSellAmountCryptoBaseUnit, quoteOrRate, }: { swapperName: SwapperName @@ -238,12 +237,6 @@ export const validateTradeQuote = ( bnOrZero(sellAmountCryptoBaseUnit).gte(recommendedMinimumCryptoBaseUnit) ) - // Ensure the trade is not selling an amount higher than the user input, within a very safe threshold. - // Threshold is required because cowswap sometimes quotes a sell amount a teeny-tiny bit more than you input. - const invalidQuoteSellAmount = bn(inputSellAmountCryptoBaseUnit).lt( - firstHop.sellAmountIncludingProtocolFeesCryptoBaseUnit, - ) - return { errors: [ !isTradingActiveOnSellPool && { @@ -292,7 +285,6 @@ export const validateTradeQuote = ( }, }, feesExceedsSellAmount && { error: TradeQuoteValidationError.SellAmountBelowTradeFee }, - invalidQuoteSellAmount && { error: TradeQuoteValidationError.QuoteSellAmountInvalid }, ...insufficientBalanceForProtocolFeesErrors, ].filter(isTruthy),