Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xnor/issue 1 #2

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Xnor/issue 1 #2

merged 3 commits into from
Sep 17, 2024

Conversation

x37v
Copy link
Contributor

@x37v x37v commented Sep 17, 2024

fixes #1

note, the max patch only had 1 actual change.. removing the @title rnbo as it makes the default export name rnbo.cpp
the real change is in the RNBOSaw.cpp

@x37v x37v requested a review from isabelgk September 17, 2024 19:04
isabelgk
isabelgk approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@isabelgk isabelgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@isabelgk isabelgk merged commit fc6c674 into main Sep 17, 2024
1 check passed
@x37v x37v deleted the xnor/issue-1 branch September 17, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelgk isabelgk isabelgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error while building RNBOSaw with Visual Studio 2022
2 participants
@x37v @isabelgk