-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON validation fails for valid timestamps #265
Comments
I think it will need some adjustments, based on the dependabot PR: |
Yeah, unfortunately, I don't know enough about .NET to be helpful in creating a PR for this :( |
I have created a PR to update JsonSchema.Net: |
It validated successfully when a timestamp "2022-12-21T23:54:20.218381200Z" was used. |
mtsfoni
pushed a commit
that referenced
this issue
May 19, 2024
#265 Update to newer version of JsonSchema.Net --------- Signed-off-by: andreas hilti <andreas.hilti@bluewin.ch>
Lars, it's finally done!
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Over in Rust land @jadamcrain opened an issue that our JSON files are invalid.
cyclonedx-cli fails on timestamps like
2022-12-21T23:54:20.218381200Z
but it works if we chop off two digits at the end2022-12-21T23:54:20.2183812Z
According to the JSON Schema timestamps are
date-time
fields which are RFC 3339 timestamps. The RFC doesn't specify a maximum number of fractional digits so both timestamps should be correct.I'm not a .NET expert so take everything past this with a huge grain of salt:
As such I suggest to update the dependency to a newer version.
I can submit a trivial PR to update the version number but as I have zero knowledge about .NET tools that might not be enough and it might not build.
The text was updated successfully, but these errors were encountered: