Bring A100 fix to the new boundary to better test on HPC. this should be descarde if it fails but may be pulled to Dev branch if successfull. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been broken for a while!
CyprienBosserelle
added a commit
that referenced
this pull request
Aug 13, 2024
* Bug fix and implement no-flux approach * fix no flux top and right bnd * Update Boundary.cu Added new ABS bnd fcn for flux * Fix new halo wall bnds * convert test into proper CI test * Fix ABS1D Q calculations * ABS1DQ clean function call and add qmean * ABS1DQ Fix h miising in fctn call * Add New "NoFlux" Bnd to BBox bnd * Fix case on header call * fix on left and bot wall * make test for all side * u v bnd fix * add comment to test * clean up the function * Update Boundary.h * implement handling fcnt for flux bnd * Fix wall bnd for Left and right side Also improve the test! * Update Testing.cu * fix for flux test-demo * Update Boundary.cu * build new structures to support AOI bnds * Add workflow for new bnd initialisation * Update InitialConditions.cu * Start the init bnd functionality * Fix compile error forcing.h * Update InitialConditions.cu * fix to compile * Update ReadInput.cu * progress new bnd segment * Update ReadInput.cu * Add bndpoly functionality (Work in progress) * Added function to read bnd segment polygon * remove fileexist function * add new bnd seg to GPU mem * Add fill value of 0 for qmean * finish main workflow for new BND for GPU * Clean-up and debugging new boundary * DEBUG ABS bnd * Add limiter to remove instability near dry cells * Add taper to initial condition * Fix Dynamic forcing bnd * Ooops * debug check * Add CPU functions for bnd flux * Update Testing.cu * prevent fail in CPUvsGPU test * Bring A100 fix to the new boundary to better test on HPC. this should be descarde if it fails but may be pulled to Dev branch if successfull. (#109) * switch off deflate * Add function to optimise output writing * Update Write_netcdf.cu * debug level index when writting * fix + update of def nc var * Make loop increment declaration cleaner * Hotfix for deform This has been broken for a while! * Try fix aoi polygon * Add parameter to switch on/off the saving per block feature * Update ReadInput.cu * Fix GPU/CPU difference in new bnd * Fix failing test 0 * Fix AOI wall test * Update Boundary.cu * Update ReadInput.cu * Update main.yml * Update main.yml * Fix missing brace in testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.