New Bnd + New Save method #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be descarde if it fails but may be pulled to Dev branch if successfull. (#109) * switch off deflate * Add function to optimise output writing * Update Write_netcdf.cu * debug level index when writting * fix + update of def nc var * Make loop increment declaration cleaner * Hotfix for deform This has been broken for a while! * Try fix aoi polygon * Add parameter to switch on/off the saving per block feature * Update ReadInput.cu
New save methodAdded a new variable |
Crash/Instability fixed: Waikanae instability exampleIn Waikanae with rain-on-grid the old absorbing boundary (type=3) would crash almost immediately if the boundary intersected Kapiti Island. The crashing did not happen with type-2 boundary but tsunami like instability occured: The new boundary is very much stable with type=3: |
…lle/BG_Flood into Test_new_BND_A100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Bnd and New save method
This PR superseeds 2 PR: #101 and #98 .
They have been pre-merged to facilitate testing.
Save to file takes too long for many blocks
The problem
The current dev branch save each block independantly to the netcdf file. The bottleneck is the netcdf write function overhead which make writing large model (20000 blocks and more) quite slow.
The solution
To alleviate this needs a new function that combines all blocks in a single array (for each level/variable) and write the whole array at once to the netcdf file.
Hold on
While this will be faster, it is likely inefficient when there are few arrays in a level. Typically when the highest level has only a few block we would still be writing a full array.
Memory is cheap?
This will also be impossible if going to very high level where we won't be able to allocate memory to hold the highest level array.
The real solution
Something that combine both option above and decide what is the best compromise.
Collapse array
This may be a good time to introduce collapsing level to a single array and saving it to disk.
Other things
This branch also includes:
Using flux term for new boundary treatment
Proof of concept
Implementation
Testing
Docs