Spherical #78
Merged
Spherical #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delta is the cell size in m. whereas dx is for spherical grid units. for metric type grids dx == delta
DO NOT USE
16 tasks
CyprienBosserelle
added a commit
that referenced
this pull request
Oct 3, 2023
## Spherical (#78) * Add spherical fix to main kurganov * add cm and fm functions for spherical correction * replaced dx with delta where necessary delta is the cell size in m. whereas dx is for spherical grid units. for metric type grids dx == delta * Fix Spherical calculations * Update Makefile * Create codemap.md * add synonym for spherical * debug Nesting SPHerical * Fix Spherical adaptive * Fix error_new CalcFM funct * Missed a fix for new CalcFM * Try fix CalcFM * Arggggh * test fix fmvp * testfix2 * Reverting non-working fix * revert the non-working CPU fix * DEBUG spherical correction * Revert Calcres modification * Update gradient call to use delta * Update gradient call to use delta * Remove Printf in update function * Update dx to delta in gradient halo on GPU * Fix lake_at_rest issue * Add Bool param read function * Fix texture filter mode * add Function for river area * Fix Compile Bugs * Test No coarsening * Fix to resolve complaint from compiler * try fix compiler complaint * Fix edge clamp for atmp pressure * Fix for flipy check * Dxdy forcing (#91) * Add dy to forcing and interpolation * swich on the change * Fix for using dy in Forcing * Update Testing.cu * atmp warm start +bnd * add cm to Buttinger reconstruction * Fix Y direction correction for Butt. engine * Remove requirement on engine 2 when sph is requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.