Skip to content

Conversation

@filzrev
Copy link
Contributor

@filzrev filzrev commented Jul 16, 2025

This PR fix extra benchmark reports are included when using ZLinqBenchmarkFilter.

When running benchmarks with ZLinqBenchmarkFilter.
It's expected benchmarks that namespace starts with Benchmark.ZLinq are executed.
But current implementation include additional benchmarks.

Example of benchmark report
https://github.com/Cysharp/ZLinq/actions/runs/16308471300

Following benchmarks should not be reported for SystemLinq benchmarks.

  • Benchmark.IterateBenchmark
  • Benchmark.ReadMeBenchmark

Additional changes
Add scoped modifier to DistinctBattle.cs also
(It's fixed by #203. But benchmark project is not tested. Because I've tested with System.Linq.Tests.slnx)

@neuecc
Copy link
Member

neuecc commented Jul 17, 2025

hmn, thanks!

@neuecc neuecc merged commit 1e77b7e into Cysharp:main Jul 17, 2025
4 checks passed
IhateTrains pushed a commit to ParadoxGameConverters/ImperatorToCK3 that referenced this pull request Jul 27, 2025
Updated
[Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer.git)
from 2.0.205 to 2.0.208.

<details>
<summary>Release notes</summary>

_Sourced from [Meziantou.Analyzer's
releases](https://github.com/meziantou/Meziantou.Analyzer.git/releases)._

No release notes found for this version range.

Commits viewable in [compare
view](https://github.com/meziantou/Meziantou.Analyzer.git/commits).
</details>

Updated [Roslynator.Analyzers](https://github.com/dotnet/roslynator.git)
from 4.13.1 to 4.14.0.

<details>
<summary>Release notes</summary>

_Sourced from [Roslynator.Analyzers's
releases](https://github.com/dotnet/roslynator.git/releases)._

No release notes found for this version range.

Commits viewable in [compare
view](https://github.com/dotnet/roslynator.git/commits).
</details>

Updated [ZLinq](https://github.com/Cysharp/ZLinq) from 1.5.1 to 1.5.2.

<details>
<summary>Release notes</summary>

_Sourced from [ZLinq's
releases](https://github.com/Cysharp/ZLinq/releases)._

## 1.5.2

## What's Changed
* chore: Fix failed ci workflows by @​filzrev in
Cysharp/ZLinq#202
* chore: Fix build error when using .NET 10 SDK preview.6 by @​filzrev
in Cysharp/ZLinq#203
* chore: Fix ZLinqBenchmarkFilter exclude condition by @​filzrev in
Cysharp/ZLinq#205
* chore: update System.Linq compatibility tests by @​filzrev in
Cysharp/ZLinq#206
* Implement TakeLast performance optimizations and benchmarks by
@​Akeit0 in Cysharp/ZLinq#207


**Full Changelog**:
Cysharp/ZLinq@1.5.1...1.5.2

Commits viewable in [compare
view](Cysharp/ZLinq@1.5.1...1.5.2).
</details>

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants