Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ZStringWriter #50

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Add ZStringWriter #50

merged 1 commit into from
Apr 29, 2021

Conversation

lahma
Copy link
Contributor

@lahma lahma commented Apr 23, 2021

fixes #49

@lahma lahma mentioned this pull request Apr 23, 2021
Closed
@lahma
Copy link
Contributor Author

lahma commented Apr 23, 2021 •
edited
Loading

If Utf8ValueStringBuilder and Utf16ValueStringBuilder would implement an interface writer could also have a generic parameter. I think CLR would be able to devirtualize it to direct struct usage without boxing.

@neuecc
Copy link
Member

neuecc commented Apr 29, 2021

Thank you!
I'll merge! (Any tweaks for Unity will be done by me after the merge and released soon after)

@neuecc neuecc merged commit 7bf1a46 into Cysharp:master Apr 29, 2021
@lahma lahma deleted the ZStringWriter branch April 29, 2021 08:54
@lahma lahma mentioned this pull request Sep 6, 2023
Merged
@lahma lahma mentioned this pull request Mar 28, 2024
Merged
@sebastienros
Copy link

🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Built-in support for TextWriter implementations
3 participants
@lahma @neuecc @sebastienros