fix JabRef#3607

- made changelog easier to read
- moved opacity operations to correct locations
- readjusted opacity to correct value
- removed unused localization

CHANGELOG.md

@@ -29,7 +29,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
 - The export to MS Office XML now uses the month name for the field `MonthAcessed` instead of the two digit number [#7354](https://github.com/JabRef/jabref/issues/7354)
 - We included some standalone dialogs from the options menu in the main preference dialog and fixed some visual issues in the preferences dialog. [#7384](https://github.com/JabRef/jabref/pull/7384)
 - We improved the linking of the `python3` interpreter via the shebang to dynamically use the systems default Python. Related to [JabRef-Browser-Extension #177](https://github.com/JabRef/JabRef-Browser-Extension/issues/177)
-- Automatically found pdf files now have the linking button to the far left and uses the icon LINK_PLUS instead of BRIEFCASE_CHECK. The file name also has lowered opacity(70%) until added. [#3607](https://github.com/JabRef/JabRef-Browser-Extension/issues/3607)
+- Automatically found pdf files now have the linking button to the far left and uses a link icon with a plus instead of a briefcase. The file name also has lowered opacity(70%) until added. [#3607](https://github.com/JabRef/JabRef-Browser-Extension/issues/3607)
 
 ### Fixed
 

src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java

@@ -177,10 +177,12 @@ public JabRefIcon getTypeIcon() {
 
  public void markAsAutomaticallyFound() {
  isAutomaticallyFound.setValue(true);
+ opacityProperty.setValue(0.7);
  }
 
  public void acceptAsLinked() {
  isAutomaticallyFound.setValue(false);
+ opacityProperty.setValue(1.0);
  }
 
  public Observable[] getObservables() {

src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditor.java

@@ -159,10 +159,7 @@ private static Node createFileDisplay(LinkedFileViewModel linkedFile) {
  acceptAutoLinkedFile.setTooltip(new Tooltip(Localization.lang("This file was found automatically. Do you want to link it to this entry?")));
  acceptAutoLinkedFile.visibleProperty().bind(linkedFile.isAutomaticallyFoundProperty());
  acceptAutoLinkedFile.managedProperty().bind(linkedFile.isAutomaticallyFoundProperty());
- acceptAutoLinkedFile.setOnAction(event -> {
- linkedFile.acceptAsLinked();
- linkedFile.setOpacityProperty(1.0);
- });
+ acceptAutoLinkedFile.setOnAction(event -> linkedFile.acceptAsLinked());
  acceptAutoLinkedFile.getStyleClass().setAll("icon-button");
 
  Button writeXMPMetadata = IconTheme.JabRefIcons.IMPORT.asButton();

src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java

@@ -196,7 +196,6 @@ private List<LinkedFileViewModel> findAssociatedNotLinkedFiles(BibEntry entry) {
  preferences.getFilePreferences(),
  externalFileTypes);
  newLinkedFile.markAsAutomaticallyFound();
- newLinkedFile.setOpacityProperty(0.3);
  result.add(newLinkedFile);
  }
  } catch (IOException e) {

src/main/resources/l10n/JabRef_en.properties

@@ -1732,7 +1732,6 @@ Don't\ share=Don't share
 Share\ anonymous\ statistics=Share anonymous statistics
 Telemetry\:\ Help\ make\ JabRef\ better=Telemetry: Help make JabRef better
 To\ improve\ the\ user\ experience,\ we\ would\ like\ to\ collect\ anonymous\ statistics\ on\ the\ features\ you\ use.\ We\ will\ only\ record\ what\ features\ you\ access\ and\ how\ often\ you\ do\ it.\ We\ will\ neither\ collect\ any\ personal\ data\ nor\ the\ content\ of\ bibliographic\ items.\ If\ you\ choose\ to\ allow\ data\ collection,\ you\ can\ later\ disable\ it\ via\ Options\ ->\ Preferences\ ->\ General.=To improve the user experience, we would like to collect anonymous statistics on the features you use. We will only record what features you access and how often you do it. We will neither collect any personal data nor the content of bibliographic items. If you choose to allow data collection, you can later disable it via Options -> Preferences -> General.
-(Auto)=(Auto)
 This\ file\ was\ found\ automatically.\ Do\ you\ want\ to\ link\ it\ to\ this\ entry?=This file was found automatically. Do you want to link it to this entry?
 Names\ are\ not\ in\ the\ standard\ %0\ format.=Names are not in the standard %0 format.