Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autodump, automelt, autotrade: ability to disable announcements #1782

Closed
Areephe opened this issue Feb 28, 2021 · 6 comments · Fixed by #3285
Closed

autodump, automelt, autotrade: ability to disable announcements #1782

Areephe opened this issue Feb 28, 2021 · 6 comments · Fixed by #3285
Assignees
Labels
good first issue Good for newcomers idea Suggestions, etc.

Comments

@Areephe
Copy link

Areephe commented Feb 28, 2021

i need version of this plugins without anouncements, plz help

@myk002
Copy link
Member

myk002 commented Feb 28, 2021

Why do you need versions without announcements? That's how they communicate that they're working. There are already a number of announcement filter programs. Do they not meet your needs?

@Areephe
Copy link
Author

Areephe commented Feb 28, 2021

you about announcements window utility from PyLNP? I want disable "market dump 1 item" 100 hundred times on in-game announcements "a" window

@lethosor lethosor changed the title autodump.dll, automelt.dll, autotrade.dll without anouncements autodump, automelt, autotrade: ability to disable announcements Feb 28, 2021
@lethosor lethosor added the idea Suggestions, etc. label Feb 28, 2021
@lethosor
Copy link
Member

We don't distribute slightly-modified versions of plugins for things like this, because that would cause a lot of confusion. We could make these announcements configurable, though, and #212 is an existing similar request for some other plugins.

It doesn't look like these announcements can be filtered natively by DF (i.e. they don't correspond to a category in announcements.txt) so your best bet currently would be using a third-party tool to filter announcements, like myk002 mentioned.

It would also be possible to modify a personal copy of these plugins, if you're able to compile DFHack from source (although this is a bit harder on Windows than on other platforms). The plugins all appear to be pretty similar, so two options could be:

  • commenting out the showAnnouncement calls, or
  • changing DELTA_TICKS to a larger value to make the plugins check for stockpile changes less frequently

@myk002
Copy link
Member

myk002 commented Mar 15, 2022

This looks like a good candidate to move status messages to the Debug logging framework. Then they can be filtered with configuration in dfhack.init

@myk002 myk002 added the good first issue Good for newcomers label Mar 15, 2022
@lethosor
Copy link
Member

Does that support directing output to in-game announcements? I'm not sure how important it is to preserve that feature, if people rely on it for status updates (the messages are well-intentioned but can be excessive)

@myk002
Copy link
Member

myk002 commented Mar 16, 2022

Ah, no it does not. I was going back through the issue list and Debug.h was on my mind. I failed to appreciate that this was referring to announcements, not log messages. Does anyone care about the announcements? Maybe we can just move them to log messages..

@myk002 myk002 added this to 50.08-r1 Apr 18, 2023
@github-project-automation github-project-automation bot moved this to Todo in 50.08-r1 Apr 18, 2023
@myk002 myk002 self-assigned this Apr 18, 2023
@myk002 myk002 moved this from Todo to Being worked on in 50.08-r1 Apr 18, 2023
@myk002 myk002 moved this from Being worked on to Review In Progress in 50.08-r1 Apr 24, 2023
@myk002 myk002 removed this from 50.08-r1 Apr 28, 2023
@myk002 myk002 added this to 50.08-r4 Jun 12, 2023
@github-project-automation github-project-automation bot moved this to Todo in 50.08-r4 Jun 12, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in 50.08-r4 Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers idea Suggestions, etc.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants