Remove MapCache dependency for Items module #4824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove MapCache dependency * Alphabetize includes * Unindent namespace
* Remove MapCache dependency * Alphabetize includes
* Remove MapCache dependency * Move some code to utility fns * Alphabetize includes * Use enum namespace in switches
* Remove MapCache dependency * Alphabetize includes
* Item module fns no longer use MapCache * Alphabetized includes
* Alphabetized includes * Maps module unused * Initialize struct ClothingRequirement vars * Some tidying of code
* Remove MapCache dependency * Account for buildings as floors * Remove abusing namespace std * Alphabetize includes * Tidy some code
* Update autodump.cpp - allow dumping in air; cancel active jobs * Update autodump.rst * Update changelog.txt
* Update Lua API.rst * Update LuaApi.cpp * Update changelog.txt
myk002
reviewed
Jul 31, 2024
* Update changelog.txt * Update Items.cpp * Update MapCache.cpp * Update autodump.cpp * Update autodump.rst
myk002
approved these changes
Jul 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
MapCachedependency forItemsmodule.Moved a bunch of code out of a switch statement in
createitem.cppinto separate utility fns for readability.Made improvements to
autodump.cppso it's in line withgui/autodump. (Convert to projectile, cancel any active job.)Tidied up
autoclothing.cppa bit, made sure to initialize variables in a struct.Made
dfhack.items.moveToInventoryargsuse_modeandbody_partoptional.