Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): remote rules on Chromium disabled #690

Merged
merged 2 commits into from
May 15, 2022

Conversation

Rongronggg9
Copy link
Contributor

@Rongronggg9 Rongronggg9 commented Apr 16, 2022

#678 (comment)

#692 (comment)

Whether remote rules along with local-customized rules are enabled is totally up to UA; however, whether the update button to display is up to a synced variable. That is, if someone builds their own add-on without patches and installs, that variable will be set to false, applying patches then installing again will not update that variable to enable the update button. If you do clean your synced variables and build the master branch and install it, you will face exactly the same embarrassing situation.

whether remote rules are enabled is up to UA, not synced config
@DIYgod DIYgod merged commit 71351fd into DIYgod:master May 15, 2022
@Rongronggg9 Rongronggg9 deleted the fix/chromium-remote-rules branch May 16, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants