-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deque Analysis] Item Edit "Status" Tab "serious" accessibility issues #1190
Comments
Change section labels according to changes done in the submission form excel file
Good morning, @tdonohue! My name is Andrea Guevara and I'm part of Neki-it. I'd like to contribute a solution to this issue. We could solve the problem of overlap between the text and the buttons on the status page in two ways: In the first approach, we reduced the size of the texts to generate more space on the screen and in the second approach, we used grid system classes to improve responsiveness. Looking forward to your feedback! |
@Andrea-Guevara : Thanks for your suggestions. I, personally, would prefer the second approach (as there is less wrapping of text). But, I'm not against the first approach if it's much easier to achieve. I'll assign this to you to make others aware you / Neki-it are working on it. |
…status page using the item-operation component
… page using the item-operation component (cherry picked from commit e06b67f)
Deque Analysis Summary
Our Item Edit "Status" tab has a total of 5 serious accessibility issues (not including color contrast which are handled in other tickets).
(IDs 470076, 471046, 471452) "Selected state of the element is missing or incorrect." on all the tabs (not just Status). When a specific tab is active it should haveFIXED by aria-selected added to Item Edit "Status" Tab. Fixed ID: 470076 #2063aria-current
oraria-selected
specified to note the currently active page/tab.See also https://www.w3.org/TR/wai-aria-1.1/#aria-selected, https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel and/or https://www.w3.org/TR/wai-aria-1.1/#aria-current(ID 470077) "Purpose of the link is not clear in context." on the "Withdraw..." and "Move..." buttons/links (on Status tab). The links should have more detail ("Withdraw this Item" "Move this Item to a different Collection") either in the text itself, or in anFIXED by fixed ID 470077. Purpose of the link is not clear in context #2062aria-label
.(ID 471072) Content overlap at 320px width. When the browser has 320px width, the entire page suffers from content overlap.FIXED BY Accessibility of the status page #3148Full list of issues is viewable at (requires login): https://axeauditor.dequecloud.com/test-run/0856438a-a19a-11eb-bc31-b7d5be387c86/issues?activeTab=dt-issue&page=0&pageSize=50&sortField=ordinal&sortDir=asc&row=9&filter%5Bseverity%5D=3&filter%5Btype%5D=issue&filter%5Bpage_number%5D=12
More Information / Tools
The text was updated successfully, but these errors were encountered: