Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSTPER-144] Fixed issue with authorization request encountered while logging-in with shibboleth #1244

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

atarix83
Copy link
Contributor

References

Description

Fixed issue with authorization request encountered while logging-in with shibboleth

Instructions for Reviewers

Check the bug reported is no longer exist

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@tdonohue tdonohue added authentication: Shibboleth related to integration with Shibboleth bug high priority labels Jun 23, 2021
@tdonohue tdonohue added this to the 7.0 milestone Jun 23, 2021
@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge label Jun 23, 2021
@tdonohue tdonohue self-requested a review June 24, 2021 14:41
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @atarix83 ! I've tested and verified the Shibb bug on the demo site, and installed this PR on a local (Docker-based) Shib setup and found it fixes the bug. Code looks reasonable (though it doesn't have many code comments, but I'll let that slide this time as the tests are detailed). Thanks again.

@tdonohue tdonohue merged commit de8e306 into DSpace:main Jun 30, 2021
@atarix83 atarix83 mentioned this pull request Jul 20, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge authentication: Shibboleth related to integration with Shibboleth bug high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidemenu incomplete after Shibboleth login
2 participants