Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browserName and tree-shaking #133

Merged
merged 1 commit into from
Mar 7, 2020
Merged

Add browserName and tree-shaking #133

merged 1 commit into from
Mar 7, 2020

Conversation

IgorBabkin
Copy link
Contributor

  • add separate function to detect browser name
  • add tree-shaking

@DamonOehlman
Copy link
Owner

@IgorBabkin looks good - thanks for this. Merging it in.

@DamonOehlman DamonOehlman merged commit 01ba34b into DamonOehlman:master Mar 7, 2020
@DamonOehlman
Copy link
Owner

@IgorBabkin I'm about to publish the 5.0.0 version, which has been on the back-burner for a while now. No real breaking changes, so potentially qualifies for a minor release, but I'm pushing major anyway.

I'm pretty confident that all is well, but if you could take it for a spin and make sure everything works for your use case that would be appreciated.

@IgorBabkin
Copy link
Contributor Author

@DamonOehlman I've checked browserName and detect. Everything is okay for me. Just only one question: it's needed to pass navigator.userAgent to browserName. Is it okay for you? And maybe we need to describe this function in Readme?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants