Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

danger_options: adc ignore limit values #129

Merged
merged 1 commit into from
Jan 16, 2024
Merged

danger_options: adc ignore limit values #129

merged 1 commit into from
Jan 16, 2024

Conversation

rogerlz
Copy link
Contributor

@rogerlz rogerlz commented Jan 15, 2024

@rogerlz rogerlz requested a review from bwnance January 15, 2024 21:20
@rogerlz
Copy link
Contributor Author

rogerlz commented Jan 15, 2024

tested it myself with min_value: 10, max_value: 50 and disconnecting a thermistor

@rogerlz rogerlz changed the title danger_options: adc ignore minmax values danger_options: adc ignore limit values Jan 16, 2024
@rogerlz rogerlz merged commit d8faa86 into master Jan 16, 2024
2 checks passed
@rogerlz rogerlz deleted the adc_ignoreminmax branch January 16, 2024 00:41
@levins-law levins-law mentioned this pull request Apr 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwnance bwnance bwnance approved these changes

Assignees
No one assigned
Labels
ready-to-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rogerlz @bwnance