drop first probe #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identical to the commit by @ctso (https://github.com/ctso/klipper/commit/75beccd22a70b49b50ae20391b5c0054113eb7b7) except this also ignores the first probe in the probe accuracy command
|
Thanks for providing credit to @ctso with this commit! I think he'd like to join this as well. I'll ping him |
bwnance
approved these changes
Aug 17, 2022
|
@sporkus thanks and congrats on opening the first PR! LGTM, merge at will |
|
Heck yes! I can't print without this little patch, sorry I'm such a slacker on trying to get it merged somewhere 😂 |
Piezoid
pushed a commit
that referenced
this pull request
Sep 7, 2022
* Add option to ignore first probe samples authored by @ctso and @hifihedgehog
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The drop first result code was implemented by ctso and hifihedgehog. I've merely updated the docs. Although it is not dangerous, it might be of use to dangerous users. This feature had been rejected in the klipper master but is used by many klicky users (Klipper3d/klipper#3397).