Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug regression -- invalid git revision traversal #66

Closed
lawndoc opened this issue May 26, 2023 · 1 comment · Fixed by #67
Closed

Bug regression -- invalid git revision traversal #66

lawndoc opened this issue May 26, 2023 · 1 comment · Fixed by #67

Comments

@lawndoc
Copy link
Collaborator

lawndoc commented May 26, 2023 •
edited
Loading

Hey @DariuszPorowski, it looks like this line regressed in this commit and brought back a bug that was dealt with in #62.

We are seeing the action fail again in some situations when the first commit reference doesn't exist (due to the ^ reference).

github_error

Was reverting from ... back to ^.. directly related to the fix for #64? It's hard to tell because there were lots of changes in the regression commit and I wasn't involved in that one.
@lawndoc lawndoc mentioned this issue May 30, 2023
Merged
@DariuszPorowski
Copy link
Owner

@lawndoc oh shoot, my bad - do not why restored it.

@DariuszPorowski DariuszPorowski linked a pull request May 30, 2023 that will close this issue
Fix non-existent commit reference #67
Merged
DariuszPorowski pushed a commit that referenced this issue May 30, 2023
@lawndoc
Fix non-existent commit reference (#67)
5c3e70f 
Fixes the bug regression described in #66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix non-existent commit reference lawndoc/github-action-gitleaks
2 participants
@DariuszPorowski @lawndoc